From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v2 PATCH] Revert "crypto: run initcalls for generic implementations earlier"
Date: Wed, 30 Apr 2025 10:52:58 -0700 [thread overview]
Message-ID: <20250430175258.GC1958@sol.localdomain> (raw)
In-Reply-To: <aBHcftWYX1Pe9Ogh@gondor.apana.org.au>
On Wed, Apr 30, 2025 at 04:17:02PM +0800, Herbert Xu wrote:
> v2 moves lib/crypto to subsys_initcall en masse and removes the
> blake2s patch.
>
> ---8<---
> This reverts commit c4741b23059794bd99beef0f700103b0d983b3fd.
>
> Crypto API self-tests no longer run at registration time and now
> occur either at late_initcall or upon the first use.
>
> Therefore the premise of the above commit no longer exists. Revert
> it and subsequent additions of subsys_initcall and arch_initcall.
>
> Note that lib/crypto calls will stay at subsys_initcall (or rather
> downgraded from arch_initcall) because they may need to occur
> before Crypto API registration.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
The commit message shouldn't pretend that this is a 'git revert', since clearly
a lot of these changes were made by hand.
Otherwise this generally looks fine, but I also don't know where this applies
to, so I can't properly review it.
- Eric
next prev parent reply other threads:[~2025-04-30 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 5:50 [PATCH 1/1] Revert "crypto: run initcalls for generic implementations earlier" Herbert Xu
2025-04-29 16:41 ` Eric Biggers
2025-04-30 2:21 ` Herbert Xu
2025-04-30 3:16 ` Eric Biggers
2025-04-30 3:18 ` Herbert Xu
2025-04-30 8:17 ` [v2 PATCH] " Herbert Xu
2025-04-30 17:52 ` Eric Biggers [this message]
2025-06-05 14:29 ` Lukas Wunner
2025-06-09 9:44 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250430175258.GC1958@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.