All of lore.kernel.org
 help / color / mirror / Atom feed
* re: mfd: adp5585: add support for key events
@ 2025-05-01 11:09 Colin King (gmail)
  2025-05-01 11:19 ` Lee Jones
  2025-05-02  7:37 ` Nuno Sá
  0 siblings, 2 replies; 3+ messages in thread
From: Colin King (gmail) @ 2025-05-01 11:09 UTC (permalink / raw)
  To: Nuno Sá; +Cc: Lee Jones, linux-kernel@vger.kernel.org


[-- Attachment #1.1.1: Type: text/plain, Size: 411 bytes --]

Hi,

I noticed that there is an issue with the naming of device tree property 
in the commit:

commit f674cea99d03199a4fc9a96c68149b8804053f80
Author: Nuno Sá <nuno.sa@analog.com>
Date:   Tue Apr 15 15:49:26 2025 +0100

     mfd: adp5585: add support for key events


There is a property named "rst-passtrough-enable", should that be in 
fact "rst-passthrough-enable"? (an h is missing)

Colin

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 4901 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mfd: adp5585: add support for key events
  2025-05-01 11:09 mfd: adp5585: add support for key events Colin King (gmail)
@ 2025-05-01 11:19 ` Lee Jones
  2025-05-02  7:37 ` Nuno Sá
  1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2025-05-01 11:19 UTC (permalink / raw)
  To: Colin King (gmail); +Cc: Nuno Sá, linux-kernel@vger.kernel.org

On Thu, 01 May 2025, Colin King (gmail) wrote:

> Hi,
> 
> I noticed that there is an issue with the naming of device tree property in
> the commit:
> 
> commit f674cea99d03199a4fc9a96c68149b8804053f80
> Author: Nuno Sá <nuno.sa@analog.com>
> Date:   Tue Apr 15 15:49:26 2025 +0100
> 
>     mfd: adp5585: add support for key events
> 
> 
> There is a property named "rst-passtrough-enable", should that be in fact
> "rst-passthrough-enable"? (an h is missing)

Why not send a patch like you usually do?

-- 
Lee Jones [李琼斯]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mfd: adp5585: add support for key events
  2025-05-01 11:09 mfd: adp5585: add support for key events Colin King (gmail)
  2025-05-01 11:19 ` Lee Jones
@ 2025-05-02  7:37 ` Nuno Sá
  1 sibling, 0 replies; 3+ messages in thread
From: Nuno Sá @ 2025-05-02  7:37 UTC (permalink / raw)
  To: Colin King (gmail), Nuno Sá; +Cc: Lee Jones, linux-kernel@vger.kernel.org

On Thu, 2025-05-01 at 12:09 +0100, Colin King (gmail) wrote:
> Hi,
> 
> I noticed that there is an issue with the naming of device tree property 
> in the commit:
> 
> commit f674cea99d03199a4fc9a96c68149b8804053f80
> Author: Nuno Sá <nuno.sa@analog.com>
> Date:   Tue Apr 15 15:49:26 2025 +0100
> 
>      mfd: adp5585: add support for key events
> 
> 
> There is a property named "rst-passtrough-enable", should that be in 
> fact "rst-passthrough-enable"? (an h is missing)
> 
> 

I'll need to re-spin ate least one more version of the series. I'll fix the
spelling issue.

Thx!
- Nuno Sá


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-05-02  7:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-01 11:09 mfd: adp5585: add support for key events Colin King (gmail)
2025-05-01 11:19 ` Lee Jones
2025-05-02  7:37 ` Nuno Sá

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.