From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
"Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"John Snow" <jsnow@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-block@nongnu.org, qemu-ppc@nongnu.org
Subject: [PATCH v5 08/11] tests/qtest/libquos/pci: Add migration fixup helper for pci devices
Date: Fri, 2 May 2025 13:04:42 +1000 [thread overview]
Message-ID: <20250502030446.88310-9-npiggin@gmail.com> (raw)
In-Reply-To: <20250502030446.88310-1-npiggin@gmail.com>
Migration tests can create new QPCI devices for the destination
machine which may need to take on some state of the source machine
after destination is complete.
Add a migration fixup helper and call it from ahci migration tests.
This is currently a noop and will be used subsequently.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
tests/qtest/libqos/pci.h | 1 +
tests/qtest/ahci-test.c | 1 +
tests/qtest/libqos/pci.c | 4 ++++
3 files changed, 6 insertions(+)
diff --git a/tests/qtest/libqos/pci.h b/tests/qtest/libqos/pci.h
index ef40a6917d3..19f1dd13501 100644
--- a/tests/qtest/libqos/pci.h
+++ b/tests/qtest/libqos/pci.h
@@ -120,6 +120,7 @@ void qpci_memwrite(QPCIDevice *bus, QPCIBar token, uint64_t off,
const void *buf, size_t len);
QPCIBar qpci_iomap(QPCIDevice *dev, int barno, uint64_t *sizeptr);
void qpci_iounmap(QPCIDevice *dev, QPCIBar addr);
+void qpci_migrate_fixup(QPCIDevice *to, QPCIDevice *from);
QPCIBar qpci_legacy_iomap(QPCIDevice *dev, uint16_t addr);
void qpci_unplug_acpi_device_test(QTestState *qs, const char *id, uint8_t slot);
diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c
index 7d5f73ac40b..60eef9949db 100644
--- a/tests/qtest/ahci-test.c
+++ b/tests/qtest/ahci-test.c
@@ -137,6 +137,7 @@ static void ahci_migrate(AHCIQState *from, AHCIQState *to, const char *uri)
memcpy(to, from, sizeof(AHCIQState));
to->parent = tmp;
to->dev = dev;
+ qpci_migrate_fixup(to->dev, from->dev);
tmp = from->parent;
dev = from->dev;
diff --git a/tests/qtest/libqos/pci.c b/tests/qtest/libqos/pci.c
index 2bae119bfca..de95329e486 100644
--- a/tests/qtest/libqos/pci.c
+++ b/tests/qtest/libqos/pci.c
@@ -620,6 +620,10 @@ QPCIBar qpci_legacy_iomap(QPCIDevice *dev, uint16_t addr)
return bar;
}
+void qpci_migrate_fixup(QPCIDevice *to, QPCIDevice *from)
+{
+}
+
void add_qpci_address(QOSGraphEdgeOptions *opts, QPCIAddress *addr)
{
g_assert(addr);
--
2.47.1
next prev parent reply other threads:[~2025-05-02 3:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 3:04 [PATCH v5 00/11] tests/qtest: pci and msix fixes Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 01/11] tests/qtest: Enforce zero for the "un-fired" msix message value Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 02/11] tests/qtest: Fix virtio msix message endianness Nicholas Piggin
2025-05-05 5:05 ` Akihiko Odaki
2025-05-05 6:53 ` Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 03/11] tests/qtest: Add libqos function for testing msix interrupt status Nicholas Piggin
2025-05-05 5:37 ` Akihiko Odaki
2025-05-05 7:09 ` Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 04/11] tests/qtest: Enable spapr dma with linear iommu map Nicholas Piggin
2026-06-11 10:56 ` Alexander Mikhalitsyn
2025-05-02 3:04 ` [PATCH v5 05/11] tests/qtest/ahci: unmap pci bar before reusing device Nicholas Piggin
2025-05-05 5:03 ` Akihiko Odaki
2025-05-02 3:04 ` [PATCH v5 06/11] tests/qtest/ahci: don't unmap pci bar if it wasn't mapped Nicholas Piggin
2025-05-05 5:25 ` Akihiko Odaki
2025-05-05 6:54 ` Nicholas Piggin
2025-05-05 7:33 ` Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 07/11] tests/qtest/libquos/virtio: unmap pci bar when disabling device Nicholas Piggin
2025-05-02 3:04 ` Nicholas Piggin [this message]
2025-05-02 3:04 ` [PATCH v5 09/11] qtest/libqos/pci: Enforce balanced iomap/unmap Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 10/11] qtest/libqos/pci: Fix qpci_msix_enable sharing bar0 Nicholas Piggin
2025-05-02 3:04 ` [PATCH v5 11/11] qtest/libqos/pci: Factor msix entry helpers into pci common code Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502030446.88310-9-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=akihiko.odaki@daynix.com \
--cc=farosas@suse.de \
--cc=harshpb@linux.ibm.com \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.