All of lore.kernel.org
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: <vkoul@kernel.org>, <kishon@kernel.org>, <mripard@kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <sakari.ailus@linux.intel.com>, <u.kleine-koenig@baylibre.com>,
	<vigneshr@ti.com>, <aradhya.bhatia@linux.dev>, <s-jain1@ti.com>,
	<r-donadkar@ti.com>, <tomi.valkeinen@ideasonboard.com>,
	<devarsht@ti.com>
Subject: [PATCH v3 0/2] Fix PLL lock timeout and calibration wait time
Date: Fri, 2 May 2025 09:04:49 +0530	[thread overview]
Message-ID: <20250502033451.2291330-1-devarsht@ti.com> (raw)

This fixes PLL lockup and O_CMN_READY timeout by moving the polling
function after common state machine gets enabled. Also fix the
calibration wait time to optimize the polling time.

Changelog:
V3: 
-   Use read-modify-write for using calibrated value for PLL
    lock time
-   Move out PLL clock configuration part to power_on function

V2: Separate patch for calibration logic and
    return error code on polling 

Previous versions:
V2: https://lore.kernel.org/all/20250326152320.3835249-1-devarsht@ti.com/
V1: https://lore.kernel.org/all/20241230125319.941372-1-devarsht@ti.com/

Test logs:
Link: https://gist.github.com/devarsht/89e4830e886774fcd50aa6e29cce3a79

Rangediff:
V2->V3:
https://gist.github.com/devarsht/c4d2c4f6715ec7aa4df4cb2c7991b7aa

Devarsh Thakkar (2):
  phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling
  phy: cadence: cdns-dphy: Update calibration wait time for startup
    state machine

 drivers/phy/cadence/cdns-dphy.c | 111 +++++++++++++++++++++++++-------
 1 file changed, 87 insertions(+), 24 deletions(-)

-- 
2.39.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Devarsh Thakkar <devarsht@ti.com>
To: <vkoul@kernel.org>, <kishon@kernel.org>, <mripard@kernel.org>,
	<linux-phy@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <sakari.ailus@linux.intel.com>, <u.kleine-koenig@baylibre.com>,
	<vigneshr@ti.com>, <aradhya.bhatia@linux.dev>, <s-jain1@ti.com>,
	<r-donadkar@ti.com>, <tomi.valkeinen@ideasonboard.com>,
	<devarsht@ti.com>
Subject: [PATCH v3 0/2] Fix PLL lock timeout and calibration wait time
Date: Fri, 2 May 2025 09:04:49 +0530	[thread overview]
Message-ID: <20250502033451.2291330-1-devarsht@ti.com> (raw)

This fixes PLL lockup and O_CMN_READY timeout by moving the polling
function after common state machine gets enabled. Also fix the
calibration wait time to optimize the polling time.

Changelog:
V3: 
-   Use read-modify-write for using calibrated value for PLL
    lock time
-   Move out PLL clock configuration part to power_on function

V2: Separate patch for calibration logic and
    return error code on polling 

Previous versions:
V2: https://lore.kernel.org/all/20250326152320.3835249-1-devarsht@ti.com/
V1: https://lore.kernel.org/all/20241230125319.941372-1-devarsht@ti.com/

Test logs:
Link: https://gist.github.com/devarsht/89e4830e886774fcd50aa6e29cce3a79

Rangediff:
V2->V3:
https://gist.github.com/devarsht/c4d2c4f6715ec7aa4df4cb2c7991b7aa

Devarsh Thakkar (2):
  phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling
  phy: cadence: cdns-dphy: Update calibration wait time for startup
    state machine

 drivers/phy/cadence/cdns-dphy.c | 111 +++++++++++++++++++++++++-------
 1 file changed, 87 insertions(+), 24 deletions(-)

-- 
2.39.1


             reply	other threads:[~2025-05-02  3:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02  3:34 Devarsh Thakkar [this message]
2025-05-02  3:34 ` [PATCH v3 0/2] Fix PLL lock timeout and calibration wait time Devarsh Thakkar
2025-05-02  3:34 ` [PATCH v3 1/2] phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling Devarsh Thakkar
2025-05-02  3:34   ` Devarsh Thakkar
2025-05-14 10:29   ` Vinod Koul
2025-05-14 10:29     ` Vinod Koul
2025-06-20 14:41     ` Devarsh Thakkar
2025-06-20 14:41       ` Devarsh Thakkar
2025-05-26 10:59   ` Tomi Valkeinen
2025-05-26 10:59     ` Tomi Valkeinen
2025-06-20 14:35     ` Devarsh Thakkar
2025-06-20 14:35       ` Devarsh Thakkar
2025-06-20 15:08       ` Devarsh Thakkar
2025-06-20 15:08         ` Devarsh Thakkar
2025-06-18 10:01   ` Tomi Valkeinen
2025-06-18 10:01     ` Tomi Valkeinen
2025-06-20 15:07     ` Devarsh Thakkar
2025-06-20 15:07       ` Devarsh Thakkar
2025-05-02  3:34 ` [PATCH v3 2/2] phy: cadence: cdns-dphy: Update calibration wait time for startup state machine Devarsh Thakkar
2025-05-02  3:34   ` Devarsh Thakkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250502033451.2291330-1-devarsht@ti.com \
    --to=devarsht@ti.com \
    --cc=aradhya.bhatia@linux.dev \
    --cc=kishon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mripard@kernel.org \
    --cc=r-donadkar@ti.com \
    --cc=s-jain1@ti.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.