* Re: [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout
@ 2025-05-02 10:28 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-05-02 10:28 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250501054604.23368-1-himanshu.bhavani@siliconsignals.io>
References: <20250501054604.23368-1-himanshu.bhavani@siliconsignals.io>
TO: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
TO: krzk+dt@kernel.org
TO: tarang.raval@siliconsignals.io
CC: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
CC: Rob Herring <robh@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Shawn Guo <shawnguo@kernel.org>
CC: Sascha Hauer <s.hauer@pengutronix.de>
CC: Pengutronix Kernel Team <kernel@pengutronix.de>
CC: Fabio Estevam <festevam@gmail.com>
CC: devicetree@vger.kernel.org
CC: imx@lists.linux.dev
CC: linux-arm-kernel@lists.infradead.org
CC: linux-kernel@vger.kernel.org
Hi Himanshu,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on linus/master v6.15-rc4 next-20250501]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Himanshu-Bhavani/arm64-dts-imx8mp-var-som-Fix-LDO5-shutdown-causing-SD-card-timeout/20250501-134717
base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link: https://lore.kernel.org/r/20250501054604.23368-1-himanshu.bhavani%40siliconsignals.io
patch subject: [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout
:::::: branch date: 29 hours ago
:::::: commit date: 29 hours ago
config: arm64-randconfig-051-20250502 (https://download.01.org/0day-ci/archive/20250502/202505021728.k6KXBSMu-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
dtschema version: 2025.3.dev21+ge6ea659
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250502/202505021728.k6KXBSMu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202505021728.k6KXBSMu-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
>> arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dtb: regulator-usdhc2-vqmmc (regulator-gpio): 'gpios' is a required property
from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml#
>> arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dtb: regulator-usdhc2-vqmmc (regulator-gpio): Unevaluated properties are not allowed ('gpio' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml#
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout
@ 2025-05-01 5:46 Himanshu Bhavani
2025-05-01 8:42 ` Tarang Raval
2025-05-01 12:08 ` Rob Herring (Arm)
0 siblings, 2 replies; 4+ messages in thread
From: Himanshu Bhavani @ 2025-05-01 5:46 UTC (permalink / raw)
To: krzk+dt, tarang.raval
Cc: Himanshu Bhavani, Rob Herring, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
Fix SD card timeout issue caused by LDO5 regulator getting disabled
after boot.
The kernel log shows LDO5 being disabled, which leads to a timeout
on USDHC2:
[ 33.760561] LDO5: disabling
[ 81.119861] mmc1: Timeout waiting for hardware interrupt.
To prevent this, set regulator-boot-on and regulator-always-on for
LDO5. Also add the vqmmc regulator to properly support 1.8V/3.3V
signaling for USDHC2 using a GPIO-controlled regulator.
Fixes: 6c2a1f4f71258 ("arm64: dts: imx8mp-var-som-symphony: Add Variscite Symphony board and VAR-SOM-MX8MP SoM")
Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
---
kernel hangs during boot with the following logs:
[ 33.760561] LDO5: disabling
[ 81.119861] mmc1: Timeout waiting for hardware interrupt.
[ 81.119872] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
[ 81.119876] mmc1: sdhci: Sys addr: 0x00000010 | Version: 0x00000002
[ 81.119882] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000010
[ 81.119886] mmc1: sdhci: Argument: 0x00844358 | Trn mode: 0x0000002b
[ 81.119891] mmc1: sdhci: Present: 0x01f88009 | Host ctl: 0x00000012
[ 81.119896] mmc1: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
[ 81.119900] mmc1: sdhci: Wake-up: 0x00000008 | Clock: 0x0000003f
[ 81.119904] mmc1: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
[ 81.119908] mmc1: sdhci: Int enab: 0x117f100b | Sig enab: 0x117f100b
[ 81.119912] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
[ 81.119917] mmc1: sdhci: Caps: 0x07eb0000 | Caps_1: 0x0000b407
[ 81.119921] mmc1: sdhci: Cmd: 0x0000193a | Max curr: 0x00ffffff
[ 81.119925] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x0076b27f
[ 81.119929] mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00000900
[ 81.119933] mmc1: sdhci: Host ctl2: 0x00000008
[ 81.119937] mmc1: sdhci: ADMA Err: 0x00000003 | ADMA Ptr: 0x4003f204
[ 81.119941] mmc1: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP =========
[ 81.119944] mmc1: sdhci-esdhc-imx: cmd debug status: 0x21b0
[ 81.119949] mmc1: sdhci-esdhc-imx: data debug status: 0x2200
[ 81.119954] mmc1: sdhci-esdhc-imx: trans debug status: 0x2300
[ 81.119959] mmc1: sdhci-esdhc-imx: dma debug status: 0x2400
[ 81.119964] mmc1: sdhci-esdhc-imx: adma debug status: 0x2594
[ 81.119970] mmc1: sdhci-esdhc-imx: fifo debug status: 0x2608
[ 81.119976] mmc1: sdhci-esdhc-imx: async fifo debug status: 0x2798
[ 81.119981] mmc1: sdhci: ===========================================
---
arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
index b2ac2583a592..8d50e8382a1a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
@@ -35,7 +35,6 @@ memory@40000000 {
<0x1 0x00000000 0 0xc0000000>;
};
-
reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
compatible = "regulator-fixed";
regulator-name = "VSD_3V3";
@@ -46,6 +45,16 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
startup-delay-us = <100>;
off-on-delay-us = <12000>;
};
+
+ reg_usdhc2_vqmmc: regulator-usdhc2-vqmmc {
+ compatible = "regulator-gpio";
+ regulator-name = "VSD_VSEL";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio2 12 GPIO_ACTIVE_HIGH>;
+ gpios-states = <1>;
+ states = <3300000 0x0 1800000 0x1>;
+ };
};
&A53_0 {
@@ -158,6 +167,8 @@ ldo5: LDO5 {
regulator-name = "LDO5";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ regulator-always-on;
};
};
};
@@ -205,6 +216,7 @@ &usdhc2 {
pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
cd-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
vmmc-supply = <®_usdhc2_vmmc>;
+ vqmmc-supply = <®_usdhc2_vqmmc>;
bus-width = <4>;
status = "okay";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout
2025-05-01 5:46 Himanshu Bhavani
@ 2025-05-01 8:42 ` Tarang Raval
2025-05-01 12:08 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Tarang Raval @ 2025-05-01 8:42 UTC (permalink / raw)
To: Himanshu Bhavani
Cc: krzk+dt@kernel.org, Rob Herring, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Himanshu,
Thanks for the update
> Fix SD card timeout issue caused by LDO5 regulator getting disabled
> after boot.
>
> The kernel log shows LDO5 being disabled, which leads to a timeout
> on USDHC2:
> [ 33.760561] LDO5: disabling
> [ 81.119861] mmc1: Timeout waiting for hardware interrupt.
>
> To prevent this, set regulator-boot-on and regulator-always-on for
> LDO5. Also add the vqmmc regulator to properly support 1.8V/3.3V
> signaling for USDHC2 using a GPIO-controlled regulator.
>
> Fixes: 6c2a1f4f71258 ("arm64: dts: imx8mp-var-som-symphony: Add Variscite Symphony board and VAR-SOM-MX8MP SoM")
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> ---
>
> kernel hangs during boot with the following logs:
>
> [ 33.760561] LDO5: disabling
> [ 81.119861] mmc1: Timeout waiting for hardware interrupt.
> [ 81.119872] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 81.119876] mmc1: sdhci: Sys addr: 0x00000010 | Version: 0x00000002
> [ 81.119882] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000010
> [ 81.119886] mmc1: sdhci: Argument: 0x00844358 | Trn mode: 0x0000002b
> [ 81.119891] mmc1: sdhci: Present: 0x01f88009 | Host ctl: 0x00000012
> [ 81.119896] mmc1: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
> [ 81.119900] mmc1: sdhci: Wake-up: 0x00000008 | Clock: 0x0000003f
> [ 81.119904] mmc1: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
> [ 81.119908] mmc1: sdhci: Int enab: 0x117f100b | Sig enab: 0x117f100b
> [ 81.119912] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
> [ 81.119917] mmc1: sdhci: Caps: 0x07eb0000 | Caps_1: 0x0000b407
> [ 81.119921] mmc1: sdhci: Cmd: 0x0000193a | Max curr: 0x00ffffff
> [ 81.119925] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x0076b27f
> [ 81.119929] mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00000900
> [ 81.119933] mmc1: sdhci: Host ctl2: 0x00000008
> [ 81.119937] mmc1: sdhci: ADMA Err: 0x00000003 | ADMA Ptr: 0x4003f204
> [ 81.119941] mmc1: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP =========
> [ 81.119944] mmc1: sdhci-esdhc-imx: cmd debug status: 0x21b0
> [ 81.119949] mmc1: sdhci-esdhc-imx: data debug status: 0x2200
> [ 81.119954] mmc1: sdhci-esdhc-imx: trans debug status: 0x2300
> [ 81.119959] mmc1: sdhci-esdhc-imx: dma debug status: 0x2400
> [ 81.119964] mmc1: sdhci-esdhc-imx: adma debug status: 0x2594
> [ 81.119970] mmc1: sdhci-esdhc-imx: fifo debug status: 0x2608
> [ 81.119976] mmc1: sdhci-esdhc-imx: async fifo debug status: 0x2798
> [ 81.119981] mmc1: sdhci: ===========================================
>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> index b2ac2583a592..8d50e8382a1a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi
> @@ -35,7 +35,6 @@ memory@40000000 {
> <0x1 0x00000000 0 0xc0000000>;
> };
>
> -
> reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> compatible = "regulator-fixed";
> regulator-name = "VSD_3V3";
> @@ -46,6 +45,16 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> startup-delay-us = <100>;
> off-on-delay-us = <12000>;
> };
> +
> + reg_usdhc2_vqmmc: regulator-usdhc2-vqmmc {
> + compatible = "regulator-gpio";
> + regulator-name = "VSD_VSEL";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio2 12 GPIO_ACTIVE_HIGH>;
> + gpios-states = <1>;
You can remove gpios-states because we've already configured
a pull-up in the pinmux, so this is not required.
> + states = <3300000 0x0 1800000 0x1>;
> + };
> };
>
> &A53_0 {
> @@ -158,6 +167,8 @@ ldo5: LDO5 {
> regulator-name = "LDO5";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + regulator-always-on;
Instead of using regulator-always-on for LDO5, we should set
vin-supply = <&ldo5>; in the reg_usdhc2_vqmmc node. This
cleanly defines the power dependency and avoids keeping
LDO5 always on unnecessarily.
> };
> };
> };
> @@ -205,6 +216,7 @@ &usdhc2 {
> pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> cd-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
> vmmc-supply = <®_usdhc2_vmmc>;
> + vqmmc-supply = <®_usdhc2_vqmmc>;
> bus-width = <4>;
> status = "okay";
> };
> --
> 2.34.1
Otherwise LGTM.
Best Regards,
Tarang
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout
2025-05-01 5:46 Himanshu Bhavani
2025-05-01 8:42 ` Tarang Raval
@ 2025-05-01 12:08 ` Rob Herring (Arm)
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-05-01 12:08 UTC (permalink / raw)
To: Himanshu Bhavani
Cc: imx, Sascha Hauer, krzk+dt, devicetree, linux-arm-kernel,
tarang.raval, linux-kernel, Pengutronix Kernel Team, Shawn Guo,
Fabio Estevam, Conor Dooley
On Thu, 01 May 2025 11:16:03 +0530, Himanshu Bhavani wrote:
> Fix SD card timeout issue caused by LDO5 regulator getting disabled
> after boot.
>
> The kernel log shows LDO5 being disabled, which leads to a timeout
> on USDHC2:
> [ 33.760561] LDO5: disabling
> [ 81.119861] mmc1: Timeout waiting for hardware interrupt.
>
> To prevent this, set regulator-boot-on and regulator-always-on for
> LDO5. Also add the vqmmc regulator to properly support 1.8V/3.3V
> signaling for USDHC2 using a GPIO-controlled regulator.
>
> Fixes: 6c2a1f4f71258 ("arm64: dts: imx8mp-var-som-symphony: Add Variscite Symphony board and VAR-SOM-MX8MP SoM")
> Signed-off-by: Himanshu Bhavani <himanshu.bhavani@siliconsignals.io>
> ---
>
> kernel hangs during boot with the following logs:
>
> [ 33.760561] LDO5: disabling
> [ 81.119861] mmc1: Timeout waiting for hardware interrupt.
> [ 81.119872] mmc1: sdhci: ============ SDHCI REGISTER DUMP ===========
> [ 81.119876] mmc1: sdhci: Sys addr: 0x00000010 | Version: 0x00000002
> [ 81.119882] mmc1: sdhci: Blk size: 0x00000200 | Blk cnt: 0x00000010
> [ 81.119886] mmc1: sdhci: Argument: 0x00844358 | Trn mode: 0x0000002b
> [ 81.119891] mmc1: sdhci: Present: 0x01f88009 | Host ctl: 0x00000012
> [ 81.119896] mmc1: sdhci: Power: 0x00000002 | Blk gap: 0x00000080
> [ 81.119900] mmc1: sdhci: Wake-up: 0x00000008 | Clock: 0x0000003f
> [ 81.119904] mmc1: sdhci: Timeout: 0x0000008f | Int stat: 0x00000000
> [ 81.119908] mmc1: sdhci: Int enab: 0x117f100b | Sig enab: 0x117f100b
> [ 81.119912] mmc1: sdhci: ACmd stat: 0x00000000 | Slot int: 0x00000502
> [ 81.119917] mmc1: sdhci: Caps: 0x07eb0000 | Caps_1: 0x0000b407
> [ 81.119921] mmc1: sdhci: Cmd: 0x0000193a | Max curr: 0x00ffffff
> [ 81.119925] mmc1: sdhci: Resp[0]: 0x00000900 | Resp[1]: 0x0076b27f
> [ 81.119929] mmc1: sdhci: Resp[2]: 0x325b5900 | Resp[3]: 0x00000900
> [ 81.119933] mmc1: sdhci: Host ctl2: 0x00000008
> [ 81.119937] mmc1: sdhci: ADMA Err: 0x00000003 | ADMA Ptr: 0x4003f204
> [ 81.119941] mmc1: sdhci-esdhc-imx: ========= ESDHC IMX DEBUG STATUS DUMP =========
> [ 81.119944] mmc1: sdhci-esdhc-imx: cmd debug status: 0x21b0
> [ 81.119949] mmc1: sdhci-esdhc-imx: data debug status: 0x2200
> [ 81.119954] mmc1: sdhci-esdhc-imx: trans debug status: 0x2300
> [ 81.119959] mmc1: sdhci-esdhc-imx: dma debug status: 0x2400
> [ 81.119964] mmc1: sdhci-esdhc-imx: adma debug status: 0x2594
> [ 81.119970] mmc1: sdhci-esdhc-imx: fifo debug status: 0x2608
> [ 81.119976] mmc1: sdhci-esdhc-imx: async fifo debug status: 0x2798
> [ 81.119981] mmc1: sdhci: ===========================================
>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-var-som.dtsi | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250501 (exact match)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/freescale/' for 20250501054604.23368-1-himanshu.bhavani@siliconsignals.io:
arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dtb: regulator-usdhc2-vqmmc (regulator-gpio): 'gpios' is a required property
from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml#
arch/arm64/boot/dts/freescale/imx8mp-var-som-symphony.dtb: regulator-usdhc2-vqmmc (regulator-gpio): Unevaluated properties are not allowed ('gpio' was unexpected)
from schema $id: http://devicetree.org/schemas/regulator/gpio-regulator.yaml#
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-02 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-02 10:28 [PATCH] arm64: dts: imx8mp-var-som: Fix LDO5 shutdown causing SD card timeout kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-05-01 5:46 Himanshu Bhavani
2025-05-01 8:42 ` Tarang Raval
2025-05-01 12:08 ` Rob Herring (Arm)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.