* [PATCH] power: supply: add EXTCON dependency
@ 2025-05-03 14:04 Arnd Bergmann
2025-05-03 17:18 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-05-03 14:04 UTC (permalink / raw)
To: Sebastian Reichel, Svyatoslav Ryhel
Cc: Arnd Bergmann, Dr. David Alan Gilbert, Thomas Weißschuh,
Dmitry Baryshkov, Dimitri Fedrau, Andreas Kemnade, Pengyu Luo,
linux-pm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
max8971 is written to work with or without extcon, but it fails
to link when built-in when the extcon subsystem is in a loadable
module:
x86_64-linux-ld: drivers/power/supply/max8971_charger.o: in function `max8971_probe':
max8971_charger.c:(.text+0x2ab): undefined reference to `extcon_find_edev_by_node'
Add the appropriate dependency that allows the working cases but
prevents the link failure.
Fixes: 60cd40eee4f4 ("power: supply: Add support for Maxim MAX8971 charger")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index 797c8d1b04aa..daab8214e225 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -621,6 +621,7 @@ config CHARGER_MAX77976
config CHARGER_MAX8971
tristate "Maxim MAX8971 battery charger driver"
depends on I2C
+ depends on EXTCON || !EXTCON
select REGMAP_I2C
help
The MAX8971 is a compact, high-frequency, high-efficiency switch-mode
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: add EXTCON dependency
2025-05-03 14:04 [PATCH] power: supply: add EXTCON dependency Arnd Bergmann
@ 2025-05-03 17:18 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2025-05-03 17:18 UTC (permalink / raw)
To: Sebastian Reichel, Svyatoslav Ryhel, Arnd Bergmann
Cc: Arnd Bergmann, Dr. David Alan Gilbert, Thomas Weißschuh,
Dmitry Baryshkov, Dimitri Fedrau, Andreas Kemnade, Pengyu Luo,
linux-pm, linux-kernel
On Sat, 03 May 2025 16:04:26 +0200, Arnd Bergmann wrote:
> max8971 is written to work with or without extcon, but it fails
> to link when built-in when the extcon subsystem is in a loadable
> module:
>
> x86_64-linux-ld: drivers/power/supply/max8971_charger.o: in function `max8971_probe':
> max8971_charger.c:(.text+0x2ab): undefined reference to `extcon_find_edev_by_node'
>
> [...]
Applied, thanks!
[1/1] power: supply: add EXTCON dependency
commit: 1ea48c51f03fc3186ee0bcc05d06b652c209e0ae
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-03 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-03 14:04 [PATCH] power: supply: add EXTCON dependency Arnd Bergmann
2025-05-03 17:18 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.