[PATCH platform-next 1/1] platform/mellanox: mlxreg-dpu: Fix smatch warnings

[PATCH platform-next 1/1] platform/mellanox: mlxreg-dpu: Fix smatch warnings

[Vadim Pasternak]

Add missed call to release adapter.
Remove wrong error pointer conversion.

Fixes: 3e75f2954116 ("platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
 drivers/platform/mellanox/mlxreg-dpu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/mellanox/mlxreg-dpu.c b/drivers/platform/mellanox/mlxreg-dpu.c
index 277e4b8cc5cb..805b9bfbc85f 100644
--- a/drivers/platform/mellanox/mlxreg-dpu.c
+++ b/drivers/platform/mellanox/mlxreg-dpu.c
@@ -535,8 +535,10 @@ static int mlxreg_dpu_probe(struct platform_device *pdev)
 		return -EPROBE_DEFER;
 
 	mlxreg_dpu = devm_kzalloc(&pdev->dev, sizeof(*mlxreg_dpu), GFP_KERNEL);
-	if (!mlxreg_dpu)
+	if (!mlxreg_dpu) {
+		i2c_put_adapter(data->hpdev.adapter);
 		return -ENOMEM;
+	}
 
 	/* Create device at the top of DPU I2C tree. */
 	data->hpdev.client = i2c_new_client_device(data->hpdev.adapter,
@@ -562,7 +564,6 @@ static int mlxreg_dpu_probe(struct platform_device *pdev)
 	if (err) {
 		dev_err(&pdev->dev, "Failed to sync regmap for client %s at bus %d at addr 0x%02x\n",
 			data->hpdev.brdinfo->type, data->hpdev.nr, data->hpdev.brdinfo->addr);
-		err = PTR_ERR(regmap);
 		goto regcache_sync_fail;
 	}
 
-- 
2.44.0

Re: [PATCH platform-next 1/1] platform/mellanox: mlxreg-dpu: Fix smatch warnings

[Ilpo Järvinen]

On Sun, 4 May 2025, Vadim Pasternak wrote:

> Add missed call to release adapter.
> Remove wrong error pointer conversion.
> 
> Fixes: 3e75f2954116 ("platform/mellanox: mlxreg-dpu: Add initial support for Nvidia DPU")
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
> ---
>  drivers/platform/mellanox/mlxreg-dpu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-dpu.c b/drivers/platform/mellanox/mlxreg-dpu.c
> index 277e4b8cc5cb..805b9bfbc85f 100644
> --- a/drivers/platform/mellanox/mlxreg-dpu.c
> +++ b/drivers/platform/mellanox/mlxreg-dpu.c
> @@ -535,8 +535,10 @@ static int mlxreg_dpu_probe(struct platform_device *pdev)
>  		return -EPROBE_DEFER;
>  
>  	mlxreg_dpu = devm_kzalloc(&pdev->dev, sizeof(*mlxreg_dpu), GFP_KERNEL);
> -	if (!mlxreg_dpu)
> +	if (!mlxreg_dpu) {
> +		i2c_put_adapter(data->hpdev.adapter);
>  		return -ENOMEM;
> +	}

Why this doesn't reuse the existing rollbacks??

>  
>  	/* Create device at the top of DPU I2C tree. */
>  	data->hpdev.client = i2c_new_client_device(data->hpdev.adapter,
> @@ -562,7 +564,6 @@ static int mlxreg_dpu_probe(struct platform_device *pdev)
>  	if (err) {
>  		dev_err(&pdev->dev, "Failed to sync regmap for client %s at bus %d at addr 0x%02x\n",
>  			data->hpdev.brdinfo->type, data->hpdev.nr, data->hpdev.brdinfo->addr);
> -		err = PTR_ERR(regmap);
>  		goto regcache_sync_fail;
>  	}
>  
> 

-- 
 i.