From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthew Brost <matthew.brost@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH 03/10] drm/xe: Add xe_ggtt_alloc
Date: Mon, 5 May 2025 14:19:16 +0200 [thread overview]
Message-ID: <20250505121924.921544-4-dev@lankhorst.se> (raw)
In-Reply-To: <20250505121924.921544-1-dev@lankhorst.se>
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Instead of allocating inside xe_tile, create a new function that returns
an allocated struct xe_ggtt from xe_ggtt.c
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/xe/xe_ggtt.c | 16 ++++++++++++++++
drivers/gpu/drm/xe/xe_ggtt.h | 2 ++
drivers/gpu/drm/xe/xe_tile.c | 6 +-----
3 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index 9356d55cc7eab..bdda9302ae294 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -160,6 +160,22 @@ static void xe_ggtt_clear(struct xe_ggtt *ggtt, u64 start, u64 size)
}
}
+/**
+ * xe_ggtt_alloc - Allocate a GGTT for a given &xe_tile
+ * @tile: &xe_tile
+ *
+ * Allocates a &xe_ggtt for a given tile.
+ *
+ * Return: &xe_ggtt on success, or NULL when out of memory.
+ */
+struct xe_ggtt *xe_ggtt_alloc(struct xe_tile *tile)
+{
+ struct xe_ggtt *ggtt = drmm_kzalloc(&tile_to_xe(tile)->drm, sizeof(*ggtt), GFP_KERNEL);
+ if (ggtt)
+ ggtt->tile = tile;
+ return ggtt;
+}
+
static void ggtt_fini_early(struct drm_device *drm, void *arg)
{
struct xe_ggtt *ggtt = arg;
diff --git a/drivers/gpu/drm/xe/xe_ggtt.h b/drivers/gpu/drm/xe/xe_ggtt.h
index 62c8ce636939a..0bab1fd7cc817 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.h
+++ b/drivers/gpu/drm/xe/xe_ggtt.h
@@ -9,7 +9,9 @@
#include "xe_ggtt_types.h"
struct drm_printer;
+struct xe_tile;
+struct xe_ggtt *xe_ggtt_alloc(struct xe_tile *tile);
int xe_ggtt_init_early(struct xe_ggtt *ggtt);
int xe_ggtt_init(struct xe_ggtt *ggtt);
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 0771acbbf3676..672faa0b67f16 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -87,13 +87,9 @@
*/
static int xe_tile_alloc(struct xe_tile *tile)
{
- struct drm_device *drm = &tile_to_xe(tile)->drm;
-
- tile->mem.ggtt = drmm_kzalloc(drm, sizeof(*tile->mem.ggtt),
- GFP_KERNEL);
+ tile->mem.ggtt = xe_ggtt_alloc(tile);
if (!tile->mem.ggtt)
return -ENOMEM;
- tile->mem.ggtt->tile = tile;
return 0;
}
--
2.45.2
next prev parent reply other threads:[~2025-05-05 12:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 12:19 [PATCH 00/10] drm/xe/ggtt: Stop relying on GGTT internals Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 01/10] drm/xe: Use xe_ggtt_map_bo_unlocked for resume Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 02/10] drm/xe: Add xe_ggtt_might_lock Maarten Lankhorst
2025-05-05 12:19 ` Maarten Lankhorst [this message]
2025-05-05 12:19 ` [PATCH 04/10] drm/xe/display: Remove dereferences of ggtt for tile id Maarten Lankhorst
2025-05-12 22:51 ` Matthew Brost
2025-05-05 12:19 ` [PATCH 05/10] drm/xe/ggtt: Seperate flags and address in PTE encoding Maarten Lankhorst
2025-06-05 15:10 ` Matthew Brost
2025-06-05 16:57 ` Maarten Lankhorst
2025-06-05 18:30 ` Matthew Brost
2025-05-05 12:19 ` [PATCH 06/10] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2025-05-20 13:06 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 07/10] drm/xe/display: Convert GGTT mapping to use pte_encode_flags Maarten Lankhorst
2025-05-20 13:20 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 08/10] drm/xe: Remove pte_encode_bo callback Maarten Lankhorst
2025-05-20 13:23 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 09/10] drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset Maarten Lankhorst
2025-05-20 13:28 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 10/10] drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests Maarten Lankhorst
2025-06-05 15:12 ` Matthew Brost
2025-05-06 21:48 ` ✓ CI.Patch_applied: success for drm/xe/ggtt: Stop relying on GGTT internals. (rev2) Patchwork
2025-05-06 21:48 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-06 21:49 ` ✓ CI.KUnit: success " Patchwork
2025-05-06 21:58 ` ✓ CI.Build: " Patchwork
2025-05-06 22:00 ` ✓ CI.Hooks: " Patchwork
2025-05-06 22:01 ` ✓ CI.checksparse: " Patchwork
2025-05-06 22:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-07 1:52 ` ✗ Xe.CI.Full: failure " Patchwork
2025-05-26 16:29 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-26 16:29 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-26 16:30 ` ✓ CI.KUnit: success " Patchwork
2025-05-26 16:41 ` ✓ CI.Build: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505121924.921544-4-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.