From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-xe@lists.freedesktop.org
Cc: Maarten Lankhorst <dev@lankhorst.se>
Subject: [PATCH 07/10] drm/xe/display: Convert GGTT mapping to use pte_encode_flags
Date: Mon, 5 May 2025 14:19:20 +0200 [thread overview]
Message-ID: <20250505121924.921544-8-dev@lankhorst.se> (raw)
In-Reply-To: <20250505121924.921544-1-dev@lankhorst.se>
Another small step in removing pte_encode_bo callback.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/gpu/drm/xe/display/xe_fb_pin.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
index 5392e46a3a134..9059b56bc23c8 100644
--- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
+++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
@@ -171,15 +171,15 @@ write_ggtt_rotated(struct xe_bo *bo, struct xe_ggtt *ggtt, u32 *ggtt_ofs, u32 bo
{
struct xe_device *xe = xe_bo_device(bo);
u32 column, row;
+ u64 pte = ggtt->pt_ops->pte_encode_flags(bo, xe->pat.idx[XE_CACHE_NONE]);
for (column = 0; column < width; column++) {
u32 src_idx = src_stride * (height - 1) + column + bo_ofs;
for (row = 0; row < height; row++) {
- u64 pte = ggtt->pt_ops->pte_encode_bo(bo, src_idx * XE_PAGE_SIZE,
- xe->pat.idx[XE_CACHE_NONE]);
+ u64 addr = xe_bo_addr(bo, src_idx * XE_PAGE_SIZE, XE_PAGE_SIZE);
- ggtt->pt_ops->ggtt_set_pte(ggtt, *ggtt_ofs, pte);
+ ggtt->pt_ops->ggtt_set_pte(ggtt, *ggtt_ofs, pte | addr);
*ggtt_ofs += XE_PAGE_SIZE;
src_idx -= src_stride;
}
@@ -217,26 +217,19 @@ static int __xe_pin_fb_vma_ggtt(const struct intel_framebuffer *fb,
if (bo->ggtt_node[tile0->id] && view->type == I915_GTT_VIEW_NORMAL) {
vma->node = bo->ggtt_node[tile0->id];
} else if (view->type == I915_GTT_VIEW_NORMAL) {
- u32 x, size = bo->ttm.base.size;
-
vma->node = xe_ggtt_node_init(ggtt);
if (IS_ERR(vma->node)) {
ret = PTR_ERR(vma->node);
goto out_unlock;
}
- ret = xe_ggtt_node_insert_locked(vma->node, size, align, 0);
+ ret = xe_ggtt_node_insert_locked(vma->node, bo->size, align, 0);
if (ret) {
xe_ggtt_node_fini(vma->node);
goto out_unlock;
}
- for (x = 0; x < size; x += XE_PAGE_SIZE) {
- u64 pte = ggtt->pt_ops->pte_encode_bo(bo, x,
- xe->pat.idx[XE_CACHE_NONE]);
-
- ggtt->pt_ops->ggtt_set_pte(ggtt, vma->node->base.start + x, pte);
- }
+ xe_ggtt_map_bo(ggtt, vma->node, bo, xe->pat.idx[XE_CACHE_NONE]);
} else {
u32 i, ggtt_ofs;
const struct intel_rotation_info *rot_info = &view->rotated;
--
2.45.2
next prev parent reply other threads:[~2025-05-05 12:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 12:19 [PATCH 00/10] drm/xe/ggtt: Stop relying on GGTT internals Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 01/10] drm/xe: Use xe_ggtt_map_bo_unlocked for resume Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 02/10] drm/xe: Add xe_ggtt_might_lock Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 03/10] drm/xe: Add xe_ggtt_alloc Maarten Lankhorst
2025-05-05 12:19 ` [PATCH 04/10] drm/xe/display: Remove dereferences of ggtt for tile id Maarten Lankhorst
2025-05-12 22:51 ` Matthew Brost
2025-05-05 12:19 ` [PATCH 05/10] drm/xe/ggtt: Seperate flags and address in PTE encoding Maarten Lankhorst
2025-06-05 15:10 ` Matthew Brost
2025-06-05 16:57 ` Maarten Lankhorst
2025-06-05 18:30 ` Matthew Brost
2025-05-05 12:19 ` [PATCH 06/10] drm/xe/display: Dont poke into GGTT internals to fill a DPT Maarten Lankhorst
2025-05-20 13:06 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` Maarten Lankhorst [this message]
2025-05-20 13:20 ` [PATCH 07/10] drm/xe/display: Convert GGTT mapping to use pte_encode_flags Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 08/10] drm/xe: Remove pte_encode_bo callback Maarten Lankhorst
2025-05-20 13:23 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 09/10] drm/xe: Implement a helper for reading out a GGTT PTE at a specified offset Maarten Lankhorst
2025-05-20 13:28 ` Juha-Pekka Heikkilä
2025-05-05 12:19 ` [PATCH 10/10] drm/xe: Do not rely on GGTT internals in xe_guc_buf kunit tests Maarten Lankhorst
2025-06-05 15:12 ` Matthew Brost
2025-05-06 21:48 ` ✓ CI.Patch_applied: success for drm/xe/ggtt: Stop relying on GGTT internals. (rev2) Patchwork
2025-05-06 21:48 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-06 21:49 ` ✓ CI.KUnit: success " Patchwork
2025-05-06 21:58 ` ✓ CI.Build: " Patchwork
2025-05-06 22:00 ` ✓ CI.Hooks: " Patchwork
2025-05-06 22:01 ` ✓ CI.checksparse: " Patchwork
2025-05-06 22:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-07 1:52 ` ✗ Xe.CI.Full: failure " Patchwork
2025-05-26 16:29 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-26 16:29 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-26 16:30 ` ✓ CI.KUnit: success " Patchwork
2025-05-26 16:41 ` ✓ CI.Build: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250505121924.921544-8-dev@lankhorst.se \
--to=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.