All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: fix devcoredump chunk alignmnent calculation
@ 2025-04-29  7:34 Arnd Bergmann
  2025-04-29  8:13 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (11 more replies)
  0 siblings, 12 replies; 14+ messages in thread
From: Arnd Bergmann @ 2025-04-29  7:34 UTC (permalink / raw)
  To: Lucas De Marchi, Thomas Hellström, Rodrigo Vivi,
	David Airlie, Simona Vetter, Matthew Brost, Jonathan Cavitt
  Cc: Arnd Bergmann, John Harrison, José Roberto de Souza,
	Zhanjun Dong, intel-xe, dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The device core dumps are copied in 1.5GB chunks, which leads to a
link-time error on 32-bit builds because of the 64-bit division not
getting trivially turned into mask and shift operations:

ERROR: modpost: "__moddi3" [drivers/gpu/drm/xe/xe.ko] undefined!

On top of this, I noticed that the ALIGN_DOWN() usage here cannot
work because that is only defined for power-of-two alignments.
Change ALIGN_DOWN into an explicit div_u64_rem() that avoids the
link error and hopefully produces the right results.

Doing a 1.5GB kvmalloc() does seem a bit suspicious as well, e.g.
this will clearly fail on any 32-bit platform and is also likely
to run out of memory on 64-bit systems under memory pressure, so
using a much smaller power-of-two chunk size might be a good idea
instead.

Fixes: c4a2e5f865b7 ("drm/xe: Add devcoredump chunking")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
Please test this with multi-gigabyte buffers, the original code
was clearly not right, but I don't trust my version either.
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index a9e618abf8ac..4eb70e2d9f68 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -177,6 +177,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
 	struct xe_devcoredump *coredump = data;
 	struct xe_devcoredump_snapshot *ss;
 	ssize_t byte_copied;
+	u32 chunk_offset;
 
 	if (!coredump)
 		return -ENODEV;
@@ -203,8 +204,9 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
 
 	if (offset >= ss->read.chunk_position + XE_DEVCOREDUMP_CHUNK_MAX ||
 	    offset < ss->read.chunk_position) {
-		ss->read.chunk_position =
-			ALIGN_DOWN(offset, XE_DEVCOREDUMP_CHUNK_MAX);
+		ss->read.chunk_position = div_u64_rem(offset,
+			XE_DEVCOREDUMP_CHUNK_MAX, &chunk_offset)
+			* XE_DEVCOREDUMP_CHUNK_MAX;
 
 		__xe_devcoredump_read(ss->read.buffer,
 				      XE_DEVCOREDUMP_CHUNK_MAX,
@@ -213,8 +215,7 @@ static ssize_t xe_devcoredump_read(char *buffer, loff_t offset,
 
 	byte_copied = count < ss->read.size - offset ? count :
 		ss->read.size - offset;
-	memcpy(buffer, ss->read.buffer +
-	       (offset % XE_DEVCOREDUMP_CHUNK_MAX), byte_copied);
+	memcpy(buffer, ss->read.buffer + chunk_offset, byte_copied);
 
 	mutex_unlock(&coredump->lock);
 
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread
end of thread, other threads:[~2025-05-07 18:10 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29  7:34 [PATCH] drm/xe: fix devcoredump chunk alignmnent calculation Arnd Bergmann
2025-04-29  8:13 ` ✓ CI.Patch_applied: success for " Patchwork
2025-04-29  8:13 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-29  8:14 ` ✓ CI.KUnit: success " Patchwork
2025-04-29  8:31 ` ✓ CI.Build: " Patchwork
2025-04-29  8:34 ` ✓ CI.Hooks: " Patchwork
2025-04-29  8:38 ` ✓ CI.checksparse: " Patchwork
2025-04-29 10:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-29 17:51 ` [PATCH] " Matthew Brost
2025-04-29 17:55   ` Matthew Brost
2025-05-06  7:14 ` ✗ Xe.CI.BAT: failure for " Patchwork
2025-05-06  7:49 ` Patchwork
2025-05-07  7:07 ` [PATCH] " kernel test robot
2025-05-07 18:10 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.