From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [linux-next:master 7893/8235] fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235)
Date: Wed, 7 May 2025 18:25:13 +0800 [thread overview]
Message-ID: <202505071850.XaOkcCkX-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Shivank Garg <shivankg@amd.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 08710e696081d58163c8078e0e096be6d35c5fad
commit: 39ed4d1a0e03ce3ac2145ee7ef0714c78bae9c61 [7893/8235] jfs: implement migrate_folio for jfs_metapage_aops
:::::: branch date: 3 hours ago
:::::: commit date: 6 days ago
config: i386-randconfig-141-20250502 (https://download.01.org/0day-ci/archive/20250507/202505071850.XaOkcCkX-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202505071850.XaOkcCkX-lkp@intel.com/
smatch warnings:
fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235)
vim +/mp +245 fs/jfs/jfs_metapage.c
7fab479bebb96b Dave Kleikamp 2005-05-02 226
39ed4d1a0e03ce Shivank Garg 2025-04-30 227 static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
39ed4d1a0e03ce Shivank Garg 2025-04-30 228 struct folio *src, enum migrate_mode mode)
39ed4d1a0e03ce Shivank Garg 2025-04-30 229 {
39ed4d1a0e03ce Shivank Garg 2025-04-30 230 struct metapage *mp;
39ed4d1a0e03ce Shivank Garg 2025-04-30 231 int page_offset;
39ed4d1a0e03ce Shivank Garg 2025-04-30 232 int rc;
39ed4d1a0e03ce Shivank Garg 2025-04-30 233
39ed4d1a0e03ce Shivank Garg 2025-04-30 234 mp = folio_to_mp(src, 0);
39ed4d1a0e03ce Shivank Garg 2025-04-30 @235 if (mp && metapage_locked(mp))
39ed4d1a0e03ce Shivank Garg 2025-04-30 236 return -EAGAIN;
39ed4d1a0e03ce Shivank Garg 2025-04-30 237
39ed4d1a0e03ce Shivank Garg 2025-04-30 238 rc = filemap_migrate_folio(mapping, dst, src, mode);
39ed4d1a0e03ce Shivank Garg 2025-04-30 239 if (rc != MIGRATEPAGE_SUCCESS)
39ed4d1a0e03ce Shivank Garg 2025-04-30 240 return rc;
39ed4d1a0e03ce Shivank Garg 2025-04-30 241
39ed4d1a0e03ce Shivank Garg 2025-04-30 242 if (unlikely(insert_metapage(dst, mp)))
39ed4d1a0e03ce Shivank Garg 2025-04-30 243 return -EAGAIN;
39ed4d1a0e03ce Shivank Garg 2025-04-30 244
39ed4d1a0e03ce Shivank Garg 2025-04-30 @245 page_offset = mp->data - folio_address(src);
39ed4d1a0e03ce Shivank Garg 2025-04-30 246 mp->data = folio_address(dst) + page_offset;
39ed4d1a0e03ce Shivank Garg 2025-04-30 247 mp->folio = dst;
39ed4d1a0e03ce Shivank Garg 2025-04-30 248 remove_metapage(src, mp);
39ed4d1a0e03ce Shivank Garg 2025-04-30 249
39ed4d1a0e03ce Shivank Garg 2025-04-30 250 return MIGRATEPAGE_SUCCESS;
39ed4d1a0e03ce Shivank Garg 2025-04-30 251 }
39ed4d1a0e03ce Shivank Garg 2025-04-30 252
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Shivank Garg <shivankg@amd.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [linux-next:master 7893/8235] fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235)
Date: Wed, 7 May 2025 14:11:37 +0300 [thread overview]
Message-ID: <202505071850.XaOkcCkX-lkp@intel.com> (raw)
Message-ID: <20250507111137.4rXZ4Xcr3P278T0ToJqsK623AHfzfoufXFvhyD-OR0Y@z> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 08710e696081d58163c8078e0e096be6d35c5fad
commit: 39ed4d1a0e03ce3ac2145ee7ef0714c78bae9c61 [7893/8235] jfs: implement migrate_folio for jfs_metapage_aops
config: i386-randconfig-141-20250502 (https://download.01.org/0day-ci/archive/20250507/202505071850.XaOkcCkX-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202505071850.XaOkcCkX-lkp@intel.com/
smatch warnings:
fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235)
vim +/mp +245 fs/jfs/jfs_metapage.c
39ed4d1a0e03ce Shivank Garg 2025-04-30 227 static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst,
39ed4d1a0e03ce Shivank Garg 2025-04-30 228 struct folio *src, enum migrate_mode mode)
39ed4d1a0e03ce Shivank Garg 2025-04-30 229 {
39ed4d1a0e03ce Shivank Garg 2025-04-30 230 struct metapage *mp;
39ed4d1a0e03ce Shivank Garg 2025-04-30 231 int page_offset;
39ed4d1a0e03ce Shivank Garg 2025-04-30 232 int rc;
39ed4d1a0e03ce Shivank Garg 2025-04-30 233
39ed4d1a0e03ce Shivank Garg 2025-04-30 234 mp = folio_to_mp(src, 0);
39ed4d1a0e03ce Shivank Garg 2025-04-30 @235 if (mp && metapage_locked(mp))
^^
If mp is NULL
39ed4d1a0e03ce Shivank Garg 2025-04-30 236 return -EAGAIN;
39ed4d1a0e03ce Shivank Garg 2025-04-30 237
39ed4d1a0e03ce Shivank Garg 2025-04-30 238 rc = filemap_migrate_folio(mapping, dst, src, mode);
39ed4d1a0e03ce Shivank Garg 2025-04-30 239 if (rc != MIGRATEPAGE_SUCCESS)
39ed4d1a0e03ce Shivank Garg 2025-04-30 240 return rc;
39ed4d1a0e03ce Shivank Garg 2025-04-30 241
39ed4d1a0e03ce Shivank Garg 2025-04-30 242 if (unlikely(insert_metapage(dst, mp)))
39ed4d1a0e03ce Shivank Garg 2025-04-30 243 return -EAGAIN;
39ed4d1a0e03ce Shivank Garg 2025-04-30 244
39ed4d1a0e03ce Shivank Garg 2025-04-30 @245 page_offset = mp->data - folio_address(src);
^^
Then this will crash.
39ed4d1a0e03ce Shivank Garg 2025-04-30 246 mp->data = folio_address(dst) + page_offset;
39ed4d1a0e03ce Shivank Garg 2025-04-30 247 mp->folio = dst;
39ed4d1a0e03ce Shivank Garg 2025-04-30 248 remove_metapage(src, mp);
39ed4d1a0e03ce Shivank Garg 2025-04-30 249
39ed4d1a0e03ce Shivank Garg 2025-04-30 250 return MIGRATEPAGE_SUCCESS;
39ed4d1a0e03ce Shivank Garg 2025-04-30 251 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-05-07 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 10:25 kernel test robot [this message]
2025-05-07 11:11 ` [linux-next:master 7893/8235] fs/jfs/jfs_metapage.c:245 __metapage_migrate_folio() error: we previously assumed 'mp' could be null (see line 235) Dan Carpenter
2025-05-07 11:49 ` Shivank Garg
2025-05-08 0:34 ` Andrew Morton
2025-05-08 5:38 ` Dan Carpenter
2025-05-08 6:48 ` Shivank Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505071850.XaOkcCkX-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.