[PATCH] dmaengine: idxd: Fix ->poll() return value

[PATCH] dmaengine: idxd: Fix ->poll() return value

[Dave Jiang]

The fix to block access from different address space did not return a
correct value for ->poll() change.  kernel test bot reported that a
return value of type __poll_t is expected rather than int. Fix to return
POLLNVAL to indicate invalid request.

Fixes: 8dfa57aabff6 ("dmaengine: idxd: Fix allowing write() from different address spaces")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505081851.rwD7jVxg-lkp@intel.com/
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---

Hi Vinod, this fixes a patch that's queued in dmaengine/fixes.

 drivers/dma/idxd/cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
index a2fb2b847752..6d12033649f8 100644
--- a/drivers/dma/idxd/cdev.c
+++ b/drivers/dma/idxd/cdev.c
@@ -500,7 +500,7 @@ static __poll_t idxd_cdev_poll(struct file *filp,
 	__poll_t out = 0;
 
 	if (current->mm != ctx->mm)
-		return -EPERM;
+		return POLLNVAL;
 
 	poll_wait(filp, &wq->err_queue, wait);
 	spin_lock(&idxd->dev_lock);

base-commit: 305245a2e1d633e5f821178c98c6d6132cea2bdb
-- 
2.49.0

Re: [PATCH] dmaengine: idxd: Fix ->poll() return value

[Vinod Koul]

On Thu, 08 May 2025 10:05:48 -0700, Dave Jiang wrote:
> The fix to block access from different address space did not return a
> correct value for ->poll() change.  kernel test bot reported that a
> return value of type __poll_t is expected rather than int. Fix to return
> POLLNVAL to indicate invalid request.
> 
> 

Applied, thanks!

[1/1] dmaengine: idxd: Fix ->poll() return value
      commit: ae74cd15ade833adc289279b5c6f12e78f64d4d7

Best regards,
-- 
~Vinod