* [PATCH] ksmbd: remove unnecessary softdep on crc32
@ 2025-05-14 4:54 Eric Biggers
2025-05-14 8:45 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2025-05-14 4:54 UTC (permalink / raw)
To: Namjae Jeon, Steve French, Sergey Senozhatsky, Tom Talpey,
linux-cifs
From: Eric Biggers <ebiggers@google.com>
ksmbd accesses crc32 using normal function calls (as opposed to e.g.
the generic crypto infrastructure's name-based algorithm resolution), so
there is no need to declare a module softdep.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/smb/server/server.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/smb/server/server.c b/fs/smb/server/server.c
index ab533c6029879..8c9c49c3a0a47 100644
--- a/fs/smb/server/server.c
+++ b/fs/smb/server/server.c
@@ -629,8 +629,7 @@ MODULE_SOFTDEP("pre: cmac");
MODULE_SOFTDEP("pre: sha256");
MODULE_SOFTDEP("pre: sha512");
MODULE_SOFTDEP("pre: aead2");
MODULE_SOFTDEP("pre: ccm");
MODULE_SOFTDEP("pre: gcm");
-MODULE_SOFTDEP("pre: crc32");
module_init(ksmbd_server_init)
module_exit(ksmbd_server_exit)
base-commit: aa94665adc28f3fdc3de2979ac1e98bae961d6ca
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ksmbd: remove unnecessary softdep on crc32
2025-05-14 4:54 [PATCH] ksmbd: remove unnecessary softdep on crc32 Eric Biggers
@ 2025-05-14 8:45 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2025-05-14 8:45 UTC (permalink / raw)
To: Eric Biggers; +Cc: Steve French, Sergey Senozhatsky, Tom Talpey, linux-cifs
On Wed, May 14, 2025 at 1:54 PM Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> ksmbd accesses crc32 using normal function calls (as opposed to e.g.
> the generic crypto infrastructure's name-based algorithm resolution), so
> there is no need to declare a module softdep.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied it to #ksmbd-for-next-next.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-14 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 4:54 [PATCH] ksmbd: remove unnecessary softdep on crc32 Eric Biggers
2025-05-14 8:45 ` Namjae Jeon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.