From: Jakub Kicinski <kuba@kernel.org>
To: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers
Date: Wed, 14 May 2025 07:42:03 -0700 [thread overview]
Message-ID: <20250514074203.31b07788@kernel.org> (raw)
In-Reply-To: <3b333c97-4bdd-4238-bfab-b0f137e5b869@linux.intel.com>
On Wed, 14 May 2025 15:44:49 +0200 Szapar-Mudlaw, Martyna wrote:
> The link-down events counter increments upon actual physical link-down
> events, doesn't increment when user performs a simple down/up of the
> interface.
>
> However there is indeed link down event from firmware - as
> part of interface reinitialization eg. when attaching XDP program,
> reconfiguring channels and setting interface priv-flags.
Maybe I'm misunderstanding, but are you saying that the link-down
counter doesn't increment on ifdown+ifup but it does increment
when attaching an XDP prog?
The definition of link_down_events is pretty simple - (plus minus
the quantum world of signals) the link_down_events is physical link
downs which the switch / remote end will also see. Unlike software
carrier off which may just configure the MAC or the NIC pipeline to
drop but the PHY stays connected / trained / synchronized.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@linux.intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers
Date: Wed, 14 May 2025 07:42:03 -0700 [thread overview]
Message-ID: <20250514074203.31b07788@kernel.org> (raw)
In-Reply-To: <3b333c97-4bdd-4238-bfab-b0f137e5b869@linux.intel.com>
On Wed, 14 May 2025 15:44:49 +0200 Szapar-Mudlaw, Martyna wrote:
> The link-down events counter increments upon actual physical link-down
> events, doesn't increment when user performs a simple down/up of the
> interface.
>
> However there is indeed link down event from firmware - as
> part of interface reinitialization eg. when attaching XDP program,
> reconfiguring channels and setting interface priv-flags.
Maybe I'm misunderstanding, but are you saying that the link-down
counter doesn't increment on ifdown+ifup but it does increment
when attaching an XDP prog?
The definition of link_down_events is pretty simple - (plus minus
the quantum world of signals) the link_down_events is physical link
downs which the switch / remote end will also see. Unlike software
carrier off which may just configure the MAC or the NIC pipeline to
drop but the PHY stays connected / trained / synchronized.
next prev parent reply other threads:[~2025-05-14 14:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 9:05 [Intel-wired-lan] [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers Martyna Szapar-Mudlaw
2025-05-12 9:05 ` Martyna Szapar-Mudlaw
2025-05-12 9:05 ` [Intel-wired-lan] [PATCH iwl-next v3 1/2] ice: add link_down_events statistic Martyna Szapar-Mudlaw
2025-05-12 9:05 ` Martyna Szapar-Mudlaw
2025-05-12 9:05 ` [Intel-wired-lan] [PATCH iwl-next v3 2/2] ixgbe: " Martyna Szapar-Mudlaw
2025-05-12 9:05 ` Martyna Szapar-Mudlaw
2025-05-13 0:21 ` [Intel-wired-lan] [PATCH iwl-next v3 0/2] Add link_down_events counters to ixgbe and ice drivers Jakub Kicinski
2025-05-13 0:21 ` Jakub Kicinski
2025-05-14 13:44 ` [Intel-wired-lan] " Szapar-Mudlaw, Martyna
2025-05-14 13:44 ` Szapar-Mudlaw, Martyna
2025-05-14 14:42 ` Jakub Kicinski [this message]
2025-05-14 14:42 ` Jakub Kicinski
2025-05-14 14:59 ` [Intel-wired-lan] " Szapar-Mudlaw, Martyna
2025-05-14 14:59 ` Szapar-Mudlaw, Martyna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514074203.31b07788@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=martyna.szapar-mudlaw@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.