From: Simon Horman <horms@kernel.org>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, maciej.fijalkowski@intel.com,
aleksander.lobakin@intel.com, przemyslaw.kitszel@intel.com,
dawid.osuchowski@linux.intel.com, jacob.e.keller@intel.com,
jbrandeburg@cloudflare.com, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 2/3] ice: create new Tx scheduler nodes for new queues only
Date: Thu, 15 May 2025 12:46:32 +0100 [thread overview]
Message-ID: <20250515114632.GV3339421@horms.kernel.org> (raw)
In-Reply-To: <20250513105529.241745-3-michal.kubiak@intel.com>
On Tue, May 13, 2025 at 12:55:28PM +0200, Michal Kubiak wrote:
> The current implementation of the Tx scheduler tree attempts
> to create nodes for all Tx queues, ignoring the fact that some
> queues may already exist in the tree. For example, if the VSI
> already has 128 Tx queues and the user requests for 16 new queues,
> the Tx scheduler will compute the tree for 272 queues (128 existing
> queues + 144 new queues), instead of 144 queues (128 existing queues
> and 16 new queues).
> Fix that by modifying the node count calculation algorithm to skip
> the queues that already exist in the tree.
>
> Fixes: 5513b920a4f7 ("ice: Update Tx scheduler tree for VSI multi-Tx queue support")
> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Michal Kubiak <michal.kubiak@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, maciej.fijalkowski@intel.com,
aleksander.lobakin@intel.com, przemyslaw.kitszel@intel.com,
dawid.osuchowski@linux.intel.com, jacob.e.keller@intel.com,
jbrandeburg@cloudflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH iwl-net v3 2/3] ice: create new Tx scheduler nodes for new queues only
Date: Thu, 15 May 2025 12:46:32 +0100 [thread overview]
Message-ID: <20250515114632.GV3339421@horms.kernel.org> (raw)
In-Reply-To: <20250513105529.241745-3-michal.kubiak@intel.com>
On Tue, May 13, 2025 at 12:55:28PM +0200, Michal Kubiak wrote:
> The current implementation of the Tx scheduler tree attempts
> to create nodes for all Tx queues, ignoring the fact that some
> queues may already exist in the tree. For example, if the VSI
> already has 128 Tx queues and the user requests for 16 new queues,
> the Tx scheduler will compute the tree for 272 queues (128 existing
> queues + 144 new queues), instead of 144 queues (128 existing queues
> and 16 new queues).
> Fix that by modifying the node count calculation algorithm to skip
> the queues that already exist in the tree.
>
> Fixes: 5513b920a4f7 ("ice: Update Tx scheduler tree for VSI multi-Tx queue support")
> Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-15 11:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 10:55 [Intel-wired-lan] [PATCH iwl-net v3 0/3] Fix XDP loading on machines with many CPUs Michal Kubiak
2025-05-13 10:55 ` Michal Kubiak
2025-05-13 10:55 ` [Intel-wired-lan] [PATCH iwl-net v3 1/3] ice: fix Tx scheduler error handling in XDP callback Michal Kubiak
2025-05-13 10:55 ` Michal Kubiak
2025-05-15 11:46 ` [Intel-wired-lan] " Simon Horman
2025-05-15 11:46 ` Simon Horman
[not found] ` <PH0PR11MB5013AB5E0AB451527E3F8E9B969CA@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-05-19 11:04 ` [Intel-wired-lan] " Sanigani, SarithaX
2025-05-13 10:55 ` [Intel-wired-lan] [PATCH iwl-net v3 2/3] ice: create new Tx scheduler nodes for new queues only Michal Kubiak
2025-05-13 10:55 ` Michal Kubiak
2025-05-15 11:46 ` Simon Horman [this message]
2025-05-15 11:46 ` Simon Horman
[not found] ` <PH0PR11MB501368762FA1E6CF8CF6646A969CA@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-05-19 11:04 ` [Intel-wired-lan] " Sanigani, SarithaX
2025-05-13 10:55 ` [Intel-wired-lan] [PATCH iwl-net v3 3/3] ice: fix rebuilding the Tx scheduler tree for large queue counts Michal Kubiak
2025-05-13 10:55 ` Michal Kubiak
2025-05-15 11:46 ` [Intel-wired-lan] " Simon Horman
2025-05-15 11:46 ` Simon Horman
[not found] ` <PH0PR11MB5013BA5E1BAFE284EC81B006969CA@PH0PR11MB5013.namprd11.prod.outlook.com>
2025-05-19 11:04 ` [Intel-wired-lan] " Sanigani, SarithaX
2025-05-15 22:43 ` [Intel-wired-lan] [PATCH iwl-net v3 0/3] Fix XDP loading on machines with many CPUs Jesse Brandeburg
2025-05-15 22:43 ` Jesse Brandeburg
2025-05-16 10:24 ` [Intel-wired-lan] " Michal Kubiak
2025-05-16 10:24 ` Michal Kubiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515114632.GV3339421@horms.kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=dawid.osuchowski@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jbrandeburg@cloudflare.com \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.