[PATCH 1/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable hardware rng

[PATCH 1/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable hardware rng

[Dario Binacchi]

From: Leonhard Hesse <leonhard.hesse@bshg.com>

Hardware random number generator is now used for cryptography.

Signed-off-by: Leonhard Hesse <leonhard.hesse@bshg.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
index 6159ed70d966..5c32d1e3675c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
@@ -29,6 +29,10 @@ &gpmi {
 	status = "okay";
 };
 
+&rngb {
+	status = "okay";
+};
+
 &snvs_poweroff {
 	status = "okay";
 };
-- 
2.43.0

base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
branch: bsh-202505-imx6ulz_smm_m2

[PATCH 2/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable uart2

[Dario Binacchi]

From: Wolfgang Birkner <wolfgang.birkner@bshg.com>

uart2 is used as wake up source.

Signed-off-by: Wolfgang Birkner <wolfgang.birkner@bshg.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
index 5c32d1e3675c..fff21f28c552 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
@@ -37,6 +37,10 @@ &snvs_poweroff {
 	status = "okay";
 };
 
+&uart2 {
+	status = "okay";
+};
+
 &uart3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart3>;
-- 
2.43.0

base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
branch: bsh-202505-imx6ulz_smm_m2

Re: [PATCH 2/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable uart2

[Peng Fan]

On Wed, May 14, 2025 at 09:05:34AM +0200, Dario Binacchi wrote:
>From: Wolfgang Birkner <wolfgang.birkner@bshg.com>
>
>uart2 is used as wake up source.
>
>Signed-off-by: Wolfgang Birkner <wolfgang.birkner@bshg.com>
>Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>---
>
> arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>index 5c32d1e3675c..fff21f28c552 100644
>--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>@@ -37,6 +37,10 @@ &snvs_poweroff {
> 	status = "okay";
> };
> 
>+&uart2 {
>+	status = "okay";
>+};

No need pinctrl settings?

Regards,
Peng

>+
> &uart3 {
> 	pinctrl-names = "default";
> 	pinctrl-0 = <&pinctrl_uart3>;
>-- 
>2.43.0
>
>base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
>branch: bsh-202505-imx6ulz_smm_m2

Re: [PATCH 2/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable uart2

[Michael Nazzareno Trimarchi]

Hi


On Fri, May 16, 2025 at 4:56 AM Peng Fan <peng.fan@oss.nxp.com> wrote:
>
> On Wed, May 14, 2025 at 09:05:34AM +0200, Dario Binacchi wrote:
> >From: Wolfgang Birkner <wolfgang.birkner@bshg.com>
> >
> >uart2 is used as wake up source.
> >
> >Signed-off-by: Wolfgang Birkner <wolfgang.birkner@bshg.com>
> >Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >---
> >
> > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> >index 5c32d1e3675c..fff21f28c552 100644
> >--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> >+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
> >@@ -37,6 +37,10 @@ &snvs_poweroff {
> >       status = "okay";
> > };
> >
> >+&uart2 {
> >+      status = "okay";
> >+};
>
> No need pinctrl settings?
>

We found out that in imx6ulz, if we don't enable wakeup on uart2 (or
other uarts that do not conflict on pinout) we are not able to wake up
from uart4, which is the console.
According to the TRM and the code everything look fine but the real
result it's we stuck in suspend

Here is how we are able to resume.

uart2
echo enabled > wakeup
uart4
echo enabled > wakeup

Michael

> Regards,
> Peng
>
> >+
> > &uart3 {
> >       pinctrl-names = "default";
> >       pinctrl-0 = <&pinctrl_uart3>;
> >--
> >2.43.0
> >
> >base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
> >branch: bsh-202505-imx6ulz_smm_m2
>
>


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com

Re: [PATCH 2/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable uart2

[Peng Fan]

On Fri, May 16, 2025 at 12:11:54PM +0200, Michael Nazzareno Trimarchi wrote:
>Hi
>
>
>On Fri, May 16, 2025 at 4:56???AM Peng Fan <peng.fan@oss.nxp.com> wrote:
>>
>> On Wed, May 14, 2025 at 09:05:34AM +0200, Dario Binacchi wrote:
>> >From: Wolfgang Birkner <wolfgang.birkner@bshg.com>
>> >
>> >uart2 is used as wake up source.
>> >
>> >Signed-off-by: Wolfgang Birkner <wolfgang.birkner@bshg.com>
>> >Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>> >---
>> >
>> > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> >diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>> >index 5c32d1e3675c..fff21f28c552 100644
>> >--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>> >+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>> >@@ -37,6 +37,10 @@ &snvs_poweroff {
>> >       status = "okay";
>> > };
>> >
>> >+&uart2 {
>> >+      status = "okay";
>> >+};
>>
>> No need pinctrl settings?
>>
>
>We found out that in imx6ulz, if we don't enable wakeup on uart2 (or
>other uarts that do not conflict on pinout) we are not able to wake up
>from uart4, which is the console.
>According to the TRM and the code everything look fine but the real
>result it's we stuck in suspend
>
>Here is how we are able to resume.
>
>uart2
>echo enabled > wakeup
>uart4
>echo enabled > wakeup

No idea. 

But at least put some info in commit log to describe why set uart2 as okay.

Thanks,
Peng

>
>Michael
>
>> Regards,
>> Peng
>>
>> >+
>> > &uart3 {
>> >       pinctrl-names = "default";
>> >       pinctrl-0 = <&pinctrl_uart3>;
>> >--
>> >2.43.0
>> >
>> >base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
>> >branch: bsh-202505-imx6ulz_smm_m2
>>
>>
>
>
>-- 
>Michael Nazzareno Trimarchi
>Co-Founder & Chief Executive Officer
>M. +39 347 913 2170
>michael@amarulasolutions.com
>__________________________________
>
>Amarula Solutions BV
>Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
>T. +31 (0)85 111 9172
>info@amarulasolutions.com
>www.amarulasolutions.com

[PATCH 3/3] ARM: dts: imx6ulz-bsh-smm-m2: Update wifi/bluetooth pinctrl

[Dario Binacchi]

From: Leonhard Hesse <leonhard.hesse@bshg.com>

Adjustment of wifi and bluetooth REG_ON pin settings. Align them
to the production kernel

Signed-off-by: Leonhard Hesse <leonhard.hesse@bshg.com>
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

 arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
index fff21f28c552..6e4d09bf002b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
@@ -128,7 +128,7 @@ MX6UL_PAD_UART3_TX_DATA__UART3_DCE_TX	0x1b0b1
 			MX6UL_PAD_UART3_RX_DATA__UART3_DCE_RX	0x1b099
 			MX6UL_PAD_UART3_RTS_B__UART3_DCE_RTS	0x1b0b1
 			MX6UL_PAD_UART3_CTS_B__UART3_DCE_CTS	0x1b099
-			MX6UL_PAD_GPIO1_IO01__GPIO1_IO01	0x79		/* BT_REG_ON */
+			MX6UL_PAD_GPIO1_IO01__GPIO1_IO01	0x100b1		/* BT_REG_ON */
 			MX6UL_PAD_SD1_CLK__GPIO2_IO17		0x100b1		/* BT_DEV_WAKE out */
 			MX6UL_PAD_ENET2_TX_EN__GPIO2_IO13	0x1b0b0		/* BT_HOST_WAKE in */
 		>;
@@ -149,7 +149,7 @@ MX6UL_PAD_CSI_DATA00__USDHC2_DATA0	0x17059
 			MX6UL_PAD_CSI_DATA01__USDHC2_DATA1	0x17059
 			MX6UL_PAD_CSI_DATA02__USDHC2_DATA2	0x17059
 			MX6UL_PAD_CSI_DATA03__USDHC2_DATA3	0x17059
-			MX6UL_PAD_SD1_DATA3__GPIO2_IO21		0x79		/* WL_REG_ON */
+			MX6UL_PAD_SD1_DATA3__GPIO2_IO21		0x3029		/* WL_REG_ON */
 			MX6UL_PAD_UART2_CTS_B__GPIO1_IO22	0x100b1		/* WL_DEV_WAKE - WiFi_GPIO_4 - WiFi FW UART */
 			MX6UL_PAD_UART1_CTS_B__GPIO1_IO18	0x1b0b1		/* WL_HOST_WAKE - WIFI_GPIO_0 - OOB IRQ */
 			MX6UL_PAD_ENET1_RX_EN__OSC32K_32K_OUT	0x4001b031	/* OSC 32Khz wifi clk in */
-- 
2.43.0

base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
branch: bsh-202505-imx6ulz_smm_m2

Re: [PATCH 3/3] ARM: dts: imx6ulz-bsh-smm-m2: Update wifi/bluetooth pinctrl

[Peng Fan]

On Wed, May 14, 2025 at 09:05:35AM +0200, Dario Binacchi wrote:
>From: Leonhard Hesse <leonhard.hesse@bshg.com>
>
>Adjustment of wifi and bluetooth REG_ON pin settings. Align them
>to the production kernel

It could be good to add a bit more info about what specific
pad settings are changed.

Align them to the production kernel does not make sense.

Regards,
Peng

Re: [PATCH 1/3] ARM: dts: imx6ulz-bsh-smm-m2: Enable hardware rng

[Peng Fan]

On Wed, May 14, 2025 at 09:05:33AM +0200, Dario Binacchi wrote:
>From: Leonhard Hesse <leonhard.hesse@bshg.com>
>
>Hardware random number generator is now used for cryptography.
>
>Signed-off-by: Leonhard Hesse <leonhard.hesse@bshg.com>
>Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>---
>
> arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>index 6159ed70d966..5c32d1e3675c 100644
>--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
>@@ -29,6 +29,10 @@ &gpmi {
> 	status = "okay";
> };
> 
>+&rngb {
>+	status = "okay";
>+};

In arch/arm/boot/dts/nxp/imx/imx6ull.dtsi, this node is default okay,
is there a need to set status okay here?

Regards,
Peng

>+
> &snvs_poweroff {
> 	status = "okay";
> };
>-- 
>2.43.0
>
>base-commit: e9565e23cd89d4d5cd4388f8742130be1d6f182d
>branch: bsh-202505-imx6ulz_smm_m2