[PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Leonardo Gomes]

Adjust get_value function in hw_hpd.c file to have
prefix to help in ftrace, the name change from
'get_value' to 'dal_hw_gpio_get_value'

Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
index 3f13a744d07d..b11ed1089589 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
@@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
 	*ptr = NULL;
 }
 
-static enum gpio_result get_value(
+static enum gpio_result dal_hw_gpio_get_value(
 	const struct hw_gpio_pin *ptr,
 	uint32_t *value)
 {
@@ -104,7 +104,7 @@ static enum gpio_result set_config(
 static const struct hw_gpio_pin_funcs funcs = {
 	.destroy = dal_hw_hpd_destroy,
 	.open = dal_hw_gpio_open,
-	.get_value = get_value,
+	.get_value = dal_hw_gpio_get_value,
 	.set_value = dal_hw_gpio_set_value,
 	.set_config = set_config,
 	.change_mode = dal_hw_gpio_change_mode,
-- 
2.43.0

[PATCH 2/2 RESEND] drm/amd/display: Adjust set_value function with prefix to help in ftrace

[Leonardo Gomes]

Adjust set_value function in hw_hpd.c file to have
prefix to help in ftrace, the name change from
'set_value' to 'dal_hw_gpio_set_value'

Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
index b11ed1089589..03e773136189 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
@@ -85,7 +85,7 @@ static enum gpio_result dal_hw_gpio_get_value(
 	return dal_hw_gpio_get_value(ptr, value);
 }
 
-static enum gpio_result set_config(
+static enum gpio_result dal_hw_gpio_set_config(
 	struct hw_gpio_pin *ptr,
 	const struct gpio_config_data *config_data)
 {
@@ -106,7 +106,7 @@ static const struct hw_gpio_pin_funcs funcs = {
 	.open = dal_hw_gpio_open,
 	.get_value = dal_hw_gpio_get_value,
 	.set_value = dal_hw_gpio_set_value,
-	.set_config = set_config,
+	.set_config = dal_hw_gpio_set_config,
 	.change_mode = dal_hw_gpio_change_mode,
 	.close = dal_hw_gpio_close,
 };
-- 
2.43.0

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Alex Deucher]

On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes
<leonardodasigomes@gmail.com> wrote:
>
> Adjust get_value function in hw_hpd.c file to have
> prefix to help in ftrace, the name change from
> 'get_value' to 'dal_hw_gpio_get_value'

This won't compile.  dal_hw_gpio_get_value is already defined in
drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c.

Alex

>
> Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
> Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
> Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> index 3f13a744d07d..b11ed1089589 100644
> --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
>         *ptr = NULL;
>  }
>
> -static enum gpio_result get_value(
> +static enum gpio_result dal_hw_gpio_get_value(
>         const struct hw_gpio_pin *ptr,
>         uint32_t *value)
>  {
> @@ -104,7 +104,7 @@ static enum gpio_result set_config(
>  static const struct hw_gpio_pin_funcs funcs = {
>         .destroy = dal_hw_hpd_destroy,
>         .open = dal_hw_gpio_open,
> -       .get_value = get_value,
> +       .get_value = dal_hw_gpio_get_value,
>         .set_value = dal_hw_gpio_set_value,
>         .set_config = set_config,
>         .change_mode = dal_hw_gpio_change_mode,
> --
> 2.43.0
>

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Leonardo Gomes]

[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]

Thanks for your reply Alex,

I just realize with your comment that
*drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c* import *dal_hw_gpio_get_value
*and *dal_hw_gpio_set_value*.
So to make those functions inside
*drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c*  more clear what do you
think to change them to *dal_hw_hpd_get_config* and *dal_hw_hpd_set_config*,
making clear that this is a function from the file hw_hpd?

Leonardo Gomes

Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher <alexdeucher@gmail.com>
escreveu:

> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes
> <leonardodasigomes@gmail.com> wrote:
> >
> > Adjust get_value function in hw_hpd.c file to have
> > prefix to help in ftrace, the name change from
> > 'get_value' to 'dal_hw_gpio_get_value'
>
> This won't compile.  dal_hw_gpio_get_value is already defined in
> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c.
>
> Alex
>
> >
> > Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
> > Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
> > Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
> > ---
> >  drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > index 3f13a744d07d..b11ed1089589 100644
> > --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> > @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
> >         *ptr = NULL;
> >  }
> >
> > -static enum gpio_result get_value(
> > +static enum gpio_result dal_hw_gpio_get_value(
> >         const struct hw_gpio_pin *ptr,
> >         uint32_t *value)
> >  {
> > @@ -104,7 +104,7 @@ static enum gpio_result set_config(
> >  static const struct hw_gpio_pin_funcs funcs = {
> >         .destroy = dal_hw_hpd_destroy,
> >         .open = dal_hw_gpio_open,
> > -       .get_value = get_value,
> > +       .get_value = dal_hw_gpio_get_value,
> >         .set_value = dal_hw_gpio_set_value,
> >         .set_config = set_config,
> >         .change_mode = dal_hw_gpio_change_mode,
> > --
> > 2.43.0
> >
>

[-- Attachment #2: Type: text/html, Size: 3212 bytes --]

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[kernel test robot]

Hi Leonardo,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-exynos/exynos-drm-next]
[also build test ERROR on linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.15-rc6 next-20250515]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leonardo-Gomes/drm-amd-display-Adjust-set_value-function-with-prefix-to-help-in-ftrace/20250515-151114
base:   https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link:    https://lore.kernel.org/r/20250514174306.82693-1-leonardodasigomes%40gmail.com
patch subject: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace
config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250516/202505162041.ftJ48E6X-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250516/202505162041.ftJ48E6X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505162041.ftJ48E6X-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c:65:25: error: static declaration of 'dal_hw_gpio_get_value' follows non-static declaration
      65 | static enum gpio_result dal_hw_gpio_get_value(
         |                         ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c:30:
   drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_gpio.h:122:18: note: previous declaration of 'dal_hw_gpio_get_value' with type 'enum gpio_result(const struct hw_gpio_pin *, uint32_t *)' {aka 'enum gpio_result(const struct hw_gpio_pin *, unsigned int *)'}
     122 | enum gpio_result dal_hw_gpio_get_value(
         |                  ^~~~~~~~~~~~~~~~~~~~~


vim +/dal_hw_gpio_get_value +65 drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/hw_hpd.c

    64	
  > 65	static enum gpio_result dal_hw_gpio_get_value(
    66		const struct hw_gpio_pin *ptr,
    67		uint32_t *value)
    68	{
    69		struct hw_hpd *hpd = HW_HPD_FROM_BASE(ptr);
    70		uint32_t hpd_delayed = 0;
    71	
    72		/* in Interrupt mode we ask for SENSE bit */
    73	
    74		if (ptr->mode == GPIO_MODE_INTERRUPT) {
    75	
    76			REG_GET(int_status,
    77				DC_HPD_SENSE_DELAYED, &hpd_delayed);
    78	
    79			*value = hpd_delayed;
    80			return GPIO_RESULT_OK;
    81		}
    82	
    83		/* in any other modes, operate as normal GPIO */
    84	
    85		return dal_hw_gpio_get_value(ptr, value);
    86	}
    87	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Alex Deucher]

On Thu, May 15, 2025 at 9:23 PM Leonardo Gomes
<leonardodasigomes@gmail.com> wrote:
>
> Thanks for your reply Alex,
>
> I just realize with your comment that drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c import dal_hw_gpio_get_value and dal_hw_gpio_set_value.
> So to make those functions inside drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c  more clear what do you think to change them to dal_hw_hpd_get_config and dal_hw_hpd_set_config, making clear that this is a function from the file hw_hpd?
>

Right.  It needs a different name to avoid the conflict with the other function.

Alex

> Leonardo Gomes
>
> Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher <alexdeucher@gmail.com> escreveu:
>>
>> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes
>> <leonardodasigomes@gmail.com> wrote:
>> >
>> > Adjust get_value function in hw_hpd.c file to have
>> > prefix to help in ftrace, the name change from
>> > 'get_value' to 'dal_hw_gpio_get_value'
>>
>> This won't compile.  dal_hw_gpio_get_value is already defined in
>> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c.
>>
>> Alex
>>
>> >
>> > Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
>> > Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
>> > Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
>> > ---
>> >  drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
>> > index 3f13a744d07d..b11ed1089589 100644
>> > --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
>> > +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
>> > @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
>> >         *ptr = NULL;
>> >  }
>> >
>> > -static enum gpio_result get_value(
>> > +static enum gpio_result dal_hw_gpio_get_value(
>> >         const struct hw_gpio_pin *ptr,
>> >         uint32_t *value)
>> >  {
>> > @@ -104,7 +104,7 @@ static enum gpio_result set_config(
>> >  static const struct hw_gpio_pin_funcs funcs = {
>> >         .destroy = dal_hw_hpd_destroy,
>> >         .open = dal_hw_gpio_open,
>> > -       .get_value = get_value,
>> > +       .get_value = dal_hw_gpio_get_value,
>> >         .set_value = dal_hw_gpio_set_value,
>> >         .set_config = set_config,
>> >         .change_mode = dal_hw_gpio_change_mode,
>> > --
>> > 2.43.0
>> >

[PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Leonardo Gomes]

Adjust get_value function in hw_hpd.c file to have
prefix to help in ftrace, the name change from
'get_value' to 'dal_hw_hpd_get_value'

Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
---
 drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
index 3f13a744d07d..886dd05b012f 100644
--- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
+++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
@@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
 	*ptr = NULL;
 }
 
-static enum gpio_result get_value(
+static enum gpio_result dal_hw_hpd_get_value(
 	const struct hw_gpio_pin *ptr,
 	uint32_t *value)
 {
@@ -104,7 +104,7 @@ static enum gpio_result set_config(
 static const struct hw_gpio_pin_funcs funcs = {
 	.destroy = dal_hw_hpd_destroy,
 	.open = dal_hw_gpio_open,
-	.get_value = get_value,
+	.get_value = dal_hw_hpd_get_value,
 	.set_value = dal_hw_gpio_set_value,
 	.set_config = set_config,
 	.change_mode = dal_hw_gpio_change_mode,
-- 
2.43.0

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

[Leonardo Gomes]

[-- Attachment #1: Type: text/plain, Size: 2908 bytes --]

Good morning Alex,

I just resend the patch with the name I`ve been suggesting, please let me
know if you have any recommendation.
And thanks again for your reply 😄

Leonardo Gomes

Em sex., 16 de mai. de 2025 às 13:56, Alex Deucher <alexdeucher@gmail.com>
escreveu:

> On Thu, May 15, 2025 at 9:23 PM Leonardo Gomes
> <leonardodasigomes@gmail.com> wrote:
> >
> > Thanks for your reply Alex,
> >
> > I just realize with your comment that
> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c import dal_hw_gpio_get_value
> and dal_hw_gpio_set_value.
> > So to make those functions inside
> drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c  more clear what do you think
> to change them to dal_hw_hpd_get_config and dal_hw_hpd_set_config, making
> clear that this is a function from the file hw_hpd?
> >
>
> Right.  It needs a different name to avoid the conflict with the other
> function.
>
> Alex
>
> > Leonardo Gomes
> >
> > Em qua., 14 de mai. de 2025 às 18:08, Alex Deucher <
> alexdeucher@gmail.com> escreveu:
> >>
> >> On Wed, May 14, 2025 at 4:48 PM Leonardo Gomes
> >> <leonardodasigomes@gmail.com> wrote:
> >> >
> >> > Adjust get_value function in hw_hpd.c file to have
> >> > prefix to help in ftrace, the name change from
> >> > 'get_value' to 'dal_hw_gpio_get_value'
> >>
> >> This won't compile.  dal_hw_gpio_get_value is already defined in
> >> drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c.
> >>
> >> Alex
> >>
> >> >
> >> > Signed-off-by: Leonardo da Silva Gomes <leonardodasigomes@gmail.com>
> >> > Co-developed-by: Derick Frias <derick.william.moraes@gmail.com>
> >> > Signed-off-by: Derick Frias <derick.william.moraes@gmail.com>
> >> > ---
> >> >  drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c | 4 ++--
> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> >> > index 3f13a744d07d..b11ed1089589 100644
> >> > --- a/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> >> > +++ b/drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c
> >> > @@ -62,7 +62,7 @@ static void dal_hw_hpd_destroy(
> >> >         *ptr = NULL;
> >> >  }
> >> >
> >> > -static enum gpio_result get_value(
> >> > +static enum gpio_result dal_hw_gpio_get_value(
> >> >         const struct hw_gpio_pin *ptr,
> >> >         uint32_t *value)
> >> >  {
> >> > @@ -104,7 +104,7 @@ static enum gpio_result set_config(
> >> >  static const struct hw_gpio_pin_funcs funcs = {
> >> >         .destroy = dal_hw_hpd_destroy,
> >> >         .open = dal_hw_gpio_open,
> >> > -       .get_value = get_value,
> >> > +       .get_value = dal_hw_gpio_get_value,
> >> >         .set_value = dal_hw_gpio_set_value,
> >> >         .set_config = set_config,
> >> >         .change_mode = dal_hw_gpio_change_mode,
> >> > --
> >> > 2.43.0
> >> >
>

[-- Attachment #2: Type: text/html, Size: 4257 bytes --]