[PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

core: Add documentation of "sg" field in the dwc3_request struct.

Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
---
 drivers/usb/dwc3/core.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index f11570c8ffd0..bb140dde07d6 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -942,6 +942,7 @@ struct dwc3_hwparams {
  * @request: struct usb_request to be transferred
  * @list: a list_head used for request queueing
  * @dep: struct dwc3_ep owning this request
+ * @sg: pointer to the scatter-gather list for transfers
  * @start_sg: pointer to the sg which should be queued next
  * @num_pending_sgs: counter to pending sgs
  * @remaining: amount of data remaining
-- 
2.43.0

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Greg KH]

On Sun, May 18, 2025 at 11:33:30AM +0000, Jonathan Velez wrote:
> core: Add documentation of "sg" field in the dwc3_request struct.
> 
> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index f11570c8ffd0..bb140dde07d6 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>   * @request: struct usb_request to be transferred
>   * @list: a list_head used for request queueing
>   * @dep: struct dwc3_ep owning this request
> + * @sg: pointer to the scatter-gather list for transfers
>   * @start_sg: pointer to the sg which should be queued next
>   * @num_pending_sgs: counter to pending sgs
>   * @remaining: amount of data remaining
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Greg KH]

On Sun, May 18, 2025 at 11:33:30AM +0000, Jonathan Velez wrote:
> core: Add documentation of "sg" field in the dwc3_request struct.
> 
> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index f11570c8ffd0..bb140dde07d6 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>   * @request: struct usb_request to be transferred
>   * @list: a list_head used for request queueing
>   * @dep: struct dwc3_ep owning this request
> + * @sg: pointer to the scatter-gather list for transfers
>   * @start_sg: pointer to the sg which should be queued next
>   * @num_pending_sgs: counter to pending sgs
>   * @remaining: amount of data remaining

What commit id does this fix?

And are you sure you made this against the right tree?  I do not see
"sg" as a member of this stucture at all anymore.

thanks,

greg k-h

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

> On May 18, 2025, at 7:58 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Sun, May 18, 2025 at 11:33:30AM +0000, Jonathan Velez wrote:
>> core: Add documentation of "sg" field in the dwc3_request struct.
>> 
>> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
>> ---
>> drivers/usb/dwc3/core.h | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index f11570c8ffd0..bb140dde07d6 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>>  * @request: struct usb_request to be transferred
>>  * @list: a list_head used for request queueing
>>  * @dep: struct dwc3_ep owning this request
>> + * @sg: pointer to the scatter-gather list for transfers
>>  * @start_sg: pointer to the sg which should be queued next
>>  * @num_pending_sgs: counter to pending sgs
>>  * @remaining: amount of data remaining
> 
> What commit id does this fix?
   I pulled the mainline and worked on the “for-next” branch. Is that the correct process? Should I be using the “master” branch instead?
> 
> And are you sure you made this against the right tree?  I do not see
> "sg" as a member of this stucture at all anymore.
   This was the last commit on the “for-next” branch:

   commit ffd294d346d185b70e28b1a28abe367bbfe53c04 
> 
> thanks,
> 
> greg k-h

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Greg KH]

On Sun, May 18, 2025 at 08:08:46AM -0400, Jonathan Velez wrote:
> 
> 
> > On May 18, 2025, at 7:58 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > 
> > On Sun, May 18, 2025 at 11:33:30AM +0000, Jonathan Velez wrote:
> >> core: Add documentation of "sg" field in the dwc3_request struct.
> >> 
> >> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
> >> ---
> >> drivers/usb/dwc3/core.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> >> index f11570c8ffd0..bb140dde07d6 100644
> >> --- a/drivers/usb/dwc3/core.h
> >> +++ b/drivers/usb/dwc3/core.h
> >> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
> >>  * @request: struct usb_request to be transferred
> >>  * @list: a list_head used for request queueing
> >>  * @dep: struct dwc3_ep owning this request
> >> + * @sg: pointer to the scatter-gather list for transfers
> >>  * @start_sg: pointer to the sg which should be queued next
> >>  * @num_pending_sgs: counter to pending sgs
> >>  * @remaining: amount of data remaining
> > 
> > What commit id does this fix?
>    I pulled the mainline and worked on the “for-next” branch. Is that the correct process? Should I be using the “master” branch instead?
> > 
> > And are you sure you made this against the right tree?  I do not see
> > "sg" as a member of this stucture at all anymore.
>    This was the last commit on the “for-next” branch:
> 
>    commit ffd294d346d185b70e28b1a28abe367bbfe53c04 

That is the 6.13 release from way back on January 19.  I think a few
other things have happened since then :)

Please work against either the development branch of the subsystem you
are submitting changes for, OR against the linux-next tree which merges
all subsystems together, so that you do not accidentally use an old
tree.

thanks,

greg k-h

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

> On May 18, 2025, at 8:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Sun, May 18, 2025 at 08:08:46AM -0400, Jonathan Velez wrote:
>> 
>> 
>>> On May 18, 2025, at 7:58 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>> 
>>> On Sun, May 18, 2025 at 11:33:30AM +0000, Jonathan Velez wrote:
>>>> core: Add documentation of "sg" field in the dwc3_request struct.
>>>> 
>>>> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
>>>> ---
>>>> drivers/usb/dwc3/core.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>> 
>>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>>> index f11570c8ffd0..bb140dde07d6 100644
>>>> --- a/drivers/usb/dwc3/core.h
>>>> +++ b/drivers/usb/dwc3/core.h
>>>> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>>>> * @request: struct usb_request to be transferred
>>>> * @list: a list_head used for request queueing
>>>> * @dep: struct dwc3_ep owning this request
>>>> + * @sg: pointer to the scatter-gather list for transfers
>>>> * @start_sg: pointer to the sg which should be queued next
>>>> * @num_pending_sgs: counter to pending sgs
>>>> * @remaining: amount of data remaining
>>> 
>>> What commit id does this fix?
>>   I pulled the mainline and worked on the “for-next” branch. Is that the correct process? Should I be using the “master” branch instead?
>>> 
>>> And are you sure you made this against the right tree?  I do not see
>>> "sg" as a member of this stucture at all anymore.
>>   This was the last commit on the “for-next” branch:
>> 
>>   commit ffd294d346d185b70e28b1a28abe367bbfe53c04 
> 
> That is the 6.13 release from way back on January 19.  I think a few
> other things have happened since then :)
   :)
> 
> Please work against either the development branch of the subsystem you
> are submitting changes for, OR against the linux-next tree which merges
> all subsystems together, so that you do not accidentally use an old
> tree.
   Moving forward I’ll make sure to work against a subsystem development branch or the linux-next tree, thank you for the help Greg!
> thanks,
> 
> greg k-h

[PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

core: Add documentation of "sg" field in the dwc3_request struct.

Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
---
 drivers/usb/dwc3/core.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index f11570c8ffd0..bb140dde07d6 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -942,6 +942,7 @@ struct dwc3_hwparams {
  * @request: struct usb_request to be transferred
  * @list: a list_head used for request queueing
  * @dep: struct dwc3_ep owning this request
+ * @sg: pointer to the scatter-gather list for transfers
  * @start_sg: pointer to the sg which should be queued next
  * @num_pending_sgs: counter to pending sgs
  * @remaining: amount of data remaining
-- 
2.43.0

[PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
---
 drivers/usb/dwc3/core.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index f11570c8ffd0..bb140dde07d6 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -942,6 +942,7 @@ struct dwc3_hwparams {
  * @request: struct usb_request to be transferred
  * @list: a list_head used for request queueing
  * @dep: struct dwc3_ep owning this request
+ * @sg: pointer to the scatter-gather list for transfers
  * @start_sg: pointer to the sg which should be queued next
  * @num_pending_sgs: counter to pending sgs
  * @remaining: amount of data remaining
-- 
2.43.0

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Greg KH]

On Fri, May 16, 2025 at 11:54:47PM +0000, Jonathan Velez wrote:
> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
> ---
>  drivers/usb/dwc3/core.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index f11570c8ffd0..bb140dde07d6 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>   * @request: struct usb_request to be transferred
>   * @list: a list_head used for request queueing
>   * @dep: struct dwc3_ep owning this request
> + * @sg: pointer to the scatter-gather list for transfers
>   * @start_sg: pointer to the sg which should be queued next
>   * @num_pending_sgs: counter to pending sgs
>   * @remaining: amount of data remaining
> -- 
> 2.43.0
> 
> 

For obvious reasons, we can't take patches without any changelog text at
all (and you wouldn't want us to.)

sorry,

greg k-h

Re: [PATCH] docs: usb: dwc3: add documentation of 'sg' field in dwc3_request struct

[Jonathan Velez]

> On May 18, 2025, at 1:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Fri, May 16, 2025 at 11:54:47PM +0000, Jonathan Velez wrote:
>> Signed-off-by: Jonathan Velez <jonvelez12345@gmail.com>
>> ---
>> drivers/usb/dwc3/core.h | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index f11570c8ffd0..bb140dde07d6 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -942,6 +942,7 @@ struct dwc3_hwparams {
>>  * @request: struct usb_request to be transferred
>>  * @list: a list_head used for request queueing
>>  * @dep: struct dwc3_ep owning this request
>> + * @sg: pointer to the scatter-gather list for transfers
>>  * @start_sg: pointer to the sg which should be queued next
>>  * @num_pending_sgs: counter to pending sgs
>>  * @remaining: amount of data remaining
>> -- 
>> 2.43.0
>> 
>> 
> 
> For obvious reasons, we can't take patches without any changelog text at
> all (and you wouldn't want us to.)

  Agreed! I’m sending an updated patch with change log text.

> 
> sorry,
> 
> greg k-h