[backport] [PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[backport] [PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[Alon Bar-Lev]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hello,

Please consider backporting "module.bbclass: add KBUILD_EXTRA_SYMBOLS to
install"[1] trivial patch to Scarthgap and Walnascar, it will allow
building kernel modules with dependencies without linkage breakage also in
stable branches.

Master commit hash: 483c6067eb1ee9562c0b21cea0d375c7f521bede
Into [at least]: scarthgap, walnascar

Regards,
Alon Bar-Lev

[1]
https://git.yoctoproject.org/poky/commit/?id=483c6067eb1ee9562c0b21cea0d375c7f521bede

[-- Attachment #2: Type: text/html, Size: 744 bytes --]

Re: [OE-core] [backport] [PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[Khem Raj]

On Mon, May 12, 2025 at 6:49 AM Alon Bar-Lev via
lists.openembedded.org <alon.barlev=gmail.com@lists.openembedded.org>
wrote:
>
> Hello,
>
> Please consider backporting "module.bbclass: add KBUILD_EXTRA_SYMBOLS to install"[1] trivial patch to Scarthgap and Walnascar, it will allow building kernel modules with dependencies without linkage breakage also in stable branches.
>
> Master commit hash: 483c6067eb1ee9562c0b21cea0d375c7f521bede
> Into [at least]: scarthgap, walnascar

It will be faster if you can send the backported patches to the
mailing list after testing them out on the releases you propose them
for prefixed in the subject line

>
> Regards,
> Alon Bar-Lev
>
> [1] https://git.yoctoproject.org/poky/commit/?id=483c6067eb1ee9562c0b21cea0d375c7f521bede
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#216370): https://lists.openembedded.org/g/openembedded-core/message/216370
> Mute This Topic: https://lists.openembedded.org/mt/113070483/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [backport] [PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[Alon Bar-Lev]

Hello Khem,

On Mon, 12 May 2025 at 23:13, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, May 12, 2025 at 6:49 AM Alon Bar-Lev via
> lists.openembedded.org <alon.barlev=gmail.com@lists.openembedded.org>
> wrote:
> >
> > Hello,
> >
> > Please consider backporting "module.bbclass: add KBUILD_EXTRA_SYMBOLS to install"[1] trivial patch to Scarthgap and Walnascar, it will allow building kernel modules with dependencies without linkage breakage also in stable branches.
> >
> > Master commit hash: 483c6067eb1ee9562c0b21cea0d375c7f521bede
> > Into [at least]: scarthgap, walnascar
>
> It will be faster if you can send the backported patches to the
> mailing list after testing them out on the releases you propose them
> for prefixed in the subject line

The patch cleanly applies (cherry-picked) to both scarthgap, walnascar
and tested.

Regards,
Alon

[scarthgap][PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[Alon Bar-Lev]

Symbols are used during install as well, adding KBUILD_EXTRA_SYMBOLS enables
successful installation.

    | DEBUG: Executing shell function do_install
    | NOTE: make -j 22 KERNEL_SRC=xxx/kernel-source -C xxx/drivers
    KDIR=xxx/kernel-source DEPMOD=echo
    MODLIB=xxx/image/lib/modules/6.6.75-yocto-standard-00189-g530c419bc9db
    INSTALL_FW_PATH=xxx/image/lib/firmware CC=aarch64-poky-linux-gcc
    -fuse-ld=bfd -fcanon-prefix-map  LD=aarch64-poky-linux-ld.bfd
    OBJCOPY=aarch64-poky-linux-objcopy  STRIP=aarch64-poky-linux-strip
    O=xxx/kernel-build-artifacts modules_install
    | make: Entering directory 'xxx/drivers'
    | make -C xxx/kernel-source M=xxx/drivers modules
    | make[1]: Entering directory 'xxx/kernel-source'
    | make[2]: Entering directory 'xxx/kernel-build-artifacts'
    |   MODPOST xxx/drivers/Module.symvers
    | ERROR: modpost: "xxx" [xxx/xxx.ko] undefined!

(From OE-Core rev: 0ef80eeda967a9e04ff91c3583aabbc35c9868e8)

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-recipe/module.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes-recipe/module.bbclass b/meta/classes-recipe/module.bbclass
index f2f0b25a2d..4948e995c5 100644
--- a/meta/classes-recipe/module.bbclass
+++ b/meta/classes-recipe/module.bbclass
@@ -65,6 +65,7 @@ module_do_install() {
 	           CC="${KERNEL_CC}" LD="${KERNEL_LD}" OBJCOPY="${KERNEL_OBJCOPY}" \
 	           STRIP="${KERNEL_STRIP}" \
 	           O=${STAGING_KERNEL_BUILDDIR} \
+		   KBUILD_EXTRA_SYMBOLS="${KBUILD_EXTRA_SYMBOLS}" \
 	           ${MODULES_INSTALL_TARGET}
 
 	if [ ! -e "${B}/${MODULES_MODULE_SYMVERS_LOCATION}/Module.symvers" ] ; then
-- 
2.43.0

[walnascar][PATCH] module.bbclass: add KBUILD_EXTRA_SYMBOLS to install

[Alon Bar-Lev]

Symbols are used during install as well, adding KBUILD_EXTRA_SYMBOLS enables
successful installation.

    | DEBUG: Executing shell function do_install
    | NOTE: make -j 22 KERNEL_SRC=xxx/kernel-source -C xxx/drivers
    KDIR=xxx/kernel-source DEPMOD=echo
    MODLIB=xxx/image/lib/modules/6.6.75-yocto-standard-00189-g530c419bc9db
    INSTALL_FW_PATH=xxx/image/lib/firmware CC=aarch64-poky-linux-gcc
    -fuse-ld=bfd -fcanon-prefix-map  LD=aarch64-poky-linux-ld.bfd
    OBJCOPY=aarch64-poky-linux-objcopy  STRIP=aarch64-poky-linux-strip
    O=xxx/kernel-build-artifacts modules_install
    | make: Entering directory 'xxx/drivers'
    | make -C xxx/kernel-source M=xxx/drivers modules
    | make[1]: Entering directory 'xxx/kernel-source'
    | make[2]: Entering directory 'xxx/kernel-build-artifacts'
    |   MODPOST xxx/drivers/Module.symvers
    | ERROR: modpost: "xxx" [xxx/xxx.ko] undefined!

(From OE-Core rev: 0ef80eeda967a9e04ff91c3583aabbc35c9868e8)

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-recipe/module.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes-recipe/module.bbclass b/meta/classes-recipe/module.bbclass
index f2f0b25a2d..4948e995c5 100644
--- a/meta/classes-recipe/module.bbclass
+++ b/meta/classes-recipe/module.bbclass
@@ -65,6 +65,7 @@ module_do_install() {
 	           CC="${KERNEL_CC}" LD="${KERNEL_LD}" OBJCOPY="${KERNEL_OBJCOPY}" \
 	           STRIP="${KERNEL_STRIP}" \
 	           O=${STAGING_KERNEL_BUILDDIR} \
+		   KBUILD_EXTRA_SYMBOLS="${KBUILD_EXTRA_SYMBOLS}" \
 	           ${MODULES_INSTALL_TARGET}
 
 	if [ ! -e "${B}/${MODULES_MODULE_SYMVERS_LOCATION}/Module.symvers" ] ; then
-- 
2.43.0