* [PATCH] extcon: max14526: add CONFIG_I2C dependency
@ 2025-05-20 15:26 Arnd Bergmann
2025-05-26 2:28 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-05-20 15:26 UTC (permalink / raw)
To: MyungJoo Ham, Chanwoo Choi, Svyatoslav Ryhel
Cc: Arnd Bergmann, Hans de Goede, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
When I2C is in a loadable module, the newly added driver causes
a build failure. The problem is shown by Kconfig:
WARNING: unmet direct dependencies detected for REGMAP_I2C
Depends on [m]: I2C [=m]
Selected by [y]:
- EXTCON_MAX14526 [=y] && EXTCON [=y]
Add the required dependency here.
Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/extcon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1096afc0b5bb..aec46bf03302 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -136,6 +136,7 @@ config EXTCON_MAX8997
config EXTCON_MAX14526
tristate "Maxim MAX14526 EXTCON Support"
+ depends on I2C
select IRQ_DOMAIN
select REGMAP_I2C
help
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] extcon: max14526: add CONFIG_I2C dependency
2025-05-20 15:26 [PATCH] extcon: max14526: add CONFIG_I2C dependency Arnd Bergmann
@ 2025-05-26 2:28 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2025-05-26 2:28 UTC (permalink / raw)
To: Arnd Bergmann, MyungJoo Ham, Chanwoo Choi, Svyatoslav Ryhel
Cc: Arnd Bergmann, Hans de Goede, linux-kernel
On 5/20/25 8:26 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When I2C is in a loadable module, the newly added driver causes
> a build failure. The problem is shown by Kconfig:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
> Depends on [m]: I2C [=m]
> Selected by [y]:
> - EXTCON_MAX14526 [=y] && EXTCON [=y]
>
> Add the required dependency here.
Same as my patch:
https://lore.kernel.org/lkml/20250515234803.1385375-1-rdunlap@infradead.org/
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1096afc0b5bb..aec46bf03302 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -136,6 +136,7 @@ config EXTCON_MAX8997
>
> config EXTCON_MAX14526
> tristate "Maxim MAX14526 EXTCON Support"
> + depends on I2C
> select IRQ_DOMAIN
> select REGMAP_I2C
> help
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-26 2:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-20 15:26 [PATCH] extcon: max14526: add CONFIG_I2C dependency Arnd Bergmann
2025-05-26 2:28 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.