* [PATCH v2 0/1] Some kernel-doc fixes
@ 2025-05-21 6:50 Mauro Carvalho Chehab
2025-05-21 6:50 ` [PATCH v2 1/1] MAINTAINERS: update linux-doc entry to cover new Python scripts Mauro Carvalho Chehab
2025-05-21 7:01 ` [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2025-05-21 6:50 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Mauro Carvalho Chehab, Akira Yokosawa, linux-doc, Masahiro Yamada,
Nathan Chancellor, Nicolas Schier, Andy Shevchenko,
Stephen Rothwell, Randy Dunlap, linux-kbuild, linux-kernel
Hi Jon,
That's the second version of the kernel-doc fixup patch series.
I discovered the root cause why Sphinx logger was not working: there
was a call there for logger.verbose(). According with:
https://www.sphinx-doc.org/en/master/extdev/logging.html
This is a valid call, but it doesn't verbose messages. Instead, it is
crashing with modern Sphinx versions, causing the log to not work.
I got rid of it, replacing by logger.info(). I took the time to also
address an issue pointed by Andy: not having the same log message
placed everywhere. With such change, we can keep using Sphinx
logger (which produces colored messages) inside kernel-doc
classes.
With that, we have:
Patch 1: cleanup try/except logic and get rid of logger.verbose();
Patch 2: fix a KeyError when trying to acess data from non-existing files;
Patch 3: makes Lore and kernel-doc ML receive patches related
to kernel-doc.py and get_abi.py.
If you test just patch 1 on the top of next-20250516, you'll see the
keyerror message (in red):
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
WARNING: kernel-doc './scripts/kernel-doc.py -rst -enable-lineno -export ./drivers/gpio/gpiolib-acpi.c' processing failed with: KeyError('./drivers/gpio/gpiolib-acpi.c')
And the script doesn't crash anymore. After patch 2, the try/except
warning gets replaced by a proper message:
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
WARNING: No kernel-doc for file ./drivers/gpio/gpiolib-acpi.c
Please apply it to solve the issues that are reported by Stephen and Akira.
Regards,
Mauro
Mauro Carvalho Chehab (1):
MAINTAINERS: update linux-doc entry to cover new Python scripts
MAINTAINERS | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.49.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] MAINTAINERS: update linux-doc entry to cover new Python scripts
2025-05-21 6:50 [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
@ 2025-05-21 6:50 ` Mauro Carvalho Chehab
2025-05-21 7:01 ` [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2025-05-21 6:50 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Mauro Carvalho Chehab, Akira Yokosawa, Andy Shevchenko,
Masahiro Yamada, Nathan Chancellor, Nicolas Schier, Randy Dunlap,
Stephen Rothwell, linux-doc, linux-kbuild, linux-kernel
Changes to ABI and kernel-doc need to be c/c linux-doc. Update
the maintainer's entry to cover those files.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
MAINTAINERS | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 20e07e61a148..a668808769b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7173,7 +7173,10 @@ T: git git://git.lwn.net/linux.git docs-next
F: Documentation/
F: scripts/check-variable-fonts.sh
F: scripts/documentation-file-ref-check
-F: scripts/kernel-doc
+F: scripts/get_abi.py
+F: scripts/kernel-doc*
+F scripts/lib/abi/*
+F scripts/lib/kdoc/*
F: scripts/sphinx-pre-install
X: Documentation/ABI/
X: Documentation/admin-guide/media/
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 0/1] Some kernel-doc fixes
2025-05-21 6:50 [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
2025-05-21 6:50 ` [PATCH v2 1/1] MAINTAINERS: update linux-doc entry to cover new Python scripts Mauro Carvalho Chehab
@ 2025-05-21 7:01 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2025-05-21 7:01 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Akira Yokosawa, linux-doc, Nicolas Schier, Andy Shevchenko,
Stephen Rothwell, Randy Dunlap, linux-kbuild, linux-kernel
Em Wed, 21 May 2025 08:50:25 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> Hi Jon,
>
> That's the second version of the kernel-doc fixup patch series.
Please ignore this... It got just the last patch...
It reminds I didn't trink my usual cup of coffee this morning.
I opted to re-order the series placing the MAINTAINERS patch first,
with the hope that Lore would pick the entire series as submissions
for linux-doc.
Thanks,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-21 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 6:50 [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
2025-05-21 6:50 ` [PATCH v2 1/1] MAINTAINERS: update linux-doc entry to cover new Python scripts Mauro Carvalho Chehab
2025-05-21 7:01 ` [PATCH v2 0/1] Some kernel-doc fixes Mauro Carvalho Chehab
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.