* [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
@ 2025-05-22 17:25 ` Anand Moon
0 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2025-05-22 17:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list
Cc: Anand Moon, Wayne Schroeder
Add missing reset-gpios property to the USB 2.0 hub node to
ensure proper reset handling. Also update the vdd-supply for
both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
for consistent power management.
Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v3: dropped remove of usb2_phy1.
v2: remove usb2_phy1 phy-supply since now it's managed by
the hub reset control.
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index 3bca8023638d4..ad959f8bc1acd 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -42,7 +42,8 @@ hub_2_0: hub@1 {
compatible = "usb5e3,610";
reg = <1>;
peer-hub = <&hub_3_0>;
- vdd-supply = <&usb_pwr_en>;
+ reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
+ vdd-supply = <&hub_5v>;
};
/* 3.0 hub on port 4 */
@@ -51,7 +52,7 @@ hub_3_0: hub@2 {
reg = <2>;
peer-hub = <&hub_2_0>;
reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
- vdd-supply = <&vcc_5v>;
+ vdd-supply = <&hub_5v>;
};
};
base-commit: 5cdb2c77c4c3d36bdee83d9231649941157f8204
--
2.49.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 2/2] arm64: dts: amlogic: Adjust USB PHY power supply references
2025-05-22 17:25 ` Anand Moon
@ 2025-05-22 17:25 ` Anand Moon
-1 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2025-05-22 17:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list
Cc: Anand Moon, Wayne Schroeder
According to the Odroid-N2 schematics, the micro-USB phy is powered
via a gpio-controlled regulator PWREN, updates the phy-supply to
correctly assign the power supply for usb2_phy.
Additionally, the USB3 combo port, which connects to the onboard
4-port USB hub, is powered by the main VCC_5V rail. Updated the
phy-supply to correctly assign vcc_5v for the USB controller node.
These changes ensure accurate power supply configuration for
USB components, improving hardware compatibility and power management.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
new patch
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index ad959f8bc1acd..9d63ab82302eb 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -310,7 +310,7 @@ &toacodec {
};
&usb {
- vbus-supply = <&usb_pwr_en>;
+ phy-supply = <&vcc_5v>;
};
&usb2_phy1 {
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
index 7e8964bacfce7..b105a8ae2fec6 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
@@ -437,5 +437,5 @@ &usb {
};
&usb2_phy0 {
- phy-supply = <&vcc_5v>;
+ phy-supply = <&usb_pwr_en>;
};
--
2.49.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 2/2] arm64: dts: amlogic: Adjust USB PHY power supply references
@ 2025-05-22 17:25 ` Anand Moon
0 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2025-05-22 17:25 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Greg Kroah-Hartman,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support, open list
Cc: Anand Moon, Wayne Schroeder
According to the Odroid-N2 schematics, the micro-USB phy is powered
via a gpio-controlled regulator PWREN, updates the phy-supply to
correctly assign the power supply for usb2_phy.
Additionally, the USB3 combo port, which connects to the onboard
4-port USB hub, is powered by the main VCC_5V rail. Updated the
phy-supply to correctly assign vcc_5v for the USB controller node.
These changes ensure accurate power supply configuration for
USB components, improving hardware compatibility and power management.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
new patch
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 2 +-
arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
index ad959f8bc1acd..9d63ab82302eb 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
@@ -310,7 +310,7 @@ &toacodec {
};
&usb {
- vbus-supply = <&usb_pwr_en>;
+ phy-supply = <&vcc_5v>;
};
&usb2_phy1 {
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
index 7e8964bacfce7..b105a8ae2fec6 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid.dtsi
@@ -437,5 +437,5 @@ &usb {
};
&usb2_phy0 {
- phy-supply = <&vcc_5v>;
+ phy-supply = <&usb_pwr_en>;
};
--
2.49.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
2025-05-22 17:25 ` Anand Moon
@ 2025-05-23 19:16 ` Rob Herring (Arm)
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-05-23 19:16 UTC (permalink / raw)
To: Anand Moon
Cc: Greg Kroah-Hartman, Martin Blumenstingl, Wayne Schroeder,
Kevin Hilman, linux-amlogic, Jerome Brunet, linux-kernel,
linux-arm-kernel, Neil Armstrong, Conor Dooley,
Krzysztof Kozlowski, devicetree
On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management.
>
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v3: dropped remove of usb2_phy1.
> v2: remove usb2_phy1 phy-supply since now it's managed by
> the hub reset control.
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@gmail.com:
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
@ 2025-05-23 19:16 ` Rob Herring (Arm)
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-05-23 19:16 UTC (permalink / raw)
To: Anand Moon
Cc: Greg Kroah-Hartman, Martin Blumenstingl, Wayne Schroeder,
Kevin Hilman, linux-amlogic, Jerome Brunet, linux-kernel,
linux-arm-kernel, Neil Armstrong, Conor Dooley,
Krzysztof Kozlowski, devicetree
On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management.
>
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v3: dropped remove of usb2_phy1.
> v2: remove usb2_phy1 phy-supply since now it's managed by
> the hub reset control.
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@gmail.com:
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
2025-05-23 19:16 ` Rob Herring (Arm)
@ 2025-05-28 7:33 ` Anand Moon
-1 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2025-05-28 7:33 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Greg Kroah-Hartman, Martin Blumenstingl, Wayne Schroeder,
Kevin Hilman, linux-amlogic, Jerome Brunet, linux-kernel,
linux-arm-kernel, Neil Armstrong, Conor Dooley,
Krzysztof Kozlowski, devicetree
Hi Rob,
On Sat, 24 May 2025 at 00:46, Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> > Add missing reset-gpios property to the USB 2.0 hub node to
> > ensure proper reset handling. Also update the vdd-supply for
> > both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> > for consistent power management.
> >
> > Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > v3: dropped remove of usb2_phy1.
> > v2: remove usb2_phy1 phy-supply since now it's managed by
> > the hub reset control.
> > ---
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@gmail.com:
>
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
> from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
> from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
>
Ok I am able to reproduce this, it seem the issue is with second patch
Currently, I am in the process of debugging the onboard_usb_dev.c driver.
It appears that the driver is not correctly parsing the perr-hub node and
is exiting prematurely. I’ve been able to partially identify the root cause,
but I haven’t yet found a proper solution.
alarm@odroid-n2plus:~$ lsmod | grep onboard
onboard_usb_dev 20480 0
alarm@odroid-n2plus:~$
Thanks
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] arm64: dts: amlogic: Update USB hub power and reset properties
@ 2025-05-28 7:33 ` Anand Moon
0 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2025-05-28 7:33 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Greg Kroah-Hartman, Martin Blumenstingl, Wayne Schroeder,
Kevin Hilman, linux-amlogic, Jerome Brunet, linux-kernel,
linux-arm-kernel, Neil Armstrong, Conor Dooley,
Krzysztof Kozlowski, devicetree
Hi Rob,
On Sat, 24 May 2025 at 00:46, Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Thu, 22 May 2025 22:55:31 +0530, Anand Moon wrote:
> > Add missing reset-gpios property to the USB 2.0 hub node to
> > ensure proper reset handling. Also update the vdd-supply for
> > both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> > for consistent power management.
> >
> > Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > v3: dropped remove of usb2_phy1.
> > v2: remove usb2_phy1 phy-supply since now it's managed by
> > the hub reset control.
> > ---
> > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: using specified base-commit 5cdb2c77c4c3d36bdee83d9231649941157f8204
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/amlogic/' for 20250522172535.302064-1-linux.amoon@gmail.com:
>
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
> from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtb: usb@ffe09000 (amlogic,meson-g12a-usb-ctrl): 'phy-supply' does not match any of the regexes: '^pinctrl-[0-9]+$', '^usb@[0-9a-f]+$'
> from schema $id: http://devicetree.org/schemas/usb/amlogic,meson-g12a-usb-ctrl.yaml#
>
Ok I am able to reproduce this, it seem the issue is with second patch
Currently, I am in the process of debugging the onboard_usb_dev.c driver.
It appears that the driver is not correctly parsing the perr-hub node and
is exiting prematurely. I’ve been able to partially identify the root cause,
but I haven’t yet found a proper solution.
alarm@odroid-n2plus:~$ lsmod | grep onboard
onboard_usb_dev 20480 0
alarm@odroid-n2plus:~$
Thanks
-Anand
^ permalink raw reply [flat|nested] 8+ messages in thread