Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting

From: Yixun Lan <dlan@gentoo.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	paul.walmsley@sifive.com, palmer@dabbelt.com,
	aou@eecs.berkeley.edu, alex@ghiti.fr, p.zabel@pengutronix.de,
	drew@pdp7.com, inochiama@gmail.com, geert+renesas@glider.be,
	heylenay@4d2.org, tglx@linutronix.de, hal.feng@starfivetech.com,
	unicorn_wang@outlook.com, duje.mihanovic@skole.hr,
	heikki.krogerus@linux.intel.com, elder@riscstar.com,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev
Subject: Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting
Date: Tue, 27 May 2025 03:27:01 +0000	[thread overview]
Message-ID: <20250527032701-GYA55693@gentoo> (raw)
In-Reply-To: <CAH1PCMZhS4_u3nTdAQDfTTRVJ_61n-OYjmMuv2m4DHYDzGE0XA@mail.gmail.com>

Hi Guodong,

On 10:48 Tue 27 May     , Guodong Xu wrote:
> On Tue, May 27, 2025 at 5:52 AM Yixun Lan <dlan@gentoo.org> wrote:
> >
> > Hi Guodong, Uwe,
> >
> > On 18:54 Mon 26 May     , Uwe Kleine-König wrote:
> > > On Tue, Apr 29, 2025 at 04:50:46PM +0800, Guodong Xu wrote:
> > > > diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > index 283663647a86..195eb8874f3c 100644
> > > > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > > > @@ -20,4 +20,11 @@ uart0-2-pins {
> > > >                     drive-strength = <32>;
> > > >             };
> > > >     };
> > > > +   pwm14_1_cfg: pwm14-1-cfg {
> > > > +           pwm14-1-pins {
> > > > +                   pinmux = <K1_PADCONF(44, 4)>;
> > > > +                   bias-pull-up = <0>;
> > > > +                   drive-strength = <32>;
> > > > +           };
> > > > +   };
> > >
> > > There is a newline expected before the pwm14-1-cfg node, isn't there?
> > >
> > Right, I could amend this and fix it while applying this patch
> > (so if there is no other serious issue, no need to resend)
> >
> 
> Thanks, Yixun.
> 
> By the way, do you plan to take patches 3 and 4 of this series into
> your tree? They only apply if the SpacemiT reset patchset is applied
> first.
> 
Yes, exactly. The dts patch will go through SpacemiT SoC tree, and we
have to wait untill reset patch series applied.

-- 
Yixun Lan (dlan)