From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] lib: LTP_SINGLE_FS_TYPE and LTP_FORCE_SINGLE_FS_TYPE
Date: Tue, 27 May 2025 13:00:43 +0200 [thread overview]
Message-ID: <20250527110043.GA186218@pevik> (raw)
In-Reply-To: <CAEemH2cCL9LpBRMnfJtShmdtwKTHLMC2hQeC_sFKyh4KWwUt0Q@mail.gmail.com>
> Petr Vorel <pvorel@suse.cz> wrote:
> > > One more thing I'm a bit hesitant about, do we need to explicitly set
> > > fs_types[1] to NULL here?
> > Although it looks reasonable, I suppose it's not needed because array is static,
> > therefore members are NULL, right?
> That's right, just confirmed with Cyril, so far we need to do nothing
> unless tst_get_supported_fs_types() is abused somewhere.
Abusing the function should be prevented if Cyril adds before merge 'static'
keyword to the function (as I suggested earlier).
Kind regards,
Petr
> Thanks for the quick reply, and feel free to merge this one.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-05-27 11:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 14:34 [LTP] [PATCH v4] lib: LTP_SINGLE_FS_TYPE and LTP_FORCE_SINGLE_FS_TYPE Cyril Hrubis
2025-05-26 15:51 ` Petr Vorel
2025-05-27 8:55 ` Li Wang via ltp
2025-05-28 13:16 ` Cyril Hrubis
2025-05-27 9:07 ` Li Wang via ltp
2025-05-27 9:31 ` Cyril Hrubis
2025-05-27 9:38 ` Li Wang via ltp
2025-05-27 9:42 ` Cyril Hrubis
2025-05-27 9:34 ` Petr Vorel
2025-05-27 9:57 ` Li Wang via ltp
2025-05-27 11:00 ` Petr Vorel [this message]
2025-05-27 11:16 ` Cyril Hrubis
2025-05-27 11:32 ` Petr Vorel
2025-05-27 11:43 ` Cyril Hrubis
2025-05-27 12:04 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527110043.GA186218@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.