All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4] lib: LTP_SINGLE_FS_TYPE and LTP_FORCE_SINGLE_FS_TYPE
Date: Tue, 27 May 2025 14:04:07 +0200	[thread overview]
Message-ID: <20250527120407.GB188735@pevik> (raw)
In-Reply-To: <aDWlb8u0apR22wv6@yuki.lan>

> Hi!
> > FYI also testcases/lib/tst_supported_fs.c uses it:

> > tst_supported_fs.c: In function ‘main’:
> > tst_supported_fs.c:152:23: error: implicit declaration of function ‘tst_get_supported_fs_types’ [-Wimplicit-function-declaration]
> >   152 |         filesystems = tst_get_supported_fs_types((const char * const*)skiplist);
> >       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > tst_supported_fs.c:152:21: error: assignment to ‘const char * const*’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> >   152 |         filesystems = tst_get_supported_fs_types((const char * const*)skiplist);
> >       |                     ^
> > make: *** [../../include/mk/rules.mk:48: tst_supported_fs] Error 1

> > Therefore we need either relative path (below) or tweak CFLAGS to add -I.

> If it's used from shell helper as well we have a tst_private.h header in
> include/ for that already, so I guess we should use that one instead.

+1 (I was searched for some specific header, but found only "public"
include/tst_common.h).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2025-05-27 12:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 14:34 [LTP] [PATCH v4] lib: LTP_SINGLE_FS_TYPE and LTP_FORCE_SINGLE_FS_TYPE Cyril Hrubis
2025-05-26 15:51 ` Petr Vorel
2025-05-27  8:55   ` Li Wang via ltp
2025-05-28 13:16     ` Cyril Hrubis
2025-05-27  9:07   ` Li Wang via ltp
2025-05-27  9:31     ` Cyril Hrubis
2025-05-27  9:38       ` Li Wang via ltp
2025-05-27  9:42         ` Cyril Hrubis
2025-05-27  9:34     ` Petr Vorel
2025-05-27  9:57       ` Li Wang via ltp
2025-05-27 11:00         ` Petr Vorel
2025-05-27 11:16           ` Cyril Hrubis
2025-05-27 11:32             ` Petr Vorel
2025-05-27 11:43               ` Cyril Hrubis
2025-05-27 12:04                 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250527120407.GB188735@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.