All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <nifan.cxl@gmail.com>
Cc: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>,
	<a.manzanares@samsung.com>, <dave@stgolabs.net>,
	<nmtadam.samsung@gmail.com>, <anisa.su887@gmail.com>,
	<gourry@gourry.net>, Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] hw/cxl: fix DC extent capacity tracking
Date: Thu, 29 May 2025 15:31:05 +0100	[thread overview]
Message-ID: <20250529153105.00000bd0@huawei.com> (raw)
In-Reply-To: <20250520195741.789841-1-nifan.cxl@gmail.com>

On Tue, 20 May 2025 12:56:43 -0700
nifan.cxl@gmail.com wrote:

> From: Fan Ni <fan.ni@samsung.com>
> 
> Per cxl r3.2 Section 9.13.3.3, extent capacity tracking should include
> extents in different states including added, pending, etc.
> 
> Before the change, for the in-device extent number tracking purpose, we only
> have "total_extent_count" defined, which only tracks the number of
> extents accepted. However, we need to track number of extents in other
> states also, for now it is extents pending-to-add.
> 
> To fix that, we introduce a new counter for dynamic capacity
> "nr_extents_accepted" which explicitly tracks number of the extents
> accepted by the hosts, and fix "total_extent_count" to include
> both accepted and pending extents counting.

Hi Fan,

This is complex code but looks correct to me - I'd managed to forget
all the weird ways the extent counts can go up and down - most of
which Linux doesn't actually hit.

For fixes like this can save a bit of time by +CC mst@redhat.com then
it just needs a review tag from me (or you if it is me sending).

I only have that other regloc fix and just sent that out for review
with mst +CC so maybe just send a v2 of this (rebased on upstream)
and add 

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: <nifan.cxl@gmail.com>
Cc: <qemu-devel@nongnu.org>, <linux-cxl@vger.kernel.org>,
	<a.manzanares@samsung.com>, <dave@stgolabs.net>,
	<nmtadam.samsung@gmail.com>,  <anisa.su887@gmail.com>,
	<gourry@gourry.net>, Fan Ni <fan.ni@samsung.com>
Subject: Re: [PATCH] hw/cxl: fix DC extent capacity tracking
Date: Thu, 29 May 2025 15:31:05 +0100	[thread overview]
Message-ID: <20250529153105.00000bd0@huawei.com> (raw)
In-Reply-To: <20250520195741.789841-1-nifan.cxl@gmail.com>

On Tue, 20 May 2025 12:56:43 -0700
nifan.cxl@gmail.com wrote:

> From: Fan Ni <fan.ni@samsung.com>
> 
> Per cxl r3.2 Section 9.13.3.3, extent capacity tracking should include
> extents in different states including added, pending, etc.
> 
> Before the change, for the in-device extent number tracking purpose, we only
> have "total_extent_count" defined, which only tracks the number of
> extents accepted. However, we need to track number of extents in other
> states also, for now it is extents pending-to-add.
> 
> To fix that, we introduce a new counter for dynamic capacity
> "nr_extents_accepted" which explicitly tracks number of the extents
> accepted by the hosts, and fix "total_extent_count" to include
> both accepted and pending extents counting.

Hi Fan,

This is complex code but looks correct to me - I'd managed to forget
all the weird ways the extent counts can go up and down - most of
which Linux doesn't actually hit.

For fixes like this can save a bit of time by +CC mst@redhat.com then
it just needs a review tag from me (or you if it is me sending).

I only have that other regloc fix and just sent that out for review
with mst +CC so maybe just send a v2 of this (rebased on upstream)
and add 

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>



  parent reply	other threads:[~2025-05-29 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 19:56 [PATCH] hw/cxl: fix DC extent capacity tracking nifan.cxl
2025-05-28 17:39 ` Fan Ni
2025-05-29 14:31 ` Jonathan Cameron [this message]
2025-05-29 14:31   ` Jonathan Cameron via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250529153105.00000bd0@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=a.manzanares@samsung.com \
    --cc=anisa.su887@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=gourry@gourry.net \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nifan.cxl@gmail.com \
    --cc=nmtadam.samsung@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.