From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: donald.hunter@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
vadim.fedorenko@linux.dev, jiri@resnulli.us,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com,
milena.olech@intel.com, corbet@lwn.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-doc@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to netlink spec
Date: Thu, 29 May 2025 17:33:11 -0700 [thread overview]
Message-ID: <20250529173311.15fcff9b@kernel.org> (raw)
In-Reply-To: <20250523154224.1510987-2-arkadiusz.kubalewski@intel.com>
On Fri, 23 May 2025 17:42:22 +0200 Arkadiusz Kubalewski wrote:
> +Phase offset measurement is typically performed against the current active
> +source. However, some DPLL (Digital Phase-Locked Loop) devices may offer
> +the capability to monitor phase offsets across all available inputs.
> +The attribute and current feature state shall be included in the response
> +message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL devices.
> +In such cases, users can also control the feature using the
> +``DPLL_CMD_DEVICE_SET`` command by setting the ``enum dpll_feature_state``
> +values for the attribute.
Since we're waiting for the merge window to be over - could you mention
the attribute the PHASE_OFFSET comes out as? DPLL_A_PIN_PHASE_OFFSET ?
BTW I noticed that in the YAML spec, in a comment we say
DPLL_A_PHASE_OFFSET a couple of times, missing the _PIN.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: donald.hunter@gmail.com, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
vadim.fedorenko@linux.dev, jiri@resnulli.us,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, aleksandr.loktionov@intel.com,
milena.olech@intel.com, corbet@lwn.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to netlink spec
Date: Thu, 29 May 2025 17:33:11 -0700 [thread overview]
Message-ID: <20250529173311.15fcff9b@kernel.org> (raw)
In-Reply-To: <20250523154224.1510987-2-arkadiusz.kubalewski@intel.com>
On Fri, 23 May 2025 17:42:22 +0200 Arkadiusz Kubalewski wrote:
> +Phase offset measurement is typically performed against the current active
> +source. However, some DPLL (Digital Phase-Locked Loop) devices may offer
> +the capability to monitor phase offsets across all available inputs.
> +The attribute and current feature state shall be included in the response
> +message of the ``DPLL_CMD_DEVICE_GET`` command for supported DPLL devices.
> +In such cases, users can also control the feature using the
> +``DPLL_CMD_DEVICE_SET`` command by setting the ``enum dpll_feature_state``
> +values for the attribute.
Since we're waiting for the merge window to be over - could you mention
the attribute the PHASE_OFFSET comes out as? DPLL_A_PIN_PHASE_OFFSET ?
BTW I noticed that in the YAML spec, in a comment we say
DPLL_A_PHASE_OFFSET a couple of times, missing the _PIN.
next prev parent reply other threads:[~2025-05-30 0:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 15:42 [Intel-wired-lan] [PATCH net-next v4 0/3] dpll: add all inputs phase offset monitor Arkadiusz Kubalewski
2025-05-23 15:42 ` Arkadiusz Kubalewski
2025-05-23 15:42 ` [Intel-wired-lan] [PATCH net-next v4 1/3] dpll: add phase-offset-monitor feature to netlink spec Arkadiusz Kubalewski
2025-05-23 15:42 ` Arkadiusz Kubalewski
2025-05-26 9:36 ` [Intel-wired-lan] " Jiri Pirko
2025-05-26 9:36 ` Jiri Pirko
2025-05-30 0:33 ` Jakub Kicinski [this message]
2025-05-30 0:33 ` Jakub Kicinski
2025-06-10 5:58 ` [Intel-wired-lan] " Kubalewski, Arkadiusz
2025-06-10 5:58 ` Kubalewski, Arkadiusz
2025-05-23 15:42 ` [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add phase_offset_monitor_get/set callback ops Arkadiusz Kubalewski
2025-05-23 15:42 ` Arkadiusz Kubalewski
2025-05-26 9:36 ` [Intel-wired-lan] " Jiri Pirko
2025-05-26 9:36 ` Jiri Pirko
2025-05-23 15:42 ` [Intel-wired-lan] [PATCH net-next v4 3/3] ice: add phase offset monitor for all PPS dpll inputs Arkadiusz Kubalewski
2025-05-23 15:42 ` Arkadiusz Kubalewski
2025-05-28 7:21 ` [Intel-wired-lan] [PATCH net-next v4 0/3] dpll: add all inputs phase offset monitor Paolo Abeni
2025-05-28 7:21 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250529173311.15fcff9b@kernel.org \
--to=kuba@kernel.org \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milena.olech@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.