Re: [PATCH] ubsan: integer-overflow: depend on BROKEN to keep this out of CI

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, May 28, 2025 at 04:00:03PM -0700, Kees Cook wrote:
> On Wed, May 28, 2025 at 02:32:23PM -0700, Nathan Chancellor wrote:
> > On Wed, May 28, 2025 at 11:26:22AM -0700, Kees Cook wrote:
> > > Depending on !COMPILE_TEST isn't sufficient to keep this feature out of
> > > CI because we can't stop it from being included in randconfig builds.
> > > This feature is still highly experimental, and is developed in lock-step
> > > with Clang's Overflow Behavior Types[1]. Depend on BROKEN to keep it
> > > from being enabled by anyone not expecting it.
> > > 
> > > Link: https://discourse.llvm.org/t/rfc-v2-clang-introduce-overflowbehaviortypes-for-wrapping-and-non-wrapping-arithmetic/86507 [1]
> > > Signed-off-by: Kees Cook <kees@kernel.org>
> > 
> > Should this have a 'Cc: stable@vger.kernel.org' on it? There might not
> > be much randconfig testing on stable but it is still very much possible
> > for some random user to turn this on and report problems.
> 
> Ah yeah, I should probably do this via a proper Fixes: tag. I'll add
> this.

Nit, "Fixes:" tags alone without a cc: stable do not guarantee they will
end up in the stable trees.  Always explicitly add a cc: please.

thanks,

greg k-h