Re: [PATCH REPOST v4 0/4] acpi: Add machine option to disable SPCR table

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, May 28, 2025 at 06:53:34PM +0800, Li Chen wrote:
> From: Li Chen <chenl311@chinatelecom.cn>
> 
> (REPOST because the previous post failed to send to qemu-devel/qemu-riscv/qemu-arm,
>  see https://lore.kernel.org/qemu-devel/1971648603b.dce1f5d22901195.6702025346547333607@linux.beauty/T/#u)
> 
> This series introduces a new machine option, spcr=on|off, allowing users
> to disable the ACPI SPCR (Serial Port Console Redirection) table.
> By default, SPCR is enabled. Disabling it can help ensure that the guest's
> console behavior is determined solely by kernel command-line parameters
> on arch like arm64, avoiding unintended serial console configurations imposed
> by firmware.
> 
> Also add tests on AArch64 and RISC-V virt machines using TCG and UEFI boot.
> 
> Changes since v3:
> - Add Reviewed-by from Sunil V L <sunilvl@ventanamicro.com> for patch 1, 3, and 4.
> - rename enable_spcr to acpi_spcr_enabled as suggested by Philippe Mathieu-Daudé.
> Changes since v2:
> - Omit UART device from DSDT and SPCR construction if no serial device is present,
> as suggested by Philippe Mathieu-Daudé.
> - Add Reviewed-by from Gavin Shan <gshan@redhat.com> for the first patch and fix style issue.
> 
> Changes since v1:
> - Add bios-tables-test for RISC-V and ARM as suggested by
> - Add Acked-by from Michael S. Tsirkin for the first patch
> - Add Reviewed-by from Bibo Mao for the first patch
> 
> Li Chen (4):
>   acpi: Add machine option to disable SPCR table
>   tests/qtest/bios-tables-test: Add test for disabling SPCR on AArch64
>   tests/qtest/bios-tables-test: Add test for disabling SPCR on RISC-V
>   acpi/virt: suppress UART device & SPCR when guest has no serial
>     hardware

Who's merging this?


>  hw/arm/virt-acpi-build.c       | 18 ++++++++-----
>  hw/core/machine.c              | 22 ++++++++++++++++
>  hw/loongarch/virt-acpi-build.c |  4 ++-
>  hw/riscv/virt-acpi-build.c     | 10 ++++++--
>  include/hw/boards.h            |  1 +
>  include/system/system.h        |  2 ++
>  qemu-options.hx                |  5 ++++
>  system/vl.c                    |  5 ++++
>  tests/qtest/bios-tables-test.c | 47 ++++++++++++++++++++++++++++++++--
>  9 files changed, 103 insertions(+), 11 deletions(-)
> 
> -- 
> 2.49.0