Re: [PATCH REPOST v4 4/4] acpi/virt: suppress UART device & SPCR when guest has no serial hardware

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Dec 11, 2025 at 08:03:05AM +0800, Li Chen wrote:
> Hi Tsirkin,
> 
>  ---- On Wed, 10 Dec 2025 20:53:01 +0800  Michael S. Tsirkin <mst@redhat.com> wrote --- 
>  > On Wed, Dec 10, 2025 at 08:23:21PM +0800, Li Chen wrote:
>  > > Hi Michael,
>  > > 
>  > >  ---- On Fri, 19 Sep 2025 07:38:56 +0800  Li Chen <me@linux.beauty> wrote --- 
>  > >  > Hi Michael,
>  > >  > 
>  > >  >  ---- On Wed, 16 Jul 2025 19:59:14 +0800  Li Chen <me@linux.beauty> wrote --- 
>  > >  >  > Hi Michael,
>  > >  >  > 
>  > >  >  >  ---- On Wed, 16 Jul 2025 19:42:42 +0800  Michael S. Tsirkin <mst@redhat.com> wrote --- 
>  > >  >  >  > On Wed, Jul 16, 2025 at 07:41:11PM +0800, Li Chen wrote:
>  > >  >  >  > > Hi Michael,
>  > >  >  >  > > 
>  > >  >  >  > > Thanks for your kind review! All issues below have been fixed in v5:
>  > >  >  >  > > https://lore.kernel.org/qemu-devel/20250716111959.404917-5-me@linux.beauty/T/#m696cee9a95646add1b74b866c3d6761aa4c5c762
>  > >  >  >  > 
>  > >  >  >  > Past soft freeze now: I tagged this but pls remind me after the release
>  > >  >  >  > to help make sure it's not lost.
>  > >  >  
>  > >  > Gentle reminder: This patch is still missing from the latest master branch, but can apply without
>  > >  > any conflict. Can it be included in 10.2?
>  > >  > 
>  > >  > Regards,
>  > >  > Li.
>  > >  > 
>  > >  > 
>  > > 
>  > > Sorry for bothering again. But I'm still unable to find this patch in the latest master branch, though it applies without conflicts now. 
>  > > 
>  > > Could it be merged now?
>  > > 
>  > > Regards,
>  > > Li​
>  > 
>  > you still need to update loongarch, I think. otherwise these tests will
>  > fail.
> 
> Yes, it seems that tap stdout is polluted by serial stdio.
> 
> I'll address the stdout pollution from -serial stdio by redirecting serial output to /dev/null using -serial null in the next version. 
> This will still create the serial device but prevent it from writing to the console.
> 
> Regards,
> 
> Li​

I don't know about that, what I meant is that loongaarch also has SPCR
so it's expected tables have to be updated.

-- 
MST