All of lore.kernel.org
 help / color / mirror / Atom feed
* include/kunit/test.h:528:17: warning: '%s' directive argument is null
@ 2025-06-02  1:16 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-06-02  1:16 UTC (permalink / raw)
  To: Ivan Orlov; +Cc: oe-kbuild-all, linux-kernel, Takashi Iwai

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   cd2e103d57e5615f9bb027d772f93b9efd567224
commit: 3e39acf56ededdebd1033349a16b704839b94b28 ALSA: core: Add sound core KUnit test
date:   1 year, 4 months ago
config: i386-buildonly-randconfig-2003-20250503 (https://download.01.org/0day-ci/archive/20250602/202506020940.5grMdmaN-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250602/202506020940.5grMdmaN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506020940.5grMdmaN-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/kunit/assert.h:13,
                    from include/kunit/test.h:12,
                    from sound/core/sound_kunit.c:7:
   sound/core/sound_kunit.c: In function 'test_card_set_id':
>> include/linux/printk.h:455:44: warning: '%s' directive argument is null [-Wformat-overflow=]
     455 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                            ^
   include/linux/printk.h:427:17: note: in definition of macro 'printk_index_wrap'
     427 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                 ^~~~~~~
   include/kunit/test.h:527:17: note: in expansion of macro 'printk'
     527 |                 printk(lvl fmt, ##__VA_ARGS__);                         \
         |                 ^~~~~~
   include/kunit/test.h:533:9: note: in expansion of macro 'kunit_log'
     533 |         kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt,         \
         |         ^~~~~~~~~
   include/kunit/test.h:546:9: note: in expansion of macro 'kunit_printk'
     546 |         kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~
   sound/core/sound_kunit.c:259:9: note: in expansion of macro 'kunit_info'
     259 |         kunit_info(test, "%s", card->id);
         |         ^~~~~~~~~~
   In file included from sound/core/sound_kunit.c:7:
>> include/kunit/test.h:528:17: warning: '%s' directive argument is null [-Wformat-overflow=]
     528 |                 kunit_log_append((test_or_suite)->log,  fmt,            \
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     529 |                                  ##__VA_ARGS__);                        \
         |                                  ~~~~~~~~~~~~~~
   include/kunit/test.h:533:9: note: in expansion of macro 'kunit_log'
     533 |         kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt,         \
         |         ^~~~~~~~~
   include/kunit/test.h:546:9: note: in expansion of macro 'kunit_printk'
     546 |         kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~
   sound/core/sound_kunit.c:259:9: note: in expansion of macro 'kunit_info'
     259 |         kunit_info(test, "%s", card->id);
         |         ^~~~~~~~~~


vim +528 include/kunit/test.h

e2219db280e3fe Alan Maguire 2020-03-26  484  
6d2426b2f258da David Gow    2021-06-24  485  /**
6d2426b2f258da David Gow    2021-06-24  486   * kunit_mark_skipped() - Marks @test_or_suite as skipped
6d2426b2f258da David Gow    2021-06-24  487   *
6d2426b2f258da David Gow    2021-06-24  488   * @test_or_suite: The test context object.
6d2426b2f258da David Gow    2021-06-24  489   * @fmt:  A printk() style format string.
6d2426b2f258da David Gow    2021-06-24  490   *
6d2426b2f258da David Gow    2021-06-24  491   * Marks the test as skipped. @fmt is given output as the test status
6d2426b2f258da David Gow    2021-06-24  492   * comment, typically the reason the test was skipped.
6d2426b2f258da David Gow    2021-06-24  493   *
6d2426b2f258da David Gow    2021-06-24  494   * Test execution continues after kunit_mark_skipped() is called.
6d2426b2f258da David Gow    2021-06-24  495   */
6d2426b2f258da David Gow    2021-06-24  496  #define kunit_mark_skipped(test_or_suite, fmt, ...)			\
6d2426b2f258da David Gow    2021-06-24  497  	do {								\
6d2426b2f258da David Gow    2021-06-24  498  		WRITE_ONCE((test_or_suite)->status, KUNIT_SKIPPED);	\
6d2426b2f258da David Gow    2021-06-24  499  		scnprintf((test_or_suite)->status_comment,		\
6d2426b2f258da David Gow    2021-06-24  500  			  KUNIT_STATUS_COMMENT_SIZE,			\
6d2426b2f258da David Gow    2021-06-24  501  			  fmt, ##__VA_ARGS__);				\
6d2426b2f258da David Gow    2021-06-24  502  	} while (0)
6d2426b2f258da David Gow    2021-06-24  503  
6d2426b2f258da David Gow    2021-06-24  504  /**
6d2426b2f258da David Gow    2021-06-24  505   * kunit_skip() - Marks @test_or_suite as skipped
6d2426b2f258da David Gow    2021-06-24  506   *
6d2426b2f258da David Gow    2021-06-24  507   * @test_or_suite: The test context object.
6d2426b2f258da David Gow    2021-06-24  508   * @fmt:  A printk() style format string.
6d2426b2f258da David Gow    2021-06-24  509   *
6d2426b2f258da David Gow    2021-06-24  510   * Skips the test. @fmt is given output as the test status
6d2426b2f258da David Gow    2021-06-24  511   * comment, typically the reason the test was skipped.
6d2426b2f258da David Gow    2021-06-24  512   *
6d2426b2f258da David Gow    2021-06-24  513   * Test execution is halted after kunit_skip() is called.
6d2426b2f258da David Gow    2021-06-24  514   */
6d2426b2f258da David Gow    2021-06-24  515  #define kunit_skip(test_or_suite, fmt, ...)				\
6d2426b2f258da David Gow    2021-06-24  516  	do {								\
6d2426b2f258da David Gow    2021-06-24  517  		kunit_mark_skipped((test_or_suite), fmt, ##__VA_ARGS__);\
6d2426b2f258da David Gow    2021-06-24  518  		kunit_try_catch_throw(&((test_or_suite)->try_catch));	\
6d2426b2f258da David Gow    2021-06-24  519  	} while (0)
e2219db280e3fe Alan Maguire 2020-03-26  520  
e2219db280e3fe Alan Maguire 2020-03-26  521  /*
e2219db280e3fe Alan Maguire 2020-03-26  522   * printk and log to per-test or per-suite log buffer.  Logging only done
e2219db280e3fe Alan Maguire 2020-03-26  523   * if CONFIG_KUNIT_DEBUGFS is 'y'; if it is 'n', no log is allocated/used.
e2219db280e3fe Alan Maguire 2020-03-26  524   */
e2219db280e3fe Alan Maguire 2020-03-26  525  #define kunit_log(lvl, test_or_suite, fmt, ...)				\
e2219db280e3fe Alan Maguire 2020-03-26  526  	do {								\
e2219db280e3fe Alan Maguire 2020-03-26  527  		printk(lvl fmt, ##__VA_ARGS__);				\
2c6a96dad5797e Rae Moar     2023-03-08 @528  		kunit_log_append((test_or_suite)->log,	fmt,		\
e2219db280e3fe Alan Maguire 2020-03-26  529  				 ##__VA_ARGS__);			\
e2219db280e3fe Alan Maguire 2020-03-26  530  	} while (0)
e2219db280e3fe Alan Maguire 2020-03-26  531  

:::::: The code at line 528 was first introduced by commit
:::::: 2c6a96dad5797e57b4cf04101d6c8d5c7a571603 kunit: fix bug of extra newline characters in debugfs logs

:::::: TO: Rae Moar <rmoar@google.com>
:::::: CC: Shuah Khan <skhan@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-06-02  1:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-02  1:16 include/kunit/test.h:528:17: warning: '%s' directive argument is null kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.