* [PATCH] Remove unaligned/packed_struct.h header
@ 2025-06-03 13:24 Julian Vetter
2025-06-03 14:29 ` Al Viro
2025-06-03 15:40 ` Christophe Leroy
0 siblings, 2 replies; 4+ messages in thread
From: Julian Vetter @ 2025-06-03 13:24 UTC (permalink / raw)
To: Arnd Bergmann, Jason A . Donenfeld, Christophe Leroy, Al Viro
Cc: linux-kernel, Julian Vetter
The functions in this header are deprecated and are not used anymore.
So, remove the header entirely.
Signed-off-by: Julian Vetter <julian@outer-limits.org>
---
include/linux/unaligned.h | 1 -
include/linux/unaligned/packed_struct.h | 46 -------------------------
2 files changed, 47 deletions(-)
delete mode 100644 include/linux/unaligned/packed_struct.h
diff --git a/include/linux/unaligned.h b/include/linux/unaligned.h
index 4a9651017e3c..18c4b0c00e2a 100644
--- a/include/linux/unaligned.h
+++ b/include/linux/unaligned.h
@@ -6,7 +6,6 @@
* This is the most generic implementation of unaligned accesses
* and should work almost anywhere.
*/
-#include <linux/unaligned/packed_struct.h>
#include <asm/byteorder.h>
#include <vdso/unaligned.h>
diff --git a/include/linux/unaligned/packed_struct.h b/include/linux/unaligned/packed_struct.h
deleted file mode 100644
index f4c8eaf4d012..000000000000
--- a/include/linux/unaligned/packed_struct.h
+++ /dev/null
@@ -1,46 +0,0 @@
-#ifndef _LINUX_UNALIGNED_PACKED_STRUCT_H
-#define _LINUX_UNALIGNED_PACKED_STRUCT_H
-
-#include <linux/types.h>
-
-struct __una_u16 { u16 x; } __packed;
-struct __una_u32 { u32 x; } __packed;
-struct __una_u64 { u64 x; } __packed;
-
-static inline u16 __get_unaligned_cpu16(const void *p)
-{
- const struct __una_u16 *ptr = (const struct __una_u16 *)p;
- return ptr->x;
-}
-
-static inline u32 __get_unaligned_cpu32(const void *p)
-{
- const struct __una_u32 *ptr = (const struct __una_u32 *)p;
- return ptr->x;
-}
-
-static inline u64 __get_unaligned_cpu64(const void *p)
-{
- const struct __una_u64 *ptr = (const struct __una_u64 *)p;
- return ptr->x;
-}
-
-static inline void __put_unaligned_cpu16(u16 val, void *p)
-{
- struct __una_u16 *ptr = (struct __una_u16 *)p;
- ptr->x = val;
-}
-
-static inline void __put_unaligned_cpu32(u32 val, void *p)
-{
- struct __una_u32 *ptr = (struct __una_u32 *)p;
- ptr->x = val;
-}
-
-static inline void __put_unaligned_cpu64(u64 val, void *p)
-{
- struct __una_u64 *ptr = (struct __una_u64 *)p;
- ptr->x = val;
-}
-
-#endif /* _LINUX_UNALIGNED_PACKED_STRUCT_H */
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Remove unaligned/packed_struct.h header
2025-06-03 13:24 [PATCH] Remove unaligned/packed_struct.h header Julian Vetter
@ 2025-06-03 14:29 ` Al Viro
2025-06-10 9:03 ` Julian Vetter
2025-06-03 15:40 ` Christophe Leroy
1 sibling, 1 reply; 4+ messages in thread
From: Al Viro @ 2025-06-03 14:29 UTC (permalink / raw)
To: Julian Vetter
Cc: Arnd Bergmann, Jason A . Donenfeld, Christophe Leroy,
linux-kernel
On Tue, Jun 03, 2025 at 03:24:14PM +0200, Julian Vetter wrote:
> The functions in this header are deprecated and are not used anymore.
> So, remove the header entirely.
; git grep -n __get_unaligned_cpu32
include/linux/jhash.h:80: a += __get_unaligned_cpu32(k);
include/linux/jhash.h:81: b += __get_unaligned_cpu32(k + 4);
include/linux/jhash.h:82: c += __get_unaligned_cpu32(k + 8);
include/linux/unaligned/packed_struct.h:16:static inline u32 __get_unaligned_cpu32(const void *p)
tools/include/linux/jhash.h:80: a += __get_unaligned_cpu32(k);
tools/include/linux/jhash.h:81: b += __get_unaligned_cpu32(k + 4);
tools/include/linux/jhash.h:82: c += __get_unaligned_cpu32(k + 8);
tools/include/linux/unaligned/packed_struct.h:17:static inline u32 __get_unaligned_cpu32(const void *p)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unaligned/packed_struct.h header
2025-06-03 14:29 ` Al Viro
@ 2025-06-10 9:03 ` Julian Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Julian Vetter @ 2025-06-10 9:03 UTC (permalink / raw)
To: Al Viro; +Cc: Arnd Bergmann, Jason A . Donenfeld, Christophe Leroy,
linux-kernel
On 6/3/25 16:29, Al Viro wrote:
> On Tue, Jun 03, 2025 at 03:24:14PM +0200, Julian Vetter wrote:
>> The functions in this header are deprecated and are not used anymore.
>> So, remove the header entirely.
>
Yes, sorry. I messed it up. For now the patch can be ignored. I will
re-send it once, all appearances of '__get_unaligned_cpu32' are removed.
I have already send according patches for the 2 remaining files that
still use it, namely 'include/linux/jhash.h' and
'tools/include/linux/jhash.h'.
Sorry again.
> ; git grep -n __get_unaligned_cpu32
> include/linux/jhash.h:80: a += __get_unaligned_cpu32(k);
> include/linux/jhash.h:81: b += __get_unaligned_cpu32(k + 4);
> include/linux/jhash.h:82: c += __get_unaligned_cpu32(k + 8);
> include/linux/unaligned/packed_struct.h:16:static inline u32 __get_unaligned_cpu32(const void *p)
> tools/include/linux/jhash.h:80: a += __get_unaligned_cpu32(k);
> tools/include/linux/jhash.h:81: b += __get_unaligned_cpu32(k + 4);
> tools/include/linux/jhash.h:82: c += __get_unaligned_cpu32(k + 8);
> tools/include/linux/unaligned/packed_struct.h:17:static inline u32 __get_unaligned_cpu32(const void *p)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove unaligned/packed_struct.h header
2025-06-03 13:24 [PATCH] Remove unaligned/packed_struct.h header Julian Vetter
2025-06-03 14:29 ` Al Viro
@ 2025-06-03 15:40 ` Christophe Leroy
1 sibling, 0 replies; 4+ messages in thread
From: Christophe Leroy @ 2025-06-03 15:40 UTC (permalink / raw)
To: Julian Vetter, Arnd Bergmann, Jason A . Donenfeld, Al Viro; +Cc: linux-kernel
Le 03/06/2025 à 15:24, Julian Vetter a écrit :
> The functions in this header are deprecated and are not used anymore.
> So, remove the header entirely.
Your patch seems uncomplete.
$ git grep get_unaligned_cpu linus/master
linus/master:include/linux/jhash.h: a +=
__get_unaligned_cpu32(k);
linus/master:include/linux/jhash.h: b +=
__get_unaligned_cpu32(k + 4);
linus/master:include/linux/jhash.h: c +=
__get_unaligned_cpu32(k + 8);
linus/master:include/linux/unaligned/packed_struct.h:static inline u16
__get_unaligned_cpu16(const void *p)
linus/master:include/linux/unaligned/packed_struct.h:static inline u32
__get_unaligned_cpu32(const void *p)
linus/master:include/linux/unaligned/packed_struct.h:static inline u64
__get_unaligned_cpu64(const void *p)
linus/master:tools/include/linux/jhash.h: a +=
__get_unaligned_cpu32(k);
linus/master:tools/include/linux/jhash.h: b +=
__get_unaligned_cpu32(k + 4);
linus/master:tools/include/linux/jhash.h: c +=
__get_unaligned_cpu32(k + 8);
linus/master:tools/include/linux/unaligned/packed_struct.h:static inline
u16 __get_unaligned_cpu16(const void *p)
linus/master:tools/include/linux/unaligned/packed_struct.h:static inline
u32 __get_unaligned_cpu32(const void *p)
linus/master:tools/include/linux/unaligned/packed_struct.h:static inline
u64 __get_unaligned_cpu64(const void *p)
Christophe
>
> Signed-off-by: Julian Vetter <julian@outer-limits.org>
> ---
> include/linux/unaligned.h | 1 -
> include/linux/unaligned/packed_struct.h | 46 -------------------------
> 2 files changed, 47 deletions(-)
> delete mode 100644 include/linux/unaligned/packed_struct.h
>
> diff --git a/include/linux/unaligned.h b/include/linux/unaligned.h
> index 4a9651017e3c..18c4b0c00e2a 100644
> --- a/include/linux/unaligned.h
> +++ b/include/linux/unaligned.h
> @@ -6,7 +6,6 @@
> * This is the most generic implementation of unaligned accesses
> * and should work almost anywhere.
> */
> -#include <linux/unaligned/packed_struct.h>
> #include <asm/byteorder.h>
> #include <vdso/unaligned.h>
>
> diff --git a/include/linux/unaligned/packed_struct.h b/include/linux/unaligned/packed_struct.h
> deleted file mode 100644
> index f4c8eaf4d012..000000000000
> --- a/include/linux/unaligned/packed_struct.h
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -#ifndef _LINUX_UNALIGNED_PACKED_STRUCT_H
> -#define _LINUX_UNALIGNED_PACKED_STRUCT_H
> -
> -#include <linux/types.h>
> -
> -struct __una_u16 { u16 x; } __packed;
> -struct __una_u32 { u32 x; } __packed;
> -struct __una_u64 { u64 x; } __packed;
> -
> -static inline u16 __get_unaligned_cpu16(const void *p)
> -{
> - const struct __una_u16 *ptr = (const struct __una_u16 *)p;
> - return ptr->x;
> -}
> -
> -static inline u32 __get_unaligned_cpu32(const void *p)
> -{
> - const struct __una_u32 *ptr = (const struct __una_u32 *)p;
> - return ptr->x;
> -}
> -
> -static inline u64 __get_unaligned_cpu64(const void *p)
> -{
> - const struct __una_u64 *ptr = (const struct __una_u64 *)p;
> - return ptr->x;
> -}
> -
> -static inline void __put_unaligned_cpu16(u16 val, void *p)
> -{
> - struct __una_u16 *ptr = (struct __una_u16 *)p;
> - ptr->x = val;
> -}
> -
> -static inline void __put_unaligned_cpu32(u32 val, void *p)
> -{
> - struct __una_u32 *ptr = (struct __una_u32 *)p;
> - ptr->x = val;
> -}
> -
> -static inline void __put_unaligned_cpu64(u64 val, void *p)
> -{
> - struct __una_u64 *ptr = (struct __una_u64 *)p;
> - ptr->x = val;
> -}
> -
> -#endif /* _LINUX_UNALIGNED_PACKED_STRUCT_H */
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-10 9:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-03 13:24 [PATCH] Remove unaligned/packed_struct.h header Julian Vetter
2025-06-03 14:29 ` Al Viro
2025-06-10 9:03 ` Julian Vetter
2025-06-03 15:40 ` Christophe Leroy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.