From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/2] media: i2c: ds90ub960: Add support for DS90UB954-Q1
Date: Wed, 4 Jun 2025 23:45:10 +0800 [thread overview]
Message-ID: <202506042333.FlFAp4mW-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250523083655.3876005-3-y-abhilashchandra@ti.com>
References: <20250523083655.3876005-3-y-abhilashchandra@ti.com>
TO: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
TO: tomi.valkeinen@ideasonboard.com
TO: mchehab@kernel.org
TO: robh@kernel.org
TO: krzk+dt@kernel.org
TO: conor+dt@kernel.org
CC: hverkuil@xs4all.nl
CC: sakari.ailus@linux.intel.com
CC: laurent.pinchart@ideasonboard.com
CC: vaishnav.a@ti.com
CC: u-kumar1@ti.com
CC: jai.luthra@linux.dev
CC: linux-media@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: y-abhilashchandra@ti.com
Hi Yemike,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linuxtv-media-pending/master]
[also build test WARNING on linus/master next-20250604]
[cannot apply to robh/for-next v6.15]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yemike-Abhilash-Chandra/media-dt-bindings-ti-ds90ub960-Add-bindings-for-DS90UB954-Q1/20250523-164041
base: https://git.linuxtv.org/media-ci/media-pending.git master
patch link: https://lore.kernel.org/r/20250523083655.3876005-3-y-abhilashchandra%40ti.com
patch subject: [PATCH 2/2] media: i2c: ds90ub960: Add support for DS90UB954-Q1
:::::: branch date: 12 days ago
:::::: commit date: 12 days ago
config: arc-randconfig-r071-20250604 (https://download.01.org/0day-ci/archive/20250604/202506042333.FlFAp4mW-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202506042333.FlFAp4mW-lkp@intel.com/
smatch warnings:
drivers/media/i2c/ds90ub960.c:5046 ub960_enable_core_hw() error: uninitialized symbol 'refclk_freq'.
vim +/refclk_freq +5046 drivers/media/i2c/ds90ub960.c
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4980
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4981 static int ub960_enable_core_hw(struct ub960_data *priv)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4982 {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4983 struct device *dev = &priv->client->dev;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4984 u8 rev_mask;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4985 int ret;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4986 u8 dev_sts;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4987 u8 refclk_freq;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4988
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4989 ret = regulator_enable(priv->vddio);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4990 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4991 return dev_err_probe(dev, ret,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4992 "failed to enable VDDIO regulator\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4993
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4994 ret = clk_prepare_enable(priv->refclk);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4995 if (ret) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4996 dev_err_probe(dev, ret, "Failed to enable refclk\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4997 goto err_disable_vddio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4998 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4999
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5000 if (priv->pd_gpio) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5001 gpiod_set_value_cansleep(priv->pd_gpio, 1);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5002 /* wait min 2 ms for reset to complete */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5003 fsleep(2000);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5004 gpiod_set_value_cansleep(priv->pd_gpio, 0);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5005 /* wait min 2 ms for power up to finish */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5006 fsleep(2000);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5007 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5008
8f512c3113756c Tomi Valkeinen 2025-03-03 5009 ret = ub960_reset(priv, true);
8f512c3113756c Tomi Valkeinen 2025-03-03 5010 if (ret)
8f512c3113756c Tomi Valkeinen 2025-03-03 5011 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5012
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5013 /* Runtime check register accessibility */
24868501a74402 Tomi Valkeinen 2025-03-03 5014 ret = ub960_read(priv, UB960_SR_REV_MASK, &rev_mask, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5015 if (ret) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5016 dev_err_probe(dev, ret, "Cannot read first register, abort\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5017 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5018 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5019
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5020 dev_dbg(dev, "Found %s (rev/mask %#04x)\n", priv->hw_data->model,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5021 rev_mask);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5022
24868501a74402 Tomi Valkeinen 2025-03-03 5023 ret = ub960_read(priv, UB960_SR_DEVICE_STS, &dev_sts, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5024 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5025 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5026
ba3bdb93947c90 Tomi Valkeinen 2024-12-06 5027 if (priv->hw_data->is_ub9702)
24868501a74402 Tomi Valkeinen 2025-03-03 5028 ret = ub960_read(priv, UB9702_SR_REFCLK_FREQ, &refclk_freq,
24868501a74402 Tomi Valkeinen 2025-03-03 5029 NULL);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5030 else if (priv->hw_data->is_ub954) {
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5031 /* From DS90UB954-Q1 datasheet:
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5032 * "REFCLK_FREQ measurement is not synchronized. Value in this
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5033 * register should read twice and only considered valid if
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5034 * REFCLK_FREQ is unchanged between reads."
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5035 */
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5036 unsigned long timeout = jiffies + msecs_to_jiffies(100);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5037
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5038 do {
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5039 u8 refclk_new;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5040
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5041 ret = ub960_read(priv, UB960_XR_REFCLK_FREQ, &refclk_new,
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5042 NULL);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5043 if (ret)
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5044 goto err_pd_gpio;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5045
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 @5046 if (refclk_new == refclk_freq)
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5047 break;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5048 refclk_freq = refclk_new;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5049 } while (time_before(jiffies, timeout));
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5050 }
ba3bdb93947c90 Tomi Valkeinen 2024-12-06 5051 else
24868501a74402 Tomi Valkeinen 2025-03-03 5052 ret = ub960_read(priv, UB960_XR_REFCLK_FREQ, &refclk_freq,
24868501a74402 Tomi Valkeinen 2025-03-03 5053 NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5054 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5055 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5056
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5057 dev_dbg(dev, "refclk valid %u freq %u MHz (clk fw freq %lu MHz)\n",
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5058 !!(dev_sts & BIT(4)), refclk_freq,
a56fac44beced4 Tomi Valkeinen 2024-12-06 5059 clk_get_rate(priv->refclk) / HZ_PER_MHZ);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5060
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5061 /* Disable all RX ports by default */
24868501a74402 Tomi Valkeinen 2025-03-03 5062 ret = ub960_write(priv, UB960_SR_RX_PORT_CTL, 0, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5063 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5064 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5065
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5066 /* release GPIO lock */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5067 if (priv->hw_data->is_ub9702) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5068 ret = ub960_update_bits(priv, UB960_SR_RESET,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5069 UB960_SR_RESET_GPIO_LOCK_RELEASE,
24868501a74402 Tomi Valkeinen 2025-03-03 5070 UB960_SR_RESET_GPIO_LOCK_RELEASE,
24868501a74402 Tomi Valkeinen 2025-03-03 5071 NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5072 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5073 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5074 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5075
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5076 return 0;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5077
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5078 err_pd_gpio:
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5079 gpiod_set_value_cansleep(priv->pd_gpio, 1);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5080 clk_disable_unprepare(priv->refclk);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5081 err_disable_vddio:
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5082 regulator_disable(priv->vddio);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5083
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5084 return ret;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5085 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5086
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com
Subject: Re: [PATCH 2/2] media: i2c: ds90ub960: Add support for DS90UB954-Q1
Date: Wed, 4 Jun 2025 19:42:14 +0300 [thread overview]
Message-ID: <202506042333.FlFAp4mW-lkp@intel.com> (raw)
Message-ID: <20250604164214.gwmLcTDRVbfFP1Nj5jJddwZt7F4khAppPxzsbW45Saw@z> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250523083655.3876005-3-y-abhilashchandra@ti.com>
References: <20250523083655.3876005-3-y-abhilashchandra@ti.com>
TO: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
TO: tomi.valkeinen@ideasonboard.com
TO: mchehab@kernel.org
TO: robh@kernel.org
TO: krzk+dt@kernel.org
TO: conor+dt@kernel.org
CC: hverkuil@xs4all.nl
CC: sakari.ailus@linux.intel.com
CC: laurent.pinchart@ideasonboard.com
CC: vaishnav.a@ti.com
CC: u-kumar1@ti.com
CC: jai.luthra@linux.dev
CC: linux-media@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: y-abhilashchandra@ti.com
Hi Yemike,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yemike-Abhilash-Chandra/media-dt-bindings-ti-ds90ub960-Add-bindings-for-DS90UB954-Q1/20250523-164041
base: https://git.linuxtv.org/media-ci/media-pending.git master
patch link: https://lore.kernel.org/r/20250523083655.3876005-3-y-abhilashchandra%40ti.com
patch subject: [PATCH 2/2] media: i2c: ds90ub960: Add support for DS90UB954-Q1
config: arc-randconfig-r071-20250604 (https://download.01.org/0day-ci/archive/20250604/202506042333.FlFAp4mW-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202506042333.FlFAp4mW-lkp@intel.com/
smatch warnings:
drivers/media/i2c/ds90ub960.c:5046 ub960_enable_core_hw() error: uninitialized symbol 'refclk_freq'.
vim +/refclk_freq +5046 drivers/media/i2c/ds90ub960.c
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4981 static int ub960_enable_core_hw(struct ub960_data *priv)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4982 {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4983 struct device *dev = &priv->client->dev;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4984 u8 rev_mask;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4985 int ret;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4986 u8 dev_sts;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4987 u8 refclk_freq;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4988
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4989 ret = regulator_enable(priv->vddio);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4990 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4991 return dev_err_probe(dev, ret,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4992 "failed to enable VDDIO regulator\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4993
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4994 ret = clk_prepare_enable(priv->refclk);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4995 if (ret) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4996 dev_err_probe(dev, ret, "Failed to enable refclk\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4997 goto err_disable_vddio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4998 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 4999
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5000 if (priv->pd_gpio) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5001 gpiod_set_value_cansleep(priv->pd_gpio, 1);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5002 /* wait min 2 ms for reset to complete */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5003 fsleep(2000);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5004 gpiod_set_value_cansleep(priv->pd_gpio, 0);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5005 /* wait min 2 ms for power up to finish */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5006 fsleep(2000);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5007 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5008
8f512c3113756c Tomi Valkeinen 2025-03-03 5009 ret = ub960_reset(priv, true);
8f512c3113756c Tomi Valkeinen 2025-03-03 5010 if (ret)
8f512c3113756c Tomi Valkeinen 2025-03-03 5011 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5012
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5013 /* Runtime check register accessibility */
24868501a74402 Tomi Valkeinen 2025-03-03 5014 ret = ub960_read(priv, UB960_SR_REV_MASK, &rev_mask, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5015 if (ret) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5016 dev_err_probe(dev, ret, "Cannot read first register, abort\n");
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5017 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5018 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5019
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5020 dev_dbg(dev, "Found %s (rev/mask %#04x)\n", priv->hw_data->model,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5021 rev_mask);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5022
24868501a74402 Tomi Valkeinen 2025-03-03 5023 ret = ub960_read(priv, UB960_SR_DEVICE_STS, &dev_sts, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5024 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5025 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5026
ba3bdb93947c90 Tomi Valkeinen 2024-12-06 5027 if (priv->hw_data->is_ub9702)
24868501a74402 Tomi Valkeinen 2025-03-03 5028 ret = ub960_read(priv, UB9702_SR_REFCLK_FREQ, &refclk_freq,
24868501a74402 Tomi Valkeinen 2025-03-03 5029 NULL);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5030 else if (priv->hw_data->is_ub954) {
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5031 /* From DS90UB954-Q1 datasheet:
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5032 * "REFCLK_FREQ measurement is not synchronized. Value in this
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5033 * register should read twice and only considered valid if
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5034 * REFCLK_FREQ is unchanged between reads."
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5035 */
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5036 unsigned long timeout = jiffies + msecs_to_jiffies(100);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5037
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5038 do {
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5039 u8 refclk_new;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5040
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5041 ret = ub960_read(priv, UB960_XR_REFCLK_FREQ, &refclk_new,
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5042 NULL);
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5043 if (ret)
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5044 goto err_pd_gpio;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5045
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 @5046 if (refclk_new == refclk_freq)
^^^^^^^^^^^
This is uninitialized on the first iteration.
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5047 break;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5048 refclk_freq = refclk_new;
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5049 } while (time_before(jiffies, timeout));
8a8ba5651f9d39 Yemike Abhilash Chandra 2025-05-23 5050 }
ba3bdb93947c90 Tomi Valkeinen 2024-12-06 5051 else
24868501a74402 Tomi Valkeinen 2025-03-03 5052 ret = ub960_read(priv, UB960_XR_REFCLK_FREQ, &refclk_freq,
24868501a74402 Tomi Valkeinen 2025-03-03 5053 NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5054 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5055 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5056
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5057 dev_dbg(dev, "refclk valid %u freq %u MHz (clk fw freq %lu MHz)\n",
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5058 !!(dev_sts & BIT(4)), refclk_freq,
a56fac44beced4 Tomi Valkeinen 2024-12-06 5059 clk_get_rate(priv->refclk) / HZ_PER_MHZ);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5060
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5061 /* Disable all RX ports by default */
24868501a74402 Tomi Valkeinen 2025-03-03 5062 ret = ub960_write(priv, UB960_SR_RX_PORT_CTL, 0, NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5063 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5064 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5065
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5066 /* release GPIO lock */
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5067 if (priv->hw_data->is_ub9702) {
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5068 ret = ub960_update_bits(priv, UB960_SR_RESET,
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5069 UB960_SR_RESET_GPIO_LOCK_RELEASE,
24868501a74402 Tomi Valkeinen 2025-03-03 5070 UB960_SR_RESET_GPIO_LOCK_RELEASE,
24868501a74402 Tomi Valkeinen 2025-03-03 5071 NULL);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5072 if (ret)
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5073 goto err_pd_gpio;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5074 }
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5075
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5076 return 0;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5077
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5078 err_pd_gpio:
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5079 gpiod_set_value_cansleep(priv->pd_gpio, 1);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5080 clk_disable_unprepare(priv->refclk);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5081 err_disable_vddio:
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5082 regulator_disable(priv->vddio);
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5083
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5084 return ret;
afe267f2d368f5 Tomi Valkeinen 2023-06-19 5085 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-06-04 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 15:45 kernel test robot [this message]
2025-06-04 16:42 ` [PATCH 2/2] media: i2c: ds90ub960: Add support for DS90UB954-Q1 Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2025-05-23 8:36 [PATCH 0/2] " Yemike Abhilash Chandra
2025-05-23 8:36 ` [PATCH 2/2] media: i2c: ds90ub960: " Yemike Abhilash Chandra
2025-05-23 16:53 ` Jai Luthra
2025-05-26 6:24 ` Yemike Abhilash Chandra
2025-05-27 5:40 ` Tomi Valkeinen
2025-05-28 6:25 ` Yemike Abhilash Chandra
2025-06-02 7:16 ` Tomi Valkeinen
2025-06-02 10:54 ` Yemike Abhilash Chandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202506042333.FlFAp4mW-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.