All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: GSM size should be constant on most platforms
@ 2025-06-05 22:53 Matt Roper
  2025-06-06  1:45 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Matt Roper @ 2025-06-05 22:53 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

On old Intel platforms, the size of the GSM (i.e., the stolen memory
that holds the GGTT page table entries) could vary, so the driver needed
to read the actual size from the PCI config space.  However from Xe_HP
onward, the GSM is now always guaranteed to be exactly 8MB (which
translates to a 4GB GGTT address space); this is always true regardless
of what the platform's much larger PPGTT address space is.

The bspec doesn't document the PCI config space as being a valid way to
query the size of the GSM after Xe_LP platforms, although so far it
still seems to be giving us proper values for Xe_HP, Xe2, and Xe3.
However we suspect that the config space will stop providing correct
values on some upcoming platforms, so we should stop relying on it.
Instead just use the hardcoded 8MB value as documented elsewhere in the
bspec.

Bspec: 49636, 67090, 50589
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_ggtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_ggtt.c b/drivers/gpu/drm/xe/xe_ggtt.c
index b9a0fd5ccaba..3c811f6e79c9 100644
--- a/drivers/gpu/drm/xe/xe_ggtt.c
+++ b/drivers/gpu/drm/xe/xe_ggtt.c
@@ -219,7 +219,7 @@ int xe_ggtt_init_early(struct xe_ggtt *ggtt)
 	unsigned int gsm_size;
 	int err;
 
-	if (IS_SRIOV_VF(xe))
+	if (IS_SRIOV_VF(xe) || GRAPHICS_VERx100(xe) >= 1250)
 		gsm_size = SZ_8M; /* GGTT is expected to be 4GiB */
 	else
 		gsm_size = probe_gsm_size(pdev);
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-06-09 16:07 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-05 22:53 [PATCH] drm/xe: GSM size should be constant on most platforms Matt Roper
2025-06-06  1:45 ` ✓ CI.Patch_applied: success for " Patchwork
2025-06-06  1:46 ` ✓ CI.checkpatch: " Patchwork
2025-06-06  1:47 ` ✓ CI.KUnit: " Patchwork
2025-06-06  1:57 ` ✓ CI.Build: " Patchwork
2025-06-06  2:00 ` ✓ CI.Hooks: " Patchwork
2025-06-06  2:01 ` ✓ CI.checksparse: " Patchwork
2025-06-06  2:39 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-06 13:02 ` [PATCH] " Gustavo Sousa
2025-06-08  7:08 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-06-09 16:06   ` Matt Roper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.