[PATCH] Decrease `AcpiExTracePoint` verbosity

[PATCH] Decrease `AcpiExTracePoint` verbosity

[Mario Limonciello]

From: Mario Limonciello <mario.limonciello@amd.com>

Early in kernel boot pointers can't be used and so %p shows up
incorrectly:

```
extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
```

Later in the boot %p works, but it's not really actually useful when
the pathname can resolve properly. Adjust the debug print so that if
the Pathname resolves that the pointer isn't also printed:

```
extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
```

Link: https://github.com/acpica/acpica/pull/1013
Link: https://github.com/acpica/acpica/commit/bdc2a4e646f097b693aa60f1f2c4228d1e31b0d1
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/acpica/extrace.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/acpica/extrace.c b/drivers/acpi/acpica/extrace.c
index d34497f3576a4..36934d4f26fb4 100644
--- a/drivers/acpi/acpica/extrace.c
+++ b/drivers/acpi/acpica/extrace.c
@@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
 
 	if (pathname) {
 		ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
-				  "%s %s [0x%p:%s] execution.\n",
+				  "%s %s [%s] execution.\n",
 				  acpi_ex_get_trace_event_name(type),
-				  begin ? "Begin" : "End", aml, pathname));
+				  begin ? "Begin" : "End", pathname));
 	} else {
 		ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
 				  "%s %s [0x%p] execution.\n",
-- 
2.43.0

Re: [PATCH] Decrease `AcpiExTracePoint` verbosity

[Rafael J. Wysocki]

On Mon, Jun 9, 2025 at 5:29 AM Mario Limonciello <superm1@kernel.org> wrote:
>
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> Early in kernel boot pointers can't be used and so %p shows up
> incorrectly:
>
> ```
> extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
> ```
>
> Later in the boot %p works, but it's not really actually useful when
> the pathname can resolve properly. Adjust the debug print so that if
> the Pathname resolves that the pointer isn't also printed:
>
> ```
> extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
> ```
>
> Link: https://github.com/acpica/acpica/pull/1013
> Link: https://github.com/acpica/acpica/commit/bdc2a4e646f097b693aa60f1f2c4228d1e31b0d1
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

This is an ACPICA change, so it should be made upstream first unless
there is a good enough reason to make it directly in Linux.  In which
case that reason should be mentioned in the changelog.

> ---
>  drivers/acpi/acpica/extrace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/extrace.c b/drivers/acpi/acpica/extrace.c
> index d34497f3576a4..36934d4f26fb4 100644
> --- a/drivers/acpi/acpica/extrace.c
> +++ b/drivers/acpi/acpica/extrace.c
> @@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
>
>         if (pathname) {
>                 ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
> -                                 "%s %s [0x%p:%s] execution.\n",
> +                                 "%s %s [%s] execution.\n",
>                                   acpi_ex_get_trace_event_name(type),
> -                                 begin ? "Begin" : "End", aml, pathname));
> +                                 begin ? "Begin" : "End", pathname));
>         } else {
>                 ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
>                                   "%s %s [0x%p] execution.\n",
> --
> 2.43.0
>
>

Re: [PATCH] Decrease `AcpiExTracePoint` verbosity

[Mario Limonciello]

On 6/9/2025 4:31 AM, Rafael J. Wysocki wrote:
> On Mon, Jun 9, 2025 at 5:29 AM Mario Limonciello <superm1@kernel.org> wrote:
>>
>> From: Mario Limonciello <mario.limonciello@amd.com>
>>
>> Early in kernel boot pointers can't be used and so %p shows up
>> incorrectly:
>>
>> ```
>> extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
>> ```
>>
>> Later in the boot %p works, but it's not really actually useful when
>> the pathname can resolve properly. Adjust the debug print so that if
>> the Pathname resolves that the pointer isn't also printed:
>>
>> ```
>> extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
>> ```
>>
>> Link: https://github.com/acpica/acpica/pull/1013
>> Link: https://github.com/acpica/acpica/commit/bdc2a4e646f097b693aa60f1f2c4228d1e31b0d1
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> This is an ACPICA change, so it should be made upstream first unless
> there is a good enough reason to make it directly in Linux.  In which
> case that reason should be mentioned in the changelog.

The patches were from ACPICA (I included the links above).  I wasn't 
sure if it needed to be a manual application here or if you'll do it the 
next cycle.  If you're going to automatically do it then we can 
disregard this patch for now.

> 
>> ---
>>   drivers/acpi/acpica/extrace.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/acpi/acpica/extrace.c b/drivers/acpi/acpica/extrace.c
>> index d34497f3576a4..36934d4f26fb4 100644
>> --- a/drivers/acpi/acpica/extrace.c
>> +++ b/drivers/acpi/acpica/extrace.c
>> @@ -136,9 +136,9 @@ acpi_ex_trace_point(acpi_trace_event_type type,
>>
>>          if (pathname) {
>>                  ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
>> -                                 "%s %s [0x%p:%s] execution.\n",
>> +                                 "%s %s [%s] execution.\n",
>>                                    acpi_ex_get_trace_event_name(type),
>> -                                 begin ? "Begin" : "End", aml, pathname));
>> +                                 begin ? "Begin" : "End", pathname));
>>          } else {
>>                  ACPI_DEBUG_PRINT((ACPI_DB_TRACE_POINT,
>>                                    "%s %s [0x%p] execution.\n",
>> --
>> 2.43.0
>>
>>

Re: [PATCH] Decrease `AcpiExTracePoint` verbosity

[Rafael J. Wysocki]

On Mon, Jun 9, 2025 at 2:48 PM Mario Limonciello <superm1@kernel.org> wrote:
>
> On 6/9/2025 4:31 AM, Rafael J. Wysocki wrote:
> > On Mon, Jun 9, 2025 at 5:29 AM Mario Limonciello <superm1@kernel.org> wrote:
> >>
> >> From: Mario Limonciello <mario.limonciello@amd.com>
> >>
> >> Early in kernel boot pointers can't be used and so %p shows up
> >> incorrectly:
> >>
> >> ```
> >> extrace-0138 ex_trace_point        : Method Begin [0x(____ptrval____):\M460] execution.
> >> ```
> >>
> >> Later in the boot %p works, but it's not really actually useful when
> >> the pathname can resolve properly. Adjust the debug print so that if
> >> the Pathname resolves that the pointer isn't also printed:
> >>
> >> ```
> >> extrace-0138 ex_trace_point        : Method Begin [\M460] execution.
> >> ```
> >>
> >> Link: https://github.com/acpica/acpica/pull/1013
> >> Link: https://github.com/acpica/acpica/commit/bdc2a4e646f097b693aa60f1f2c4228d1e31b0d1
> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > This is an ACPICA change, so it should be made upstream first unless
> > there is a good enough reason to make it directly in Linux.  In which
> > case that reason should be mentioned in the changelog.
>
> The patches were from ACPICA (I included the links above).

OK, applied as 6.17 material, thanks!