Re: [PATCH 2/2] iio: dummy: Drop unused export.h include.

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Mon, 9 Jun 2025 12:27:33 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Mon, Jun 9, 2025 at 10:06 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Resolves:
> >   warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present  
> 
> While this true...
> 
> >  #include <linux/kernel.h>  
> 
> ...I prefer a full and not half-baked solution, i.e. revisiting all
> headers and esp. replacing kernel.h with what is used.
> 
> > -#include <linux/export.h>
> >  #include <linux/slab.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/irq.h>  
> 
> While doing that, the headers may be sorted (in the same or preparatory patch).
> 

Whilst I agree that more work is need, I also don't like the time it might
take to get to it and the warnings that might mean more significant issues get
missed in the wash in the meantime.

Jonathan