Re: [PATCH 2/2] iio: dummy: Drop unused export.h include.

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Wed, Jun 11, 2025 at 05:32:17PM +0100, Jonathan Cameron wrote:
> On Mon, 9 Jun 2025 10:39:05 +0100
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> > On Mon, 9 Jun 2025 12:27:33 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > > On Mon, Jun 9, 2025 at 10:06 AM Jonathan Cameron <jic23@kernel.org> wrote:  
> > > >

> > > > Resolves:
> > > >   warning: EXPORT_SYMBOL() is not used, but #include <linux/export.h> is present    
> > > 
> > > While this true...
> > >   
> > > >  #include <linux/kernel.h>    
> > > 
> > > ...I prefer a full and not half-baked solution, i.e. revisiting all
> > > headers and esp. replacing kernel.h with what is used.
> > >   
> > > > -#include <linux/export.h>
> > > >  #include <linux/slab.h>
> > > >  #include <linux/interrupt.h>
> > > >  #include <linux/irq.h>    
> > > 
> > > While doing that, the headers may be sorted (in the same or preparatory patch).
> > 
> > Whilst I agree that more work is need, I also don't like the time it might
> > take to get to it and the warnings that might mean more significant issues get
> > missed in the wash in the meantime.
> 
> After I wrote this I remembered that this is our 'reference' code so we
> should hold it to a higher standard.  So I'll try and come back and improve
> this one sometime soon rather than just papering over the cracks.

Right, I would actually add to whatever TODO exists (written or spelled :-)
to replace kernel.h with the respective header(s) in whole IIO subsystem.

> Given I tend to build with W=1 and right now I'm swamped with pages
> of these warnings I'm really keen to get rid of them in IIO anyway
> and I see lots of activity to squash them more generally.

I am frustrated not less than you, but here we are.

> I'm a bit grumpy that this warning got added without (as far as I saw)
> any attempt to first clean up upstream.

This is not the first time something like this happened. Because it's `make
W=1` build, not many complain.

-- 
With Best Regards,
Andy Shevchenko