From: Petr Vorel <pvorel@suse.cz>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Wei Gao <wegao@suse.com>,
ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
cgroups@vger.kernel.org
Subject: Re: [LTP] [PATCH v1] sched_rr_get_interval01.c: Put test process into absolute root cgroup (0::/)
Date: Mon, 9 Jun 2025 15:33:32 +0200 [thread overview]
Message-ID: <20250609133332.GA1501907@pevik> (raw)
In-Reply-To: <rugkmu3bcsrqgehibgy3dn7nsisuv6lip7b5cmo3bewq4zjcdn@zuo6hg25pqyz>
Hi all,
> On Sat, Jun 07, 2025 at 02:42:22PM -0400, Wei Gao <wegao@suse.com> wrote:
> > @Michal Koutný So we should skip test cgroupv2 with CONFIG_RT_GROUP_SCHED=yes, correct?
> Ideally, no one should run v2 with CONFIG_RT_GROUP_SCHED=y, so this
> would never fail :-p
@Michal thanks for a clarification. It's default n and
Documentation/scheduler/sched-rt-group.rst which mentions CONFIG_RT_GROUP_SCHED
also mentions Documentation/admin-guide/cgroup-v1/cgroups.rst, that should be a
good hint for people changing the defaults :).
Also, there are 3 old mips and sh boards which set CONFIG_RT_GROUP_SCHED=y.
Probably nobody cares much nowadays, but maybe it should be deleted.
> > Like following change?
> But if there are such poor souls, that skip should make the test not
> obstruct the rest of LTP.
@Andrea, you claimed it's merged, but maybe you reply to a wrong thread
because it's not merged.
https://lore.kernel.org/ltp/b15fa0cb-e893-4642-9aa0-05f732b75131@suse.com/
I agree with Cyril to have a custom function in lib/tst_cgroup.c, which would be
called by affected tests.
Kind regards,
Petr
> Thanks,
> Michal
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: cgroups@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] sched_rr_get_interval01.c: Put test process into absolute root cgroup (0::/)
Date: Mon, 9 Jun 2025 15:33:32 +0200 [thread overview]
Message-ID: <20250609133332.GA1501907@pevik> (raw)
In-Reply-To: <rugkmu3bcsrqgehibgy3dn7nsisuv6lip7b5cmo3bewq4zjcdn@zuo6hg25pqyz>
Hi all,
> On Sat, Jun 07, 2025 at 02:42:22PM -0400, Wei Gao <wegao@suse.com> wrote:
> > @Michal Koutný So we should skip test cgroupv2 with CONFIG_RT_GROUP_SCHED=yes, correct?
> Ideally, no one should run v2 with CONFIG_RT_GROUP_SCHED=y, so this
> would never fail :-p
@Michal thanks for a clarification. It's default n and
Documentation/scheduler/sched-rt-group.rst which mentions CONFIG_RT_GROUP_SCHED
also mentions Documentation/admin-guide/cgroup-v1/cgroups.rst, that should be a
good hint for people changing the defaults :).
Also, there are 3 old mips and sh boards which set CONFIG_RT_GROUP_SCHED=y.
Probably nobody cares much nowadays, but maybe it should be deleted.
> > Like following change?
> But if there are such poor souls, that skip should make the test not
> obstruct the rest of LTP.
@Andrea, you claimed it's merged, but maybe you reply to a wrong thread
because it's not merged.
https://lore.kernel.org/ltp/b15fa0cb-e893-4642-9aa0-05f732b75131@suse.com/
I agree with Cyril to have a custom function in lib/tst_cgroup.c, which would be
called by affected tests.
Kind regards,
Petr
> Thanks,
> Michal
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-06-09 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 14:29 [LTP] [PATCH v1] sched_rr_get_interval01.c: Put test process into absolute root cgroup (0::/) Wei Gao via ltp
2025-06-05 9:40 ` Petr Vorel
2025-06-05 9:40 ` Petr Vorel
2025-06-05 11:17 ` Andrea Cervesato
2025-06-05 11:17 ` Andrea Cervesato via ltp
2025-06-05 15:56 ` Michal Koutný
2025-06-07 4:01 ` Wei Gao via ltp
2025-06-07 18:42 ` Wei Gao
2025-06-07 18:42 ` Wei Gao via ltp
2025-06-09 11:44 ` Michal Koutný
2025-06-09 13:33 ` Petr Vorel [this message]
2025-06-09 13:33 ` Petr Vorel
2025-06-05 13:14 ` Cyril Hrubis
2025-06-10 22:14 ` [LTP] [PATCH v2] tst_cgroup.c: Skip cases which testing cgroup v2 with CONFIG_RT_GROUP_SCHED=y Wei Gao via ltp
2025-08-22 1:38 ` Li Wang via ltp
2025-08-22 1:42 ` Li Wang via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250609133332.GA1501907@pevik \
--to=pvorel@suse.cz \
--cc=cgroups@vger.kernel.org \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=mkoutny@suse.com \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.