All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Arnd Bergmann <arnd@arndb.de>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH] pci: altera: remove unused 'node' variable
Date: Wed, 11 Jun 2025 12:43:30 +0200	[thread overview]
Message-ID: <20250611104348.192092-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20250611104348.192092-1-jirislaby@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

This variable is only used when CONFIG_OF is enabled:

drivers/pci/controller/pcie-altera.c: In function 'altera_pcie_init_irq_domain':
drivers/pci/controller/pcie-altera.c:855:29: error: unused variable 'node' [-Werror=unused-variable]
  855 |         struct device_node *node = dev->of_node;

Use dev_fwnode() in place of of_node_to_fwnode() to avoid this.

----
I checked the other PCI host bridge drivers as well, this is the
only one with that problem.

Fixes: bbc94e6f72f2 ("PCI: Switch to irq_domain_create_linear()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
 drivers/pci/controller/pcie-altera.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
index 0fc77176a52e..3dbb7adc421c 100644
--- a/drivers/pci/controller/pcie-altera.c
+++ b/drivers/pci/controller/pcie-altera.c
@@ -852,10 +852,9 @@ static void aglx_isr(struct irq_desc *desc)
 static int altera_pcie_init_irq_domain(struct altera_pcie *pcie)
 {
 	struct device *dev = &pcie->pdev->dev;
-	struct device_node *node = dev->of_node;
 
 	/* Setup INTx */
-	pcie->irq_domain = irq_domain_create_linear(of_fwnode_handle(node), PCI_NUM_INTX,
+	pcie->irq_domain = irq_domain_create_linear(dev_fwnode(dev), PCI_NUM_INTX,
 					&intx_domain_ops, pcie);
 	if (!pcie->irq_domain) {
 		dev_err(dev, "Failed to get a INTx IRQ domain\n");
-- 
2.49.0


  reply	other threads:[~2025-06-11 10:43 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-11 10:43 [PATCH] mfd: fix building without CONFIG_OF Jiri Slaby (SUSE)
2025-06-11 10:43 ` Jiri Slaby (SUSE) [this message]
2025-06-13 15:41   ` [PATCH] pci: altera: remove unused 'node' variable Bjorn Helgaas
2025-06-11 10:43 ` [PATCH] bus: moxtet: Use dev_fwnode() Jiri Slaby (SUSE)
2025-06-17  8:00   ` Marek Behún
2025-06-11 10:43 ` [PATCH] drm/msm: use dev_fwnode() Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] edac: Use dev_fwnode() Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] gpio: " Jiri Slaby (SUSE)
2025-06-11 10:43   ` Jiri Slaby (SUSE)
2025-06-11 15:18   ` Andy Shevchenko
2025-06-11 15:18     ` Andy Shevchenko
2025-06-16  7:42   ` Bartosz Golaszewski
2025-06-16  7:42     ` Bartosz Golaszewski
2025-06-11 10:43 ` [PATCH] gpu: ipu-v3: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] i2c: " Jiri Slaby (SUSE)
2025-06-27 10:54   ` Wolfram Sang
2025-06-11 10:43 ` [PATCH] iio: " Jiri Slaby (SUSE)
2025-06-11 13:57   ` David Lechner
2025-06-12  8:46     ` [PATCH v2] iio: adc: stm32-adc: " Jiri Slaby (SUSE)
2025-06-13 17:00       ` David Lechner
2025-06-14 11:08         ` Jonathan Cameron
2025-06-11 10:43 ` [PATCH] irqchip: " Jiri Slaby (SUSE)
2025-06-11 13:51   ` [Linux-stm32] " Antonio Borneo
2025-06-12 13:13   ` [tip: irq/drivers] " tip-bot2 for Jiri Slaby (SUSE)
2025-06-17 13:04   ` [PATCH] " Nishanth Menon
2025-06-11 10:43 ` [PATCH] mailbox: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] memory: " Jiri Slaby (SUSE)
2025-06-12 11:34   ` Krzysztof Kozlowski
2025-06-12 11:38     ` Krzysztof Kozlowski
2025-06-12 11:39   ` Krzysztof Kozlowski
2025-06-11 10:43 ` [PATCH] mfd: " Jiri Slaby (SUSE)
2025-06-12  8:48   ` Charles Keepax
2025-06-19 11:34   ` (subset) " Lee Jones
2025-06-11 10:43 ` [PATCH] misc: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] net: " Jiri Slaby (SUSE)
2025-06-13  2:00   ` patchwork-bot+netdevbpf
2025-06-11 10:43 ` [PATCH] pci/controller: " Jiri Slaby (SUSE)
2025-06-13 16:09   ` (subset) " Manivannan Sadhasivam
2025-07-15 18:49   ` Bjorn Helgaas
2025-07-16  7:59     ` Nam Cao
2025-07-16 14:49       ` Bjorn Helgaas
2025-07-21 17:08         ` Bjorn Helgaas
2025-07-22  6:24           ` Jiri Slaby
2025-07-22 23:20             ` Bjorn Helgaas
2025-07-23  6:47               ` Jiri Slaby
2025-06-11 10:43 ` [PATCH] pinctrl: " Jiri Slaby (SUSE)
2025-06-11 11:04   ` Chen-Yu Tsai
2025-06-18 11:32   ` Linus Walleij
2025-06-11 10:43 ` [PATCH] powerpc: " Jiri Slaby (SUSE)
2025-06-11 10:43 ` [PATCH] soc: " Jiri Slaby (SUSE)
2025-06-11 15:13   ` Thierry Reding
2025-06-12 11:31   ` Krzysztof Kozlowski
2025-06-12 12:28     ` Christophe Leroy
2025-07-08  8:33   ` Christophe Leroy
2025-07-30 13:37     ` Christophe Leroy
2025-06-11 10:43 ` [PATCH] thermal: " Jiri Slaby (SUSE)
2025-06-11 15:13   ` Thierry Reding
2025-07-15 13:33   ` Daniel Lezcano
  -- strict thread matches above, loose matches on Subject: below --
2025-05-21 16:29 [PATCH] pci: altera: remove unused 'node' variable Arnd Bergmann
2025-05-22  1:48 ` Hans Zhang
2025-05-22  5:53 ` Jiri Slaby
2025-05-22  6:32   ` Arnd Bergmann
2025-05-23 16:33 ` Bjorn Helgaas
2025-06-13  9:25 ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250611104348.192092-2-jirislaby@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.