From: Andrew Sayers <kernel.org@pileofstuff.org>
To: linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com, pav@iki.fi, frederic.danis@collabora.com,
Andrew Sayers <kernel.org@pileofstuff.org>
Subject: [PATCH BlueZ v2 0/3] pbap: use the public DBus connection
Date: Wed, 11 Jun 2025 14:06:12 +0100 [thread overview]
Message-ID: <20250611131125.450039-1-kernel.org@pileofstuff.org> (raw)
DBus requests are received by the public DBus connection, because it
registers the relevant bus name. My previous patches told PBAP to
listen on a private connection, but DBus doesn't let connections share
bus names, so it needs to listen on the public connection instead.
This adds a little more complexity to the logind callbacks, to avoid
unregistering profiles during shutdown. It also removes an API I
previously added, which is no longer used and would only encourage the
next person to make the same mistake.
While reviewing this change, it became obvious seat-detection should
be merged into the normal driver interface instead. That change is
likely to add time and could create its own bugs, so this series fixes
the simple bug while we discuss the deeper issue.
Reported-by: Frédéric Danis <frederic.danis@collabora.com>
Closes: https://lore.kernel.org/linux-bluetooth/333ad76e-0aba-4f93-b141-8e69fb47535f@collabora.com/
Suggested-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
--
Frédéric and Pauli - please let me know if you'd like to be CCed on
the architecture discussion. Otherwise, I'll assume you're not
interested in that part of the problem.
V1 -> V2 Move instances of "(void)foo" below "int bar"
(fixes a "mixed declarations and code" error)
Andrew Sayers (3):
obexd: Pass at_(un)register value to logind callbacks
pbap: use the public DBus connection
Revert "obexd: Support creating private system/session bus connections"
obexd/client/pbap.c | 28 ++++++++++++++++++++++++----
obexd/plugins/bluetooth.c | 6 ++++--
obexd/src/logind.c | 14 +++++++-------
obexd/src/logind.h | 8 ++++----
obexd/src/main.c | 8 --------
obexd/src/obexd.h | 2 --
6 files changed, 39 insertions(+), 27 deletions(-)
next reply other threads:[~2025-06-11 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 13:06 Andrew Sayers [this message]
2025-06-11 13:06 ` [PATCH BlueZ v2 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-11 14:35 ` pbap: use the public DBus connection bluez.test.bot
2025-06-11 13:06 ` [PATCH BlueZ v2 2/3] " Andrew Sayers
2025-06-11 13:06 ` [PATCH BlueZ v2 3/3] Revert "obexd: Support creating private system/session bus connections" Andrew Sayers
2025-06-11 14:50 ` [PATCH BlueZ v2 0/3] pbap: use the public DBus connection patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611131125.450039-1-kernel.org@pileofstuff.org \
--to=kernel.org@pileofstuff.org \
--cc=frederic.danis@collabora.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=pav@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.