From: Andrew Sayers <kernel.org@pileofstuff.org>
To: linux-bluetooth@vger.kernel.org
Cc: luiz.dentz@gmail.com, pav@iki.fi, frederic.danis@collabora.com,
Andrew Sayers <kernel.org@pileofstuff.org>
Subject: [PATCH BlueZ v2 3/3] Revert "obexd: Support creating private system/session bus connections"
Date: Wed, 11 Jun 2025 14:06:15 +0100 [thread overview]
Message-ID: <20250611131125.450039-4-kernel.org@pileofstuff.org> (raw)
In-Reply-To: <20250611131125.450039-1-kernel.org@pileofstuff.org>
This reverts commit 237d818ef294e22be87fba69b3cdd79c75c201e7,
which encouraged the use of private DBus connections.
Doing so caused a bug, so it's better to remove the temptation for now
and re-add it if a legitimate use case is ever found.
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
---
obexd/src/main.c | 8 --------
obexd/src/obexd.h | 2 --
2 files changed, 10 deletions(-)
diff --git a/obexd/src/main.c b/obexd/src/main.c
index df150973e..6837f0d73 100644
--- a/obexd/src/main.c
+++ b/obexd/src/main.c
@@ -254,14 +254,6 @@ DBusConnection *obex_setup_dbus_connection(const char *name,
return connection;
}
-DBusConnection *obex_setup_dbus_connection_private(const char *name,
- DBusError *error)
-{
- return g_dbus_setup_private(option_system_bus ?
- DBUS_BUS_SYSTEM : DBUS_BUS_SESSION,
- name, error);
-}
-
int main(int argc, char *argv[])
{
GOptionContext *context;
diff --git a/obexd/src/obexd.h b/obexd/src/obexd.h
index 560db29ce..5e5edc4de 100644
--- a/obexd/src/obexd.h
+++ b/obexd/src/obexd.h
@@ -33,5 +33,3 @@ const char *obex_option_capability(void);
DBusConnection *obex_get_dbus_connection(void);
DBusConnection *obex_setup_dbus_connection(const char *name,
DBusError *error);
-DBusConnection *obex_setup_dbus_connection_private(const char *name,
- DBusError *error);
--
2.49.0
next prev parent reply other threads:[~2025-06-11 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 13:06 [PATCH BlueZ v2 0/3] pbap: use the public DBus connection Andrew Sayers
2025-06-11 13:06 ` [PATCH BlueZ v2 1/3] obexd: Pass at_(un)register value to logind callbacks Andrew Sayers
2025-06-11 14:35 ` pbap: use the public DBus connection bluez.test.bot
2025-06-11 13:06 ` [PATCH BlueZ v2 2/3] " Andrew Sayers
2025-06-11 13:06 ` Andrew Sayers [this message]
2025-06-11 14:50 ` [PATCH BlueZ v2 0/3] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611131125.450039-4-kernel.org@pileofstuff.org \
--to=kernel.org@pileofstuff.org \
--cc=frederic.danis@collabora.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=pav@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.