Re: [PATCH 25/28] iio: pressure: mprls0025pa: use = { } instead of memset()

From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Michael Hennerich" <michael.hennerich@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Francesco Dolcini" <francesco@dolcini.it>,
	"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
	"Leonard Göhrs" <l.goehrs@pengutronix.de>,
	kernel@pengutronix.de, "Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Roan van Dijk" <roan@protonic.nl>,
	"Tomasz Duszynski" <tomasz.duszynski@octakon.com>,
	"Jacopo Mondi" <jacopo@jmondi.org>,
	"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
	"Mudit Sharma" <muditsharma.info@gmail.com>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Ondřej Jirman" <megi@xff.cz>,
	"Andreas Klinger" <ak@it-klinger.de>,
	"Petre Rodan" <petre.rodan@subdimension.ro>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 25/28] iio: pressure: mprls0025pa: use = { } instead of memset()
Date: Sat, 14 Jun 2025 13:23:02 +0100	[thread overview]
Message-ID: <20250614132302.1e134315@jic23-huawei> (raw)
In-Reply-To: <20250611-iio-zero-init-stack-with-instead-of-memset-v1-25-ebb2d0a24302@baylibre.com>

On Wed, 11 Jun 2025 17:39:17 -0500
David Lechner <dlechner@baylibre.com> wrote:

> Use { } instead of memset() to zero-initialize stack memory to simplify
> the code.
> 
> The initialize of the cmd value is trivial so it can be moved to the
> array initializer as well.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  drivers/iio/pressure/mprls0025pa_i2c.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/pressure/mprls0025pa_i2c.c b/drivers/iio/pressure/mprls0025pa_i2c.c
> index 1a48f8d43d716b28b8fceb8e1a06d63a73a74a86..79811fd4a02b370b3fde8bd67a5115a3934f8614 100644
> --- a/drivers/iio/pressure/mprls0025pa_i2c.c
> +++ b/drivers/iio/pressure/mprls0025pa_i2c.c
> @@ -44,10 +44,7 @@ static int mpr_i2c_write(struct mpr_data *data, const u8 cmd, const u8 unused)
>  {
>  	int ret;
>  	struct i2c_client *client = to_i2c_client(data->dev);
> -	u8 wdata[MPR_PKT_SYNC_LEN];
> -
> -	memset(wdata, 0, sizeof(wdata));
> -	wdata[0] = cmd;
> +	u8 wdata[MPR_PKT_SYNC_LEN] = { cmd };

Slight preference for trailing comma after cmd,

>  
>  	ret = i2c_master_send(client, wdata, MPR_PKT_SYNC_LEN);
>  	if (ret < 0)
> 