[PATCH net-next] selftests/tc-testing: sfq: check perturb timer values

[PATCH net-next] selftests/tc-testing: sfq: check perturb timer values

[Eric Dumazet]

Add one test to check that the kernel rejects a negative perturb timer.

Add a second test checking that the kernel rejects
a too big perturb timer.

All test results:

1..2
ok 1 cdc1 - Check that a negative perturb timer is rejected
ok 2 a9f0 - Check that a too big perturb timer is rejected

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 .../tc-testing/tc-tests/qdiscs/sfq.json       | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfq.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfq.json
index 28c6ce6da7dbb829765517f989d5441aab98f901..531a2f6e49001e9390eabaef1b545d6836cecb58 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfq.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfq.json
@@ -264,5 +264,41 @@
         "matchPattern": "sfq",
         "matchCount": "0",
         "teardown": []
+    },
+    {
+        "id": "cdc1",
+        "name": "Check that a negative perturb timer is rejected",
+        "category": [
+            "qdisc",
+            "sfq"
+        ],
+        "plugins": {
+            "requires": "nsPlugin"
+        },
+        "setup": [],
+        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfq perturb -10",
+        "expExitCode": "2",
+        "verifyCmd": "$TC qdisc show dev $DUMMY",
+        "matchPattern": "sfq",
+        "matchCount": "0",
+        "teardown": []
+    },
+    {
+        "id": "a9f0",
+        "name": "Check that a too big perturb timer is rejected",
+        "category": [
+            "qdisc",
+            "sfq"
+        ],
+        "plugins": {
+            "requires": "nsPlugin"
+        },
+        "setup": [],
+        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfq perturb 1000000000",
+        "expExitCode": "2",
+        "verifyCmd": "$TC qdisc show dev $DUMMY",
+        "matchPattern": "sfq",
+        "matchCount": "0",
+        "teardown": []
     }
 ]
-- 
2.50.0.rc1.591.g9c95f17f64-goog

Re: [PATCH net-next] selftests/tc-testing: sfq: check perturb timer values

[Simon Horman]

On Fri, Jun 13, 2025 at 06:41:36AM +0000, Eric Dumazet wrote:
> Add one test to check that the kernel rejects a negative perturb timer.
> 
> Add a second test checking that the kernel rejects
> a too big perturb timer.
> 
> All test results:
> 
> 1..2
> ok 1 cdc1 - Check that a negative perturb timer is rejected
> ok 2 a9f0 - Check that a too big perturb timer is rejected
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] selftests/tc-testing: sfq: check perturb timer values

[Cong Wang]

On Thu, Jun 12, 2025 at 11:41 PM Eric Dumazet <edumazet@google.com> wrote:
>
> Add one test to check that the kernel rejects a negative perturb timer.
>
> Add a second test checking that the kernel rejects
> a too big perturb timer.
>
> All test results:
>
> 1..2
> ok 1 cdc1 - Check that a negative perturb timer is rejected
> ok 2 a9f0 - Check that a too big perturb timer is rejected
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Reviewed-by: Cong Wang <xiyou.wangcong@gmail.com>

Thanks!

Re: [PATCH net-next] selftests/tc-testing: sfq: check perturb timer values

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 13 Jun 2025 06:41:36 +0000 you wrote:
> Add one test to check that the kernel rejects a negative perturb timer.
> 
> Add a second test checking that the kernel rejects
> a too big perturb timer.
> 
> All test results:
> 
> [...]

Here is the summary with links:
  - [net-next] selftests/tc-testing: sfq: check perturb timer values
    https://git.kernel.org/netdev/net-next/c/de74998c3008

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html