All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] exit: fix misleading comment in forget_original_parent()
@ 2025-06-15  3:09 Fushuai Wang
  2025-06-15  3:57 ` Oleg Nesterov
  0 siblings, 1 reply; 2+ messages in thread
From: Fushuai Wang @ 2025-06-15  3:09 UTC (permalink / raw)
  To: oleg, brauner, akpm, mjguzik
  Cc: mhocko, andrii, pasha.tatashin, linux-kernel, Fushuai Wang

The commit 482a3767e508 ("exit: reparent: call forget_original_parent()
under tasklist_lock") moved the comment from exit_notify() to
forget_original_parent(). However, the forget_original_parent() only
handles (A), while (B) is handled in kill_orphaned_pgrp(). So remove
the unrelated part.

Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
 kernel/exit.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/kernel/exit.c b/kernel/exit.c
index bd743900354c..a7ba9178fe34 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -692,12 +692,7 @@ static void reparent_leader(struct task_struct *father, struct task_struct *p,
 }
 
 /*
- * This does two things:
- *
- * A.  Make init inherit all the child processes
- * B.  Check to see if any process groups have become orphaned
- *	as a result of our exiting, and if they have any stopped
- *	jobs, send them a SIGHUP and then a SIGCONT.  (POSIX 3.2.2.2)
+ * Make init inherit all the child processes
  */
 static void forget_original_parent(struct task_struct *father,
 					struct list_head *dead)
-- 
2.36.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] exit: fix misleading comment in forget_original_parent()
  2025-06-15  3:09 [PATCH] exit: fix misleading comment in forget_original_parent() Fushuai Wang
@ 2025-06-15  3:57 ` Oleg Nesterov
  0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2025-06-15  3:57 UTC (permalink / raw)
  To: Fushuai Wang
  Cc: brauner, akpm, mjguzik, mhocko, andrii, pasha.tatashin,
	linux-kernel

On 06/15, Fushuai Wang wrote:
>
> The commit 482a3767e508 ("exit: reparent: call forget_original_parent()
> under tasklist_lock") moved the comment from exit_notify() to
> forget_original_parent(). However, the forget_original_parent() only
> handles (A), while (B) is handled in kill_orphaned_pgrp(). So remove
> the unrelated part.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>

Acked-by: Oleg Nesterov <oleg@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-15  3:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-15  3:09 [PATCH] exit: fix misleading comment in forget_original_parent() Fushuai Wang
2025-06-15  3:57 ` Oleg Nesterov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.