All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	sparclinux@vger.kernel.org, x86@kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH v2 06/17] crypto: riscv/sha512 - stop depending on sha512_generic_block_fn
Date: Sun, 15 Jun 2025 18:40:08 -0700	[thread overview]
Message-ID: <20250616014019.415791-7-ebiggers@kernel.org> (raw)
In-Reply-To: <20250616014019.415791-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

sha512_generic_block_fn() will no longer be available when the SHA-512
support in the old-school crypto API is changed to just wrap the SHA-512
library.  Replace the use of sha512_generic_block_fn() in
sha512-riscv64-glue.c with temporary code that uses the library's
__sha512_update().  This is just a temporary workaround to keep the
kernel building and functional at each commit; this code gets superseded
when the RISC-V optimized SHA-512 is migrated to lib/crypto/ anyway.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 arch/riscv/crypto/Kconfig               | 1 +
 arch/riscv/crypto/sha512-riscv64-glue.c | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/crypto/Kconfig b/arch/riscv/crypto/Kconfig
index cd9b776602f89..53e4e1eacf554 100644
--- a/arch/riscv/crypto/Kconfig
+++ b/arch/riscv/crypto/Kconfig
@@ -29,10 +29,11 @@ config CRYPTO_GHASH_RISCV64
 	  - Zvkg vector crypto extension
 
 config CRYPTO_SHA512_RISCV64
 	tristate "Hash functions: SHA-384 and SHA-512"
 	depends on 64BIT && RISCV_ISA_V && TOOLCHAIN_HAS_VECTOR_CRYPTO
+	select CRYPTO_LIB_SHA512
 	select CRYPTO_SHA512
 	help
 	  SHA-384 and SHA-512 secure hash algorithm (FIPS 180)
 
 	  Architecture: riscv64 using:
diff --git a/arch/riscv/crypto/sha512-riscv64-glue.c b/arch/riscv/crypto/sha512-riscv64-glue.c
index 4634fca78ae24..b3dbc71de07b0 100644
--- a/arch/riscv/crypto/sha512-riscv64-glue.c
+++ b/arch/riscv/crypto/sha512-riscv64-glue.c
@@ -36,11 +36,17 @@ static void sha512_block(struct sha512_state *state, const u8 *data,
 	if (crypto_simd_usable()) {
 		kernel_vector_begin();
 		sha512_transform_zvknhb_zvkb(state, data, num_blocks);
 		kernel_vector_end();
 	} else {
-		sha512_generic_block_fn(state, data, num_blocks);
+		struct __sha512_ctx ctx = {};
+
+		static_assert(sizeof(ctx.state) == sizeof(state->state));
+		memcpy(&ctx.state, state->state, sizeof(ctx.state));
+		__sha512_update(&ctx, data,
+				(size_t)num_blocks * SHA512_BLOCK_SIZE);
+		memcpy(state->state, &ctx.state, sizeof(state->state));
 	}
 }
 
 static int riscv64_sha512_update(struct shash_desc *desc, const u8 *data,
 				 unsigned int len)
-- 
2.49.0



WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	sparclinux@vger.kernel.org, x86@kernel.org,
	Ard Biesheuvel <ardb@kernel.org>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH v2 06/17] crypto: riscv/sha512 - stop depending on sha512_generic_block_fn
Date: Sun, 15 Jun 2025 18:40:08 -0700	[thread overview]
Message-ID: <20250616014019.415791-7-ebiggers@kernel.org> (raw)
In-Reply-To: <20250616014019.415791-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

sha512_generic_block_fn() will no longer be available when the SHA-512
support in the old-school crypto API is changed to just wrap the SHA-512
library.  Replace the use of sha512_generic_block_fn() in
sha512-riscv64-glue.c with temporary code that uses the library's
__sha512_update().  This is just a temporary workaround to keep the
kernel building and functional at each commit; this code gets superseded
when the RISC-V optimized SHA-512 is migrated to lib/crypto/ anyway.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 arch/riscv/crypto/Kconfig               | 1 +
 arch/riscv/crypto/sha512-riscv64-glue.c | 8 +++++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/crypto/Kconfig b/arch/riscv/crypto/Kconfig
index cd9b776602f89..53e4e1eacf554 100644
--- a/arch/riscv/crypto/Kconfig
+++ b/arch/riscv/crypto/Kconfig
@@ -29,10 +29,11 @@ config CRYPTO_GHASH_RISCV64
 	  - Zvkg vector crypto extension
 
 config CRYPTO_SHA512_RISCV64
 	tristate "Hash functions: SHA-384 and SHA-512"
 	depends on 64BIT && RISCV_ISA_V && TOOLCHAIN_HAS_VECTOR_CRYPTO
+	select CRYPTO_LIB_SHA512
 	select CRYPTO_SHA512
 	help
 	  SHA-384 and SHA-512 secure hash algorithm (FIPS 180)
 
 	  Architecture: riscv64 using:
diff --git a/arch/riscv/crypto/sha512-riscv64-glue.c b/arch/riscv/crypto/sha512-riscv64-glue.c
index 4634fca78ae24..b3dbc71de07b0 100644
--- a/arch/riscv/crypto/sha512-riscv64-glue.c
+++ b/arch/riscv/crypto/sha512-riscv64-glue.c
@@ -36,11 +36,17 @@ static void sha512_block(struct sha512_state *state, const u8 *data,
 	if (crypto_simd_usable()) {
 		kernel_vector_begin();
 		sha512_transform_zvknhb_zvkb(state, data, num_blocks);
 		kernel_vector_end();
 	} else {
-		sha512_generic_block_fn(state, data, num_blocks);
+		struct __sha512_ctx ctx = {};
+
+		static_assert(sizeof(ctx.state) == sizeof(state->state));
+		memcpy(&ctx.state, state->state, sizeof(ctx.state));
+		__sha512_update(&ctx, data,
+				(size_t)num_blocks * SHA512_BLOCK_SIZE);
+		memcpy(state->state, &ctx.state, sizeof(state->state));
 	}
 }
 
 static int riscv64_sha512_update(struct shash_desc *desc, const u8 *data,
 				 unsigned int len)
-- 
2.49.0


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-06-16  2:33 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16  1:40 [PATCH v2 00/17] SHA-512 library functions Eric Biggers
2025-06-16  1:40 ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 01/17] crypto: sha512 - rename conflicting symbols Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 02/17] lib/crypto/sha512: add support for SHA-384 and SHA-512 Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 03/17] lib/crypto/sha512: add HMAC-SHA384 and HMAC-SHA512 support Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 04/17] lib/crypto/sha512: add KUnit tests for SHA-384 and SHA-512 Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 05/17] lib/crypto/sha256: add KUnit tests for SHA-224 and SHA-256 Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` Eric Biggers [this message]
2025-06-16  1:40   ` [PATCH v2 06/17] crypto: riscv/sha512 - stop depending on sha512_generic_block_fn Eric Biggers
2025-06-16  1:40 ` [PATCH v2 07/17] crypto: sha512 - replace sha512_generic with wrapper around SHA-512 library Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 08/17] crypto: sha512 - use same state format as legacy drivers Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 09/17] lib/crypto/sha512: migrate arm-optimized SHA-512 code to library Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 10/17] lib/crypto/sha512: migrate arm64-optimized " Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 11/17] mips: cavium-octeon: move octeon-crypto.h into asm directory Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 12/17] lib/crypto/sha512: migrate mips-optimized SHA-512 code to library Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 13/17] lib/crypto/sha512: migrate riscv-optimized " Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 14/17] lib/crypto/sha512: migrate s390-optimized " Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 15/17] lib/crypto/sha512: migrate sparc-optimized " Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 16/17] lib/crypto/sha512: migrate x86-optimized " Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-16  1:40 ` [PATCH v2 17/17] crypto: sha512 - remove sha512_base.h Eric Biggers
2025-06-16  1:40   ` Eric Biggers
2025-06-17  6:05 ` [PATCH v2 00/17] SHA-512 library functions Eric Biggers
2025-06-17  6:05   ` Eric Biggers
2025-06-17 18:29   ` Linus Torvalds
2025-06-17 18:29     ` Linus Torvalds
2025-06-17 19:22     ` Eric Biggers
2025-06-17 19:22       ` Eric Biggers
2025-06-17 19:43       ` Linus Torvalds
2025-06-17 19:43         ` Linus Torvalds
2025-06-17 19:58         ` Eric Biggers
2025-06-17 19:58           ` Eric Biggers
2025-06-17 20:08           ` Linus Torvalds
2025-06-17 20:08             ` Linus Torvalds
2025-06-17 20:37             ` Eric Biggers
2025-06-17 20:37               ` Eric Biggers
2025-06-17 21:10               ` Linus Torvalds
2025-06-17 21:10                 ` Linus Torvalds
2025-06-20 21:27 ` Eric Biggers
2025-06-20 21:27   ` Eric Biggers
2025-06-20 21:42 ` Ard Biesheuvel
2025-06-20 21:42   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616014019.415791-7-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.