All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, skalluru@marvell.com, manishc@marvell.com,
	andrew+netdev@lunn.ch, michael.chan@broadcom.com,
	pavan.chebbi@broadcom.com, ajit.khaparde@broadcom.com,
	sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
	anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	tariqt@nvidia.com, saeedm@nvidia.com, louis.peens@corigine.com,
	shshaikh@marvell.com, GR-Linux-NIC-Dev@marvell.com,
	ecree.xilinx@gmail.com, horms@kernel.org, dsahern@kernel.org,
	shuah@kernel.org, tglx@linutronix.de, mingo@kernel.org,
	ruanjinjie@huawei.com, idosch@nvidia.com, razor@blackwall.org,
	petrm@nvidia.com, kuniyu@google.com, sdf@fomichev.me,
	linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
	linux-net-drivers@amd.com, linux-kselftest@vger.kernel.org,
	leon@kernel.org
Subject: [Intel-wired-lan] [PATCH net-next v5 4/6] net: remove redundant ASSERT_RTNL() in queue setup functions
Date: Mon, 16 Jun 2025 09:21:15 -0700	[thread overview]
Message-ID: <20250616162117.287806-5-stfomichev@gmail.com> (raw)
In-Reply-To: <20250616162117.287806-1-stfomichev@gmail.com>

The existing netdev_ops_assert_locked() already asserts that either
the RTNL lock or the per-device lock is held, making the explicit
ASSERT_RTNL() redundant.

Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Stanislav Fomichev <stfomichev@gmail.com>
---
 net/core/dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 43f56b44f351..df1678b1fe24 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
 
 	if (dev->reg_state == NETREG_REGISTERED ||
 	    dev->reg_state == NETREG_UNREGISTERING) {
-		ASSERT_RTNL();
 		netdev_ops_assert_locked(dev);
 
 		rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
@@ -3229,7 +3228,6 @@ int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
 		return -EINVAL;
 
 	if (dev->reg_state == NETREG_REGISTERED) {
-		ASSERT_RTNL();
 		netdev_ops_assert_locked(dev);
 
 		rc = net_rx_queue_update_kobjects(dev, dev->real_num_rx_queues,
-- 
2.49.0


WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Fomichev <stfomichev@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, skalluru@marvell.com, manishc@marvell.com,
	andrew+netdev@lunn.ch, michael.chan@broadcom.com,
	pavan.chebbi@broadcom.com, ajit.khaparde@broadcom.com,
	sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
	anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
	tariqt@nvidia.com, saeedm@nvidia.com, louis.peens@corigine.com,
	shshaikh@marvell.com, GR-Linux-NIC-Dev@marvell.com,
	ecree.xilinx@gmail.com, horms@kernel.org, dsahern@kernel.org,
	shuah@kernel.org, tglx@linutronix.de, mingo@kernel.org,
	ruanjinjie@huawei.com, idosch@nvidia.com, razor@blackwall.org,
	petrm@nvidia.com, kuniyu@google.com, sdf@fomichev.me,
	linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
	linux-rdma@vger.kernel.org, oss-drivers@corigine.com,
	linux-net-drivers@amd.com, linux-kselftest@vger.kernel.org,
	leon@kernel.org
Subject: [PATCH net-next v5 4/6] net: remove redundant ASSERT_RTNL() in queue setup functions
Date: Mon, 16 Jun 2025 09:21:15 -0700	[thread overview]
Message-ID: <20250616162117.287806-5-stfomichev@gmail.com> (raw)
In-Reply-To: <20250616162117.287806-1-stfomichev@gmail.com>

The existing netdev_ops_assert_locked() already asserts that either
the RTNL lock or the per-device lock is held, making the explicit
ASSERT_RTNL() redundant.

Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Stanislav Fomichev <stfomichev@gmail.com>
---
 net/core/dev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 43f56b44f351..df1678b1fe24 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct net_device *dev, unsigned int txq)
 
 	if (dev->reg_state == NETREG_REGISTERED ||
 	    dev->reg_state == NETREG_UNREGISTERING) {
-		ASSERT_RTNL();
 		netdev_ops_assert_locked(dev);
 
 		rc = netdev_queue_update_kobjects(dev, dev->real_num_tx_queues,
@@ -3229,7 +3228,6 @@ int netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
 		return -EINVAL;
 
 	if (dev->reg_state == NETREG_REGISTERED) {
-		ASSERT_RTNL();
 		netdev_ops_assert_locked(dev);
 
 		rc = net_rx_queue_update_kobjects(dev, dev->real_num_rx_queues,
-- 
2.49.0


  parent reply	other threads:[~2025-06-16 16:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 16:21 [Intel-wired-lan] [PATCH net-next v5 0/6] udp_tunnel: remove rtnl_lock dependency Stanislav Fomichev
2025-06-16 16:21 ` Stanislav Fomichev
2025-06-16 16:21 ` [Intel-wired-lan] [PATCH net-next v5 1/6] geneve: rely on rtnl lock in geneve_offload_rx_ports Stanislav Fomichev
2025-06-16 16:21   ` Stanislav Fomichev
2025-06-18 15:14   ` [Intel-wired-lan] " Nikolay Aleksandrov
2025-06-18 15:14     ` Nikolay Aleksandrov
2025-06-16 16:21 ` [Intel-wired-lan] [PATCH net-next v5 2/6] vxlan: drop sock_lock Stanislav Fomichev
2025-06-16 16:21   ` Stanislav Fomichev
2025-06-18  8:24   ` [Intel-wired-lan] " Ido Schimmel
2025-06-18  8:24     ` Ido Schimmel
2025-06-18 15:13   ` [Intel-wired-lan] " Nikolay Aleksandrov
2025-06-18 15:13     ` Nikolay Aleksandrov
2025-06-16 16:21 ` [Intel-wired-lan] [PATCH net-next v5 3/6] udp_tunnel: remove rtnl_lock dependency Stanislav Fomichev
2025-06-16 16:21   ` Stanislav Fomichev
2025-06-16 16:21 ` Stanislav Fomichev [this message]
2025-06-16 16:21   ` [PATCH net-next v5 4/6] net: remove redundant ASSERT_RTNL() in queue setup functions Stanislav Fomichev
2025-06-16 16:21 ` [Intel-wired-lan] [PATCH net-next v5 5/6] netdevsim: remove udp_ports_sleep Stanislav Fomichev
2025-06-16 16:21   ` Stanislav Fomichev
2025-06-16 16:21 ` [Intel-wired-lan] [PATCH net-next v5 6/6] Revert "bnxt_en: bring back rtnl_lock() in the bnxt_open() path" Stanislav Fomichev
2025-06-16 16:21   ` Stanislav Fomichev
2025-06-19  2:00 ` [Intel-wired-lan] [PATCH net-next v5 0/6] udp_tunnel: remove rtnl_lock dependency patchwork-bot+netdevbpf
2025-06-19  2:00   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250616162117.287806-5-stfomichev@gmail.com \
    --to=stfomichev@gmail.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=manishc@marvell.com \
    --cc=michael.chan@broadcom.com \
    --cc=mingo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=petrm@nvidia.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=razor@blackwall.org \
    --cc=ruanjinjie@huawei.com \
    --cc=saeedm@nvidia.com \
    --cc=sdf@fomichev.me \
    --cc=shshaikh@marvell.com \
    --cc=shuah@kernel.org \
    --cc=skalluru@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    --cc=tariqt@nvidia.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.