From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
ap420073@gmail.com
Subject: Re: [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs
Date: Wed, 18 Jun 2025 14:53:30 -0700 [thread overview]
Message-ID: <20250618145330.2584636e@kernel.org> (raw)
In-Reply-To: <20250617210950.1338107-1-almasrymina@google.com>
On Tue, 17 Jun 2025 21:09:50 +0000 Mina Almasry wrote:
> + void *ptr;
> +
> + if (!skb_frag_page(frag))
> + return NULL;
> +
> + ptr = page_address(skb_frag_page(frag));
Sorry, noticed mid-push that we're calling skb_frag_page() twice.
Let's save the return value and pass it to page_address?
--
pw-bot: cr
prev parent reply other threads:[~2025-06-18 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 21:09 [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs Mina Almasry
2025-06-17 21:15 ` Mina Almasry
2025-06-17 21:30 ` Stanislav Fomichev
2025-06-17 21:52 ` Mina Almasry
2025-06-18 21:27 ` Jakub Kicinski
2025-06-18 21:38 ` Stanislav Fomichev
2025-06-18 21:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250618145330.2584636e@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.