From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
ap420073@gmail.com
Subject: Re: [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs
Date: Tue, 17 Jun 2025 14:30:10 -0700 [thread overview]
Message-ID: <aFHeYuMf_LCv6Yng@mini-arch> (raw)
In-Reply-To: <CAHS8izMWiiHbfnHY=r5uCjHmDSDbWgsOOrctyuxJF3Q3+XLxWw@mail.gmail.com>
On 06/17, Mina Almasry wrote:
> On Tue, Jun 17, 2025 at 2:09 PM Mina Almasry <almasrymina@google.com> wrote:
> >
> > skb_frag_address_safe() needs a check that the
> > skb_frag_page exists check similar to skb_frag_address().
> >
> > Cc: ap420073@gmail.com
> >
>
> Sorry, I realized right after hitting send, I'm missing:
>
> Fixes: 9f6b619edf2e ("net: support non paged skb frags")
>
> I can respin after the 24hr cooldown.
The function is used in five drivers, none of which support devmem tx,
does not look like there is a reason to route it via net.
The change it self looks good, but not really sure it's needed.
skb_frag_address_safe is used in some pass-data-via-descriptor-ring mode,
I don't see 'modern' drivers (besides bnxt which added this support in 2015)
use it.
next prev parent reply other threads:[~2025-06-17 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 21:09 [PATCH net v1] netmem: fix skb_frag_address_safe with unreadable skbs Mina Almasry
2025-06-17 21:15 ` Mina Almasry
2025-06-17 21:30 ` Stanislav Fomichev [this message]
2025-06-17 21:52 ` Mina Almasry
2025-06-18 21:27 ` Jakub Kicinski
2025-06-18 21:38 ` Stanislav Fomichev
2025-06-18 21:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFHeYuMf_LCv6Yng@mini-arch \
--to=stfomichev@gmail.com \
--cc=almasrymina@google.com \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.