* [PATCH v2] usb: cdnsp: Fix issue with CV Bad Descriptor test [not found] <20250618053148.777461-1-pawell@cadence.com> @ 2025-06-18 5:39 ` Pawel Laszczak 2025-06-19 2:27 ` Peter Chen (CIX) 0 siblings, 1 reply; 2+ messages in thread From: Pawel Laszczak @ 2025-06-18 5:39 UTC (permalink / raw) To: peter.chen@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pawel Laszczak The SSP2 controller has extra endpoint state preserve bit (ESP) which setting causes that endpoint state will be preserved during Halt Endpoint command. It is used only for EP0. Without this bit the Command Verifier "TD 9.10 Bad Descriptor Test" failed. Setting this bit doesn't have any impact for SSP controller. Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") cc: stable@vger.kernel.org Signed-off-by: Pawel Laszczak <pawell@cadence.com> --- Changelog: v2: - removed some typos - added pep variable initialization - updated TRB_ESP description drivers/usb/cdns3/cdnsp-debug.h | 5 +++-- drivers/usb/cdns3/cdnsp-ep0.c | 19 ++++++++++++++++--- drivers/usb/cdns3/cdnsp-gadget.h | 6 ++++++ drivers/usb/cdns3/cdnsp-ring.c | 3 ++- 4 files changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/usb/cdns3/cdnsp-debug.h b/drivers/usb/cdns3/cdnsp-debug.h index cd138acdcce1..86860686d836 100644 --- a/drivers/usb/cdns3/cdnsp-debug.h +++ b/drivers/usb/cdns3/cdnsp-debug.h @@ -327,12 +327,13 @@ static inline const char *cdnsp_decode_trb(char *str, size_t size, u32 field0, case TRB_RESET_EP: case TRB_HALT_ENDPOINT: ret = scnprintf(str, size, - "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c", + "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c %c", cdnsp_trb_type_string(type), ep_num, ep_id % 2 ? "out" : "in", TRB_TO_EP_INDEX(field3), field1, field0, TRB_TO_SLOT_ID(field3), - field3 & TRB_CYCLE ? 'C' : 'c'); + field3 & TRB_CYCLE ? 'C' : 'c', + field3 & TRB_ESP ? 'P' : 'p'); break; case TRB_STOP_RING: ret = scnprintf(str, size, diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c index f317d3c84781..9280a7b97e20 100644 --- a/drivers/usb/cdns3/cdnsp-ep0.c +++ b/drivers/usb/cdns3/cdnsp-ep0.c @@ -414,6 +414,7 @@ static int cdnsp_ep0_std_request(struct cdnsp_device *pdev, void cdnsp_setup_analyze(struct cdnsp_device *pdev) { struct usb_ctrlrequest *ctrl = &pdev->setup; + struct cdnsp_ep *pep; int ret = -EINVAL; u16 len; @@ -427,10 +428,22 @@ void cdnsp_setup_analyze(struct cdnsp_device *pdev) goto out; } + pep = &pdev->eps[0]; + /* Restore the ep0 to Stopped/Running state. */ - if (pdev->eps[0].ep_state & EP_HALTED) { - trace_cdnsp_ep0_halted("Restore to normal state"); - cdnsp_halt_endpoint(pdev, &pdev->eps[0], 0); + if (pep->ep_state & EP_HALTED) { + /* + * Halt Endpoint Command for SSP2 for ep0 preserve current + * endpoint state and driver has to synchronize the + * software endpoint state with endpoint output context + * state. + */ + if (GET_EP_CTX_STATE(pep->out_ctx) == EP_STATE_HALTED) { + cdnsp_halt_endpoint(pdev, pep, 0); + } else { + pep->ep_state &= ~EP_HALTED; + pep->ep_state |= EP_STOPPED; + } } /* diff --git a/drivers/usb/cdns3/cdnsp-gadget.h b/drivers/usb/cdns3/cdnsp-gadget.h index 2afa3e558f85..b1665f9e9ee5 100644 --- a/drivers/usb/cdns3/cdnsp-gadget.h +++ b/drivers/usb/cdns3/cdnsp-gadget.h @@ -987,6 +987,12 @@ enum cdnsp_setup_dev { #define STREAM_ID_FOR_TRB(p) ((((p)) << 16) & GENMASK(31, 16)) #define SCT_FOR_TRB(p) (((p) << 1) & 0x7) +/* + * Halt Endpoint Command TRB field. + * The ESP bit only exists in the SSP2 controller. + */ +#define TRB_ESP BIT(9) + /* Link TRB specific fields. */ #define TRB_TC BIT(1) diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c index fd06cb85c4ea..d397d28efc6e 100644 --- a/drivers/usb/cdns3/cdnsp-ring.c +++ b/drivers/usb/cdns3/cdnsp-ring.c @@ -2483,7 +2483,8 @@ void cdnsp_queue_halt_endpoint(struct cdnsp_device *pdev, unsigned int ep_index) { cdnsp_queue_command(pdev, 0, 0, 0, TRB_TYPE(TRB_HALT_ENDPOINT) | SLOT_ID_FOR_TRB(pdev->slot_id) | - EP_ID_FOR_TRB(ep_index)); + EP_ID_FOR_TRB(ep_index) | + (!ep_index ? TRB_ESP : 0)); } void cdnsp_force_header_wakeup(struct cdnsp_device *pdev, int intf_num) -- 2.43.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: cdnsp: Fix issue with CV Bad Descriptor test 2025-06-18 5:39 ` [PATCH v2] usb: cdnsp: Fix issue with CV Bad Descriptor test Pawel Laszczak @ 2025-06-19 2:27 ` Peter Chen (CIX) 0 siblings, 0 replies; 2+ messages in thread From: Peter Chen (CIX) @ 2025-06-19 2:27 UTC (permalink / raw) To: Pawel Laszczak Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org On 25-06-18 05:39:27, Pawel Laszczak wrote: > The SSP2 controller has extra endpoint state preserve bit (ESP) which > setting causes that endpoint state will be preserved during > Halt Endpoint command. It is used only for EP0. > Without this bit the Command Verifier "TD 9.10 Bad Descriptor Test" > failed. > Setting this bit doesn't have any impact for SSP controller. > > Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") > cc: stable@vger.kernel.org > Signed-off-by: Pawel Laszczak <pawell@cadence.com> > --- > Changelog: > v2: > - removed some typos > - added pep variable initialization > - updated TRB_ESP description > > drivers/usb/cdns3/cdnsp-debug.h | 5 +++-- > drivers/usb/cdns3/cdnsp-ep0.c | 19 ++++++++++++++++--- > drivers/usb/cdns3/cdnsp-gadget.h | 6 ++++++ > drivers/usb/cdns3/cdnsp-ring.c | 3 ++- > 4 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/cdns3/cdnsp-debug.h b/drivers/usb/cdns3/cdnsp-debug.h > index cd138acdcce1..86860686d836 100644 > --- a/drivers/usb/cdns3/cdnsp-debug.h > +++ b/drivers/usb/cdns3/cdnsp-debug.h > @@ -327,12 +327,13 @@ static inline const char *cdnsp_decode_trb(char *str, size_t size, u32 field0, > case TRB_RESET_EP: > case TRB_HALT_ENDPOINT: > ret = scnprintf(str, size, > - "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c", > + "%s: ep%d%s(%d) ctx %08x%08x slot %ld flags %c %c", > cdnsp_trb_type_string(type), > ep_num, ep_id % 2 ? "out" : "in", > TRB_TO_EP_INDEX(field3), field1, field0, > TRB_TO_SLOT_ID(field3), > - field3 & TRB_CYCLE ? 'C' : 'c'); > + field3 & TRB_CYCLE ? 'C' : 'c', > + field3 & TRB_ESP ? 'P' : 'p'); > break; > case TRB_STOP_RING: > ret = scnprintf(str, size, > diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c > index f317d3c84781..9280a7b97e20 100644 > --- a/drivers/usb/cdns3/cdnsp-ep0.c > +++ b/drivers/usb/cdns3/cdnsp-ep0.c > @@ -414,6 +414,7 @@ static int cdnsp_ep0_std_request(struct cdnsp_device *pdev, > void cdnsp_setup_analyze(struct cdnsp_device *pdev) > { > struct usb_ctrlrequest *ctrl = &pdev->setup; > + struct cdnsp_ep *pep; > int ret = -EINVAL; > u16 len; > > @@ -427,10 +428,22 @@ void cdnsp_setup_analyze(struct cdnsp_device *pdev) > goto out; > } > > + pep = &pdev->eps[0]; > + > /* Restore the ep0 to Stopped/Running state. */ > - if (pdev->eps[0].ep_state & EP_HALTED) { > - trace_cdnsp_ep0_halted("Restore to normal state"); > - cdnsp_halt_endpoint(pdev, &pdev->eps[0], 0); > + if (pep->ep_state & EP_HALTED) { > + /* > + * Halt Endpoint Command for SSP2 for ep0 preserve current > + * endpoint state and driver has to synchronize the > + * software endpoint state with endpoint output context > + * state. > + */ > + if (GET_EP_CTX_STATE(pep->out_ctx) == EP_STATE_HALTED) { > + cdnsp_halt_endpoint(pdev, pep, 0); > + } else { > + pep->ep_state &= ~EP_HALTED; > + pep->ep_state |= EP_STOPPED; > + } Why else {} is needed? Peter > } > > /* > diff --git a/drivers/usb/cdns3/cdnsp-gadget.h b/drivers/usb/cdns3/cdnsp-gadget.h > index 2afa3e558f85..b1665f9e9ee5 100644 > --- a/drivers/usb/cdns3/cdnsp-gadget.h > +++ b/drivers/usb/cdns3/cdnsp-gadget.h > @@ -987,6 +987,12 @@ enum cdnsp_setup_dev { > #define STREAM_ID_FOR_TRB(p) ((((p)) << 16) & GENMASK(31, 16)) > #define SCT_FOR_TRB(p) (((p) << 1) & 0x7) > > +/* > + * Halt Endpoint Command TRB field. > + * The ESP bit only exists in the SSP2 controller. > + */ > +#define TRB_ESP BIT(9) > + > /* Link TRB specific fields. */ > #define TRB_TC BIT(1) > > diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c > index fd06cb85c4ea..d397d28efc6e 100644 > --- a/drivers/usb/cdns3/cdnsp-ring.c > +++ b/drivers/usb/cdns3/cdnsp-ring.c > @@ -2483,7 +2483,8 @@ void cdnsp_queue_halt_endpoint(struct cdnsp_device *pdev, unsigned int ep_index) > { > cdnsp_queue_command(pdev, 0, 0, 0, TRB_TYPE(TRB_HALT_ENDPOINT) | > SLOT_ID_FOR_TRB(pdev->slot_id) | > - EP_ID_FOR_TRB(ep_index)); > + EP_ID_FOR_TRB(ep_index) | > + (!ep_index ? TRB_ESP : 0)); > } > > void cdnsp_force_header_wakeup(struct cdnsp_device *pdev, int intf_num) > -- > 2.43.0 > -- Best regards, Peter ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-19 2:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250618053148.777461-1-pawell@cadence.com>
2025-06-18 5:39 ` [PATCH v2] usb: cdnsp: Fix issue with CV Bad Descriptor test Pawel Laszczak
2025-06-19 2:27 ` Peter Chen (CIX)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.