[RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

[RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

[avinashlalotra]

The local variable 'node' was used only once to retrieve dev->of_node
in a call to irq_domain_create_legacy(). This patch inlines the usage
and removes the redundant variable, improving code clarity.

No functional change intended.

Signed-off-by: avinashlalotra <abinashsinghlalotra@gmail.com>
---
 drivers/mfd/twl4030-irq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 232c2bfe8c18..a2ab5deef9e2 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -676,7 +676,6 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 	static struct irq_chip	twl4030_irq_chip;
 	int			status, i;
 	int			irq_base, irq_end, nr_irqs;
-	struct			device_node *node = dev->of_node;
 
 	/*
 	 * TWL core and pwr interrupts must be contiguous because
@@ -691,7 +690,7 @@ int twl4030_init_irq(struct device *dev, int irq_num)
 		return irq_base;
 	}
 
-	irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
+	irq_domain_create_legacy(of_fwnode_handle(dev->of_node), nr_irqs, irq_base, 0,
 				 &irq_domain_simple_ops, NULL);
 
 	irq_end = irq_base + TWL4030_CORE_NR_IRQS;
-- 
2.43.0

Re: (subset) [RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

[Lee Jones]

On Fri, 13 Jun 2025 17:52:51 +0530, avinashlalotra wrote:
> The local variable 'node' was used only once to retrieve dev->of_node
> in a call to irq_domain_create_legacy(). This patch inlines the usage
> and removes the redundant variable, improving code clarity.
> 
> No functional change intended.
> 
> 
> [...]

Applied, thanks!

[1/1] mfd: twl4030-irq: remove redundant 'node' variable
      commit: 29be779ed76e7bac378be9edd213b0ddc2f20e0f

--
Lee Jones [李琼斯]

Re: (subset) [RFC PATCH] mfd: twl4030-irq: remove redundant 'node' variable

[Lee Jones]

On Thu, 19 Jun 2025, Lee Jones wrote:

> On Fri, 13 Jun 2025 17:52:51 +0530, avinashlalotra wrote:
> > The local variable 'node' was used only once to retrieve dev->of_node
> > in a call to irq_domain_create_legacy(). This patch inlines the usage
> > and removes the redundant variable, improving code clarity.
> > 
> > No functional change intended.
> > 
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] mfd: twl4030-irq: remove redundant 'node' variable
>       commit: 29be779ed76e7bac378be9edd213b0ddc2f20e0f

Sorry, ignore this.  I removed it.

Your sign-off and author should contain your real name.

-- 
Lee Jones [李琼斯]